[KCM][WIP] Add KCModuleData
Needs RevisionPublic
Actions

Authored by bport on Mar 31 2020, 9:41 AM.

Details

Reviewers

ervin
meven
crossi
hchain

Group Reviewers

Plasma

Summary

Add KCModuleData for fonts, colors, cursors and spellchecking

Diff Detail

Repository

R119 Plasma Desktop

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 25285
Build 25303: arc lint + arc unit

bport created this revision.Mar 31 2020, 9:41 AM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 31 2020, 9:41 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

bport requested review of this revision.Mar 31 2020, 9:41 AM

Harbormaster completed remote builds in B24520: Diff 78971.Mar 31 2020, 9:41 AM

bport added a dependency: D28461: In sidebar mode show if a module is in default state or not.Mar 31 2020, 9:41 AM

You reckon we should do a simple base class that just does settings->isDefaults() since that will be quite a common thing?

bport mentioned this in D28461: In sidebar mode show if a module is in default state or not.Mar 31 2020, 7:21 PM

Adapt to kcmutils update and add cursor, fonts, spellchecking example

Harbormaster completed remote builds in B24853: Diff 79497.Apr 6 2020, 3:42 PM

ervin requested changes to this revision.Apr 7 2020, 5:08 PM

ervin added inline comments.

kcms/colors/colorsstateprobe.cpp
29 ↗	(On Diff #79497)	I'm not sure I see the point of doing this... You don't need that member variable anyway. You could just have in the ctor body the following: `registerSetting(new ColorsSettings(this));`

This revision now requires changes to proceed.Apr 7 2020, 5:08 PM

Rename state probe to data and use them in KCM

And fix defaultness of spellchecking inside data (default at loading without widget state)

Harbormaster completed remote builds in B25027: Diff 79781.Apr 10 2020, 5:32 PM

fix build

Harbormaster completed remote builds in B25285: Diff 80215.Apr 15 2020, 3:57 PM

bport retitled this revision from [KCM] Add color state probe to allow system settings to display current default state to [KCM][WIP] Add KCModuleData .Apr 15 2020, 4:35 PM

bport edited the summary of this revision. (Show Details)

Only a small thing left I think

kcms/cursortheme/cursorthemedata.h
33	Needs a cleanup I guess

This revision now requires changes to proceed.Apr 21 2020, 6:37 PM

+1 for a simple base class so we can avoid so much boilerplate

Revision Contents
Changeset List

		Path
M		kcms/colors/CMakeLists.txt (1 line)
M		kcms/colors/colors.h (3 lines)
M		kcms/colors/colors.cpp (21 lines)
A	M	kcms/colors/colorsdata.h (42 lines)
A	M	kcms/colors/colorsdata.cpp (39 lines)
M		kcms/cursortheme/CMakeLists.txt (2 lines)
A	M	kcms/cursortheme/cursorthemedata.h (43 lines)
A	M	kcms/cursortheme/cursorthemedata.cpp (40 lines)
M		kcms/cursortheme/kcmcursortheme.h (3 lines)
M		kcms/cursortheme/kcmcursortheme.cpp (35 lines)
M		kcms/fonts/CMakeLists.txt (2 lines)
M		kcms/fonts/fonts.h (6 lines)
M		kcms/fonts/fonts.cpp (73 lines)
A	M	kcms/fonts/fontsdata.h (45 lines)
A	M	kcms/fonts/fontsdata.cpp (46 lines)
M		kcms/spellchecking/CMakeLists.txt (2 lines)
M		kcms/spellchecking/spellchecking.h (8 lines)
M		kcms/spellchecking/spellchecking.cpp (34 lines)
A	M	kcms/spellchecking/spellcheckingdata.h (43 lines)
A	M	kcms/spellchecking/spellcheckingdata.cpp (69 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78971	4b2639e		Mar 31 2020, 9:41 AM	★	★
Diff 2	79497	fa8e49b	Adapt to kcmutils update and add cursor, fonts, spellchecking example	Apr 6 2020, 3:42 PM	★	★
Diff 3	79781	90ac7c2	Rename state probe to data and use them in KCM	Apr 10 2020, 5:32 PM	★	★
Diff 4	80215	9f34469	fix build	Apr 15 2020, 3:57 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
09b7a7012e2a	739aaf90ef8f	9f34469d04e3	Benjamin Port	[KCM] Add color state probe to allow system settings to display current default… (Show More…)	Mar 31 2020, 9:20 AM

Status	Author	Revision
Needs Revision	bport	D28462 [KCM][WIP] Add KCModuleData
Needs Review	bport	D28461 In sidebar mode show if a module is in default state or not
Closed	bport	D28460 Add KCModuleData as base class for plugin