KCM/GlobalShortut: convert FOREACH and old signal syntax
Needs ReviewPublic

Authored by meven on Wed, Mar 25, 2:50 PM.

Details

Reviewers
ervin
bport
crossi
hchain
Group Reviewers
Plasma
Test Plan

Builds, changed a shortcut and back again

Diff Detail

Repository
R119 Plasma Desktop
Branch
shortcuts
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24251
Build 24269: arc lint + arc unit
meven created this revision.Wed, Mar 25, 2:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Mar 25, 2:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Wed, Mar 25, 2:50 PM
davidedmundson added inline comments.
kcms/keys/globalshortcuts.cpp
42

Use markAsChanged then you don't need to overload.

kcms/keys/kglobalshortcutseditor.h
84

why not const QStringList &

ahmadsamir added inline comments.
kcms/keys/export_scheme_dialog.cpp
46

const QString &

74

const QAbstractButton *button

kcms/keys/kglobalshortcutseditor.cpp
708

I would make the ComponentData::editor() method const, then 'const ComponentData *cd'.

meven updated this revision to Diff 78522.Thu, Mar 26, 8:38 AM
meven marked 4 inline comments as done.

Review comments, code formating more const

meven marked an inline comment as done.Fri, Mar 27, 1:18 PM