Switch to MaterialComponents theme
ClosedPublic

Authored by eduisters on Jan 7 2019, 2:21 PM.

Details

Summary

Androidx introduced new Materialcomponents themes, use them instead of
Theme.AppCompat. This also causes AlertDialogs and PreferenceDialogFragments
to be styled correctly

BeforeAfter

(Ok button is disabled if you are wondering)

Test Plan

Apply patch, verify everything still looks as expected

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Jan 7 2019, 2:21 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJan 7 2019, 2:21 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Jan 7 2019, 2:21 PM
eduisters edited the summary of this revision. (Show Details)Jan 7 2019, 2:29 PM
eduisters added a reviewer: KDE Connect.
albertvaka accepted this revision.Jan 7 2019, 8:02 PM
This revision is now accepted and ready to land.Jan 7 2019, 8:02 PM
This revision was automatically updated to reflect the committed changes.

Since this patch, buttons in dialog boxes have no margin on my phone:

Before:

After: