Do not close m_socket in socketError()

Authored by eduisters on Dec 16 2018, 4:16 PM.

Description

Do not close m_socket in socketError()

Summary:
When android closes the payload socket (cancel share) calling m_socket.close() results
in a recursive call to onError eventually leading to a segmentation violation

Test Plan:
Install D16491, share a large file from desktop to android and cancel the share on Android through
the notification. kdeconnectd crashes almost 100% of the time. (It doesn't crash when it detects
a disconnect in sendNextPacket)

Reviewers: KDE Connect, nicolasfella

Reviewed By: KDE Connect, nicolasfella

Subscribers: kdeconnect

Tags: KDE Connect

Differential Revision: https://phabricator.kde.org/D17628

Details

Committed
eduistersJan 6 2019, 11:43 AM
Reviewer
KDE Connect
Differential Revision
D17628: Do not close m_socket in socketError()
Parents
R224:71c5a1b248f3: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown