Diffusion KDE Connect - Android application 9fb780f9197c

Migrate from PreferenceActivity to PreferenceFragment because it has been…
9fb780f9197c
Actions

Authored by eduisters on Jan 6 2019, 11:26 AM.

Description

Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11

Summary:
PreferenceActivity has been deprecated since Android 3.0 API 11 in favour of PreferenceFragment


Before

After

Test Plan:
Apply patch and observe that the DeviceSettings and PluginSettings screen behave as expected
and now also follow material design guidelines

Reviewers: KDE Connect, nicolasfella

Reviewed By: KDE Connect, nicolasfella

Subscribers: kdeconnect

Tags: KDE Connect

Differential Revision: https://phabricator.kde.org/D17859

Details

Committed

eduisters

Jan 6 2019, 11:36 AM

Reviewer

KDE Connect

Differential Revision

D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11

Parents

R225:045e329b5310: GIT_SILENT made messages (after extraction)

Branches

Unknown

Tags

Unknown

eduisters committed R225:9fb780f9197c: Migrate from PreferenceActivity to PreferenceFragment because it has been… (authored by eduisters).Jan 6 2019, 11:36 AM

Changes (22)

				Path	Packages
	M			AndroidManifest.xml
	A			res/layout/activity_device_settings.xml
	M			res/layout/preference_with_button.xml
	M			res/values/strings.xml
	M			res/xml/findmyphoneplugin_preferences.xml
	M			src/org/kde/kdeconnect/BackgroundService.java
	M			src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java
	M			src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhonePlugin.java
	A			src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneSettingsFragment.java
	M			src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java
	M			src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java
	M			src/org/kde/kdeconnect/Plugins/Plugin.java
	M			src/org/kde/kdeconnect/Plugins/RemoteKeyboardPlugin/RemoteKeyboardPlugin.java
	M			src/org/kde/kdeconnect/Plugins/RemoteKeyboardPlugin/RemoteKeyboardService.java
	M			src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java
	V			src/org/kde/kdeconnect/Plugins/SharePlugin/{ShareSettingsActivity.java → ShareSettingsFragment.java}
	V			src/org/kde/kdeconnect/Plugins/SharePlugin/{ShareSettingsFragment.java ← ShareSettingsActivity.java}
	M			src/org/kde/kdeconnect/UserInterface/DeviceSettingsActivity.java
	A			src/org/kde/kdeconnect/UserInterface/DeviceSettingsFragment.java
	M			src/org/kde/kdeconnect/UserInterface/PluginPreference.java
	D			src/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java
	A			src/org/kde/kdeconnect/UserInterface/PluginSettingsFragment.java