I have one comment: ISO files are supposed to be burned to optical media. The fact that one can create hybrid ISOs which can also be written to USB drives doesn't mean that all ISOs can be written to USB drives. Most Linux distros generate hybrid ISOs, but some do not, and other operating systems (Windows, for example) do not.

In D21042#461797, @ngraham wrote:

Thanks, the crash is fixed now.

I'm still not really on board with some of the style changes though. I understand how this makes hacking on the project easier for you, but it makes it harder for everyone else in the KDE community who isn't you or doesn't work at your company and doesn't follow the same style guide 8 hours a day. I'd be a hard "No" if anyone else proposed this, but you're the author and maintainer, so ultimately it's your call. However I'll note that you disappeared for a few years and left Spectacle to be community-maintained. During this time, I fended off an attempt to incubate yet another screenshot app (KSnip), which would have left Spectacle to die. Spectacle benefited from the fact that the coding style was more coupled to the general KDE style, so it was easier for people to quickly get acquainted with the code and contribute. As a result, Spectacle didn't die during this challenging time for it. I'm happy you're back now, but what happens if and when you leave again? We want for KDE apps to be as accessible as possible to all contributors, not just you. This refactor is generally very welcome, but it also has other changes within it that I think have the potential to the codebase less accessible to other members of the KDE community as well as casual contributors. There's always a balance to be struck here, and I can see that there's not an easy answer.

It's your call, but I encourage you to consider the implications for Spectacle as KDE project, not just as a Boudhayan Gupta project. :)

Fix crash in release-to-capture, address minor comments

In D21042#461436, @davidre wrote:

Have to agree with Nate regarding the naming convention you are using - feels odd to me. I don't think lConfigMgr is more readable than configManager. Also following a style guide which you can't make public is a strange move in a community like KDE.

In D21042#461418, @ngraham wrote:

In general +1, very nice. I haven't tested the now-working Wayland Rectangular Region mode yes, but I will.

I have to say I don't really like how the proposed new the prefixing style works for boolean variables. It leads to awkwardness like if (theNotifyOnGrab) {. Making the name a noun makes me think it's some object, not a boolean. Compare that to the status quo: if (notifyOnGrab) {, which I think is more readable.

Also prepending l to local variables makes conceptual sense but I admit it looks a bit odd to me given that's not used anywhere else in the KDE style guide. It may be more consistent for you to code Spectacle the way you would at work, but it's less consistent for everyone else in the KDE community who doesn't work there. Ultimately you're the maintainer but KDE has its own set of coding style guidelines and in general I think it might be best to stick with it, or at least not deviate from it too much. :) I won't make hay about it though.

I don't know how Phab works with submitting patches directly from the web interface or through arc, but please don't merge this - the way to submit this change is to merge the bgupta/platform-backend-refactor branch to master.

LGTM

This should now be sorted.

There's no way in hell we can make email addresses public without the user's explicit consent. It has to be opt-in. Literally everyone on this thread except Ben lives in Europe. The law of the land is very protective of personal data, which most certainly includes email addresses. Refer to Directive 95/46/EC, and to the Bundesdatenschutzgesetz, Sections 4, 4a and 5. I'm sure Spain and Italy and other EU countries have implementations of the EC directive. I could well sue KDE e.V. for making my email address public, if I haven't consented to it.

That won't really help, since Propagator uses the exact same logic, adjusted for GitPython's API.

Good point. This is going to need more insidious changes in Spectacle. Alright, ship this for now.

Yeah, I was planning on each plugin returning a list of supported grab modes and ancillary features (on click, timeouts, etc), and modifying the UI based on that information.

Hmm, so "On Click" mode is always selected.

Looks lovely. I just have one nitpick, which is in an inline comment below.

Does this mean taking a full screen screenshot also requires a click anywhere on the screen from the user? Or is the click optional?

Sorry, didn't notice this earlier. Good to go.

This is lovely.

Committed in rPLASMAWORKSPACEaafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds.

In D2983#55400, @markuss wrote:

This patch modifies an existing file. Removing the original copyright is illegal! If you want your new code to be under a different license (which is fine), you need to rework the header to state: "Originally based on XY by XY under the following conditions XYZ" or something like that, although I personally think changing the license adds to much confusion for too little gain. With the original license intact, just a second copyright line is needed.

Done. It has been moved to extragear/multimedia/

I've forgotten this just once in the past, but the changes propagated just fine.