Support screenshot current screen and fullscreen on KWin/Wayland
ClosedPublic
Actions

Authored by graesslin on Nov 23 2016, 3:15 PM.

Details

Reviewers

bgupta

Group Reviewers

Plasma on Wayland

Commits

Summary

Comes with slight refactoring for better code sharing.

Repository

R166 Spectacle

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin retitled this revision from to Support screenshot current screen and fullscreen on KWin/Wayland.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Looks lovely. I just have one nitpick, which is in an inline comment below.

src/PlatformBackends/KWinWaylandImageGrabber.h
48	Can we re-use the ImageGrabber::CaptureMode enum here?

This revision is now accepted and ready to land.Nov 23 2016, 6:48 PM

src/PlatformBackends/KWinWaylandImageGrabber.h
48	I would say no as the CaptureMode contains several choices which don't fit here. E.g. we cannot capture the ActiveWindow or a RectangularRegion through the DBus interface.

Good point. This is going to need more insidious changes in Spectacle. Alright, ship this for now.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/PlatformBackends/KWinWaylandImageGrabber.h (13 lines)
M			src/PlatformBackends/KWinWaylandImageGrabber.cpp (138 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8453	0af560b		Nov 23 2016, 3:15 PM	★	★
Diff 2	8494	0af560b	rSPECTACLE517a7baf46a4ca0a45f32fd3f2b1b7210b180134	Nov 23 2016, 3:15 PM	★	★