Support screenshot current screen and fullscreen on KWin/Wayland

Authored by graesslin on Nov 23 2016, 3:15 PM.



Comes with slight refactoring for better code sharing.

Diff Detail

R166 Spectacle
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 8453.Nov 23 2016, 3:15 PM
graesslin retitled this revision from to Support screenshot current screen and fullscreen on KWin/Wayland.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma on Wayland. · View Herald TranscriptNov 23 2016, 3:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bgupta accepted this revision.Nov 23 2016, 6:48 PM
bgupta edited edge metadata.

Looks lovely. I just have one nitpick, which is in an inline comment below.


Can we re-use the ImageGrabber::CaptureMode enum here?

This revision is now accepted and ready to land.Nov 23 2016, 6:48 PM
graesslin added inline comments.Nov 24 2016, 7:26 AM

I would say no as the CaptureMode contains several choices which don't fit here. E.g. we cannot capture the ActiveWindow or a RectangularRegion through the DBus interface.

Good point. This is going to need more insidious changes in Spectacle. Alright, ship this for now.

This revision was automatically updated to reflect the committed changes.