Add interactive position selection to screenshot screen under cursor
ClosedPublic

Authored by graesslin on Nov 23 2016, 3:13 PM.

Details

Summary

A second interactive selection mode gets added to select a position on
the screen. This is handled by the same input event filter as for the
window selection. Just that instead of returning a window, it returns a
QPoint.

This allows to pick a point on the screen which we need to screenshot
the screen under the mouse cursor and in future for color picking.

The screenshot effect provides two new dbus methods to (interactively)
select a screen or fullscreen. This allows spectacle to screenshot the
(full) screen with still having the user in control.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 8452.Nov 23 2016, 3:13 PM
graesslin retitled this revision from to Add interactive position selection to screenshot screen under cursor.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptNov 23 2016, 3:13 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
bgupta edited edge metadata.Nov 23 2016, 6:45 PM

Does this mean taking a full screen screenshot also requires a click anywhere on the screen from the user? Or is the click optional?

In D3475#64750, @bgupta wrote:

Does this mean taking a full screen screenshot also requires a click anywhere on the screen from the user? Or is the click optional?

Yes taking full screen screenshot requires a click. The user must confirm to the screen shot! It's a security feature.

bgupta accepted this revision.Nov 24 2016, 5:22 PM
bgupta edited edge metadata.

Hmm, so "On Click" mode is always selected.

This revision is now accepted and ready to land.Nov 24 2016, 5:22 PM
In D3475#64970, @bgupta wrote:

Hmm, so "On Click" mode is always selected.

Yeah, I want to modify the UI of spectacle to not offer unsupported options.

Yeah, I was planning on each plugin returning a list of supported grab modes and ancillary features (on click, timeouts, etc), and modifying the UI based on that information.

Ship this for now. I'll work on this when I'm done with college (end of December this year).

This revision was automatically updated to reflect the committed changes.