• Remove the recolor module. It is D28076 now

In D28072#629441, @cblack wrote:

In D28072#629439, @gikari wrote:

You simply test the recolouration like how it's been up until now—restart the applications.

It doesn't work. This is what I was talking about:

It seems like it applies randomly whenever the GTK app would like to update the colors, but with that module it's predictable.

You seem to be testing with Nautilus, which doesn't actually close when you press the close button.

You simply test the recolouration like how it's been up until now—restart the applications.

It doesn't work. This is what I was talking about:

It seems like it applies randomly whenever the GTK app would like to update the colors, but with that module it's predictable.

• I should add the recoloration module to autoload with GTK applications

• Rebase on master
• Add recoloration module

Fine. It builds.

I reverted the commits ( R99:306e01d86ab9a891ec70219802ce01572b0d4025 and R99:306e01d86ab9a891ec70219802ce01572b0d4025 ) for recoloration module, to fix the CI. I think you need to create a new revision to add recolaration module in a proper way and with proper fixes to GNOME libraries handling.

It builds, but why aren't you using that stuff inside of FingGTK3.cmake module? It actually uses it inside already, but with some bugs, that prevents from building last patch.

I tried to change these ones to GTK3_LIBRARY and GLIB2_LIBRARY, but now it throws this:

/home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:37: undefined reference to `g_type_check_instance_cast'

Seems like I've made a mistake. This does not build.

/home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:21:10: fatal error: gtk/gtk.h: No such file or directory
   21 | #include <gtk/gtk.h>
      |          ^~

Fix "forgetting to pull local master"

Diff against master

Rebase on master

Ping

GTK needs to be configured to load the GTK module colorreload-gtk-module.

Nice! Does it need to be manually passed to GTK apps when testing D28072?

Yes, my case.

https://phabricator.kde.org/R99:b6e7c6f056740e936adc94b7a843f6448f6830ab

I added a unit test, but I do not know why it is failing. Actually I do not know if I've added it correctly at all. Help is very necsasary.

• Add unit-test

I am not sure where I should add it. Is it supposed to be a new pair of bug418486 .h/.cpp files? Or should the test reside inside keys.cpp in big intimidating 500 line wide MappingTest function?

• Add forgotten toolbar style

In favor of D27957

Update function name

Ping! After D27904 this should be working.

Ping! Do I sound reasonable? Any suggestions how can it be simplified without depending on kde-gtk-config?

Ping! Does it work for everybody? For me everything is OK.

Ok. So, can I land it or should I wait for other reviewers? Also, should I make the dependency REQUIRED or leave it optional?

In D25324#624229, @eszlari wrote:

This bug is not fixed by this patch. xsettingsd needs to be started in plasma-workspace/startkde/startplasma.cpp (or by systemd in the future).

Ping!

Use arg instead of + + + + + +