The title is somewhat self explanatory.
- Group Reviewers
- R99:306e01d86ab9: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them
gtk-app-here --gtk-module colorreload-gtk-module
Would you mind setting this at the parent CMakeLists.txt?
Would you mind making this as a subproject?
Also, could you remove spaces around parentaces to match the CMake style with the one, that is in kded and kconf_update directories?
Isn't the PUBLIC/PRIVATE modifiers a good modern CMake practice? The same for target_include_directories
GTK needs to be configured to load the GTK module colorreload-gtk-module.
You mean we need to add gtk-modules=colorreload-gtk-module to settings.ini? And how to add this module to autoload in Wayland?
Seems like I've made a mistake. This does not build.
/home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:21:10: fatal error: gtk/gtk.h: No such file or directory 21 | #include <gtk/gtk.h> | ^~
I tried to change these ones to GTK3_LIBRARY and GLIB2_LIBRARY, but now it throws this:
/home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:37: undefined reference to `g_type_check_instance_cast'
It seems like you use other variables, than in other parts of kde-gtk-config.
This change, and changes subsequent to it have broken the build of kde-gtk-config.
Plasma developers - this is one of several breakages which have occurred over the last couple of days which you have failed to address in a timely fashion.
Should this behaviour continue then CI coverage for Plasma will be discontinued and Plasma repositories will be blacklisted from the CI system and be unable to be used by other KDE software projects.