GNOME libraries were being handled in a manner not
as elegant as possible with CMake's built-in pkgconf handling.
This patch uses CMake's built-in pkgconf handling to trim excess
code and improve style (${GTK_LIBRARIES} -> PkgConfig::GTK+3).
Details
Details
- Reviewers
gikari apol - Group Reviewers
Plasma - Commits
- R99:db87b4d270a1: Improve CMake handling of GNOME libraries
R99:7f7a57095cf1: Improve CMake handling of GNOME libraries
See that everything still builds and links as expected.
Diff Detail
Diff Detail
- Repository
- R99 KDE Gtk Configuration Tool
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
It builds, but why aren't you using that stuff inside of FingGTK3.cmake module? It actually uses it inside already, but with some bugs, that prevents from building last patch.
Comment Actions
I reverted the commits ( R99:306e01d86ab9a891ec70219802ce01572b0d4025 and R99:306e01d86ab9a891ec70219802ce01572b0d4025 ) for recoloration module, to fix the CI. I think you need to create a new revision to add recolaration module in a proper way and with proper fixes to GNOME libraries handling.
Comment Actions
It's a lot of CMake code that duplicates what CMake already offers with its pkgconf handling. There's no reason to use it when CMake can wrangle that stuff for you.
Comment Actions
This has been reverted. @cblack, please take a look at what has happened. Seems like CI is missing some dependency.
Comment Actions
See https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/49 for possible resolution
Comment Actions
Ok, let's keep our eyes on CI now. Everything should be fine, since the dependencies didn't change.