[Various KCMs] Notify about changes in GTK related settings
ClosedPublic

Authored by gikari on Mon, Mar 9, 8:34 PM.

Details

Summary

Also save colors before saving colorScheme name, so that we can
correctly use heuristic in GTK Config, after the moment we know, that
color scheme has changed.

Test Plan

Check if the order of saving colors and saving color scheme name does not break anything.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gikari created this revision.Mon, Mar 9, 8:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Mar 9, 8:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Mon, Mar 9, 8:34 PM
ngraham accepted this revision.Tue, Mar 10, 4:22 PM
ngraham added reviewers: ervin, bport, meven.
ngraham added a subscriber: ngraham.

I'm finding myself wondering why we don't just make everything notify by default.

This revision is now accepted and ready to land.Tue, Mar 10, 4:22 PM
ervin added a comment.Mon, Mar 16, 5:20 PM

I'm finding myself wondering why we don't just make everything notify by default.

IMHO it's mostly a question of limiting the chatter on the bus.

This revision was automatically updated to reflect the committed changes.