[Gtk Config] Port cursor theme sync to KConfigWatcher
ClosedPublic

Authored by gikari on Mon, Mar 9, 1:22 PM.

Details

Summary

Port from deprecated dbus signal to KConfigWatcher.

Depends on: D27942

Test Plan
  1. Apply D27942
  2. Restart kded5
  3. Apply any cursor theme from KCM
  4. Check if GTK applications heve the changed cursor

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gikari created this revision.Mon, Mar 9, 1:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Mar 9, 1:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Mon, Mar 9, 1:22 PM
ngraham added a subscriber: ngraham.Mon, Mar 9, 3:34 PM
ngraham added inline comments.
kded/gtkconfig.h
89

onKcmInputSettingsChange (capitalize the I in Input)

Maybe also capitalize KCM?

Or maybe call it onCursorSettingsChange

gikari updated this revision to Diff 77293.Mon, Mar 9, 4:15 PM
gikari marked an inline comment as done.

Update function name

gikari added inline comments.Mon, Mar 9, 4:15 PM
kded/gtkconfig.h
89

This name comes from configuration file name and this function (theoretically) triggers on every change of the config, not necessary on cursor theme change, so I think that naming it onCursorSettingsChange is not very fair.

gikari marked an inline comment as done.Mon, Mar 9, 4:16 PM
ngraham accepted this revision.Mon, Mar 9, 4:19 PM
This revision is now accepted and ready to land.Mon, Mar 9, 4:19 PM
gikari retitled this revision from [Gtk Config] Port fonts sync to KConfigWatcher to [Gtk Config] Port cursor theme sync to KConfigWatcher.Mon, Mar 9, 5:52 PM
This revision was automatically updated to reflect the committed changes.