Good that it fixed %u the old behavior on su/sudo was to keep the %d from the parent process and now it just display "-" this particular behavior should be reversed ... i personally prefer displaying the parent %d instead of - plus i get use to it... (i am going to make a patch for that, let me know if it's worth posting it here ;))

Amazing :) great work and nice feature, tested this under v17.12.3 along with https://phabricator.kde.org/D19150... it works but

In D19150#415722, @elvisangelaccio wrote:

In D19150#415519, @ngraham wrote:

Hmm, we already had a patch to do this: D16648: Open externally called files/directories in new tabs.

@elvisangelaccio which one should we move forward with?

D16648 please, which is already under active review :)

@elvisangelaccio @ngraham thanks :) well pick the one that suite best your needs...

Removed forgotten unrelated root patching... root issue have been fixed in v18 anyway...

Thanks for this patch :) was patching it on my custom build... now regarding "drive-by download" i think it's just an education problem, user who clicks everywhere will get in trouble way before stumbling across such an attack... browser should by default ask before downloading anything but at least this is an available setting on most browser; now regarding cache (because browser tend to start downloading files even before they are saved) those directories are not scanned with baloo... any way at the end of the day all those issue should not be fixed in dolphin but on their side browser/file-indexer/etc.

@mart yes indeed i had the same thoughts afterward, this code need to be fixed upfront in QtQuick.Controls.Styles.Plasma or org.kde.plasma.components or somewhere else... any way there is track here if someone will work on it or need that modification :)

done ! :)
indentation updated (code tabulation/formatting)

this change provide :

• Different checkbox style
• Correct bug : background of the checkbox should be transparent when not checked this result in a white checkbox for dark theme making the user a little bit confused

i used plasmawindowed to make the capture and run different version at the same time