Dolphin single instance tabbed navigation
Needs ReviewPublic

Authored by intika on Feb 19 2019, 10:46 AM.

Details

Reviewers
None
Group Reviewers
Dolphin
Summary

Following https://github.com/Intika-Linux-KDE/kde-dolphin-single-instance

We should have an optional feature to be able to open new directory on the the same/single instance of dolphin over tabs this patch implement it and make it available through settings page.

Note 1: this code is tested with latest v17 (v17.12.3) my distro stable release use KF5 v5.42 and have not yet switched to newer release (its for soon) this makes testing/implementing this on dolphin v18 big time consuming for me... any way it should be easy to adapt the code for v18.

Note 2: the following additional diff may be useful

diff --git a/src/org.kde.dolphin.desktop b/src/org.kde.dolphin.desktop
index f187cef..f6418d2 100755
--- a/src/org.kde.dolphin.desktop
+++ b/src/org.kde.dolphin.desktop
@@ -42,7 +42,7 @@ Name[uk]=Dolphin
 Name[x-test]=xxDolphinxx
 Name[zh_CN]=Dolphin
 Name[zh_TW]=Dolphin
-Exec=dolphin %u
+Exec=dbus-launch dolphin "%u"
 Icon=system-file-manager
 Type=Application
 X-DocPath=dolphin/index.html

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
intika created this revision.Feb 19 2019, 10:46 AM
Restricted Application added a subscriber: kfm-devel. · View Herald TranscriptFeb 19 2019, 10:46 AM
intika requested review of this revision.Feb 19 2019, 10:46 AM
intika edited the summary of this revision. (Show Details)
intika edited the summary of this revision. (Show Details)Feb 19 2019, 10:49 AM
intika removed a subscriber: kfm-devel.
intika edited the summary of this revision. (Show Details)Feb 19 2019, 11:04 AM
intika updated this revision to Diff 52054.Feb 19 2019, 11:33 AM
intika edited the summary of this revision. (Show Details)

Removed forgotten unrelated root patching... root issue have been fixed in v18 anyway...

Hmm, we already had a patch to do this: D16648: Open externally called files/directories in new tabs.

@elvisangelaccio which one should we move forward with?

@elvisangelaccio @ngraham thanks :) well pick the one that suite best your needs...

I read the comments on the other diff

This one is adding settings feature as well here is why settings for this is important:

  1. as it changes the behavior of dolphin in a major way, user should have the choice
  2. it's not a complicated advanced setting asking for dbus or system call, it's simple it just let the user use single instance or not
  3. what about an advanced settings section ? or a hidden setting over config file
  4. i agree that settings should not be supercharged but the way of usage should not be forced either

We could add further feature and remove the settings like opening a folder with "ctrl" would open a new window

what about the konqueror patch that added that feature may be it's the best implementation.

Any way have a look and see what fit best :)

Hmm, we already had a patch to do this: D16648: Open externally called files/directories in new tabs.

@elvisangelaccio which one should we move forward with?

D16648 please, which is already under active review :)

Hmm, we already had a patch to do this: D16648: Open externally called files/directories in new tabs.

@elvisangelaccio which one should we move forward with?

D16648 please, which is already under active review :)

Great ;) feel free to pick this or that modification if it could help D16648

This comment was removed by thomasp.

This can probably be formally abandoned now.