Style enhancement for network management applet

Authored by intika on Apr 28 2018, 7:22 AM.


Group Reviewers

Checkbox style enhancement and background bug correction for dark theme

Diff Detail

Lint Skipped
Unit Tests Skipped
intika created this revision.Apr 28 2018, 7:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 28 2018, 7:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
intika requested review of this revision.Apr 28 2018, 7:22 AM
intika added a reviewer: Plasma.
intika retitled this revision from Style enhancement to Style enhancement for network management applet.
This comment was removed by intika.
zzag added a subscriber: zzag.EditedApr 28 2018, 9:20 PM

Indentation is a little bit off (maybe because you use tabs instead of spaces?).

intika added a comment.EditedApr 28 2018, 9:45 PM

this change provide :

  • Different checkbox style
  • Correct bug : background of the checkbox should be transparent when not checked this result in a white checkbox for dark theme making the user a little bit confused

i used plasmawindowed to make the capture and run different version at the same time

yes indeed it's a little bit off do i need to re-post ?

intika updated this revision to Diff 33267.EditedApr 28 2018, 9:59 PM

done ! :)
indentation updated (code tabulation/formatting)

intika updated this revision to Diff 33268.Apr 28 2018, 10:02 PM
intika edited the summary of this revision. (Show Details)Apr 28 2018, 10:05 PM
mart requested changes to this revision.May 2 2018, 9:46 AM
mart added a subscriber: mart.

imo that's not a thing to be fixed at the applet level, that's how that particular plasma theme looks, you can't fix a 3rd party plasma theme by patching applets to not follow it.
Probably we new a new standard element for checkbox background, but that has to be fixed in base theme and components

This revision now requires changes to proceed.May 2 2018, 9:46 AM
intika abandoned this revision.EditedMay 3 2018, 7:01 AM

@mart yes indeed i had the same thoughts afterward, this code need to be fixed upfront in QtQuick.Controls.Styles.Plasma or org.kde.plasma.components or somewhere else... any way there is track here if someone will work on it or need that modification :)