Show valid subprocess CWD for %D tab title format
ClosedPublic

Authored by mglb on Dec 30 2018, 3:08 AM.

Details

Summary

%D did work only with main process - for every subprocess it just
displayed "-". With the patch "-" is displayed only in processes for
which CWD can't be read (e.g. root processes).

Test Plan
  • Use %D in tab title format
  • Run vim
  • (optionally) run :cd /usr in vim

Actual result: "-" is shown in the title instead of %D
Expected result: valid CWD is shown in the title instead of %D

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb requested review of this revision.Dec 30 2018, 3:08 AM
mglb created this revision.
hindenburg accepted this revision.Dec 30 2018, 10:58 PM
hindenburg added a subscriber: hindenburg.

Looks fine - thanks - I notice this seems to fix %u which hasn't worked for a while it seems

This revision is now accepted and ready to land.Dec 30 2018, 10:58 PM
This revision was automatically updated to reflect the committed changes.
intika added a subscriber: intika.EditedFri, Apr 19, 9:00 PM

Good that it fixed %u the old behavior on su/sudo was to keep the %d from the parent process and now it just display "-" this particular behavior should be reversed ... i personally prefer displaying the parent %d instead of - plus i get use to it... (i am going to make a patch for that, let me know if it's worth posting it here ;))

mglb added a comment.Mon, Apr 22, 6:17 PM

Maybe just implement it using another letter? I guess both implementations have its fans