Hi, sorry for the late response. Just going through the applications and checking them:

• KTurtle: currently (and all legacy releases) use the category name "KTurtle Script". Can we get that name as an alias to "KTurtle Scripts"?
• Kanagram: works fine
• KHangman: works fine
• Parley: there seems to be an import mix-up:
  • the imported category https://store.kde.org/browse/cat/216/ has the name "Parley Themes" and the alias "KDE Parley Theme" (as far as I can see from the working config file), yet its content are the vocabulary files that should be in category "Parley" (unfortunately an old non-descriptive category name)
  • can you move all the content to the correct category and also import the missing Themes?
• KWordQuiz: I have to take a deeper look, it seems we have a GHNS integration error on our side

Thanks for you work!

This task is an earmark that we have to do research about how to best interact with Android's crash log system from a Qt application. Possible outcomes are

• only use the Android crash system, since KCrash does not give an additional gain, or
• going a combined approach, by providing an additional JNI backend to KCrash, or
• something completely different that we did not think about yet.

Hence, there is no straight forward way, but this is a experimental research task where one has to research an assess the different approaches and come up with a viable concept.

The patch absolutely goes into the right direction. All changes look fine to me. However, I did not test the patch yet, since I am currently in the process of updating my cross-compilation setup.
IMO it is also fine to not provide complete backward compatibility, since adapting is easy and a backward compatibility workaround would loose the sysroot separation that we just introduce with this patch.

The store people will stick to the old urls and category names for compatibility reasons. The KNSRC files shall do the same.

Sorry, I still have questions... Which category names should be used for the API call to api.kde-look.org? The new names seem not to work but the old ones work. Is that correct? And, in case that is correct, how can one figure out the category API name at the store website when it is not the actual shown category name?

OK, that is really weird. I am getting the same problems, too, though it worked some days ago.
I will discuss with the store people which category IDs should eventually be used.
Until I get the answers let's stall this RR.

Yes, category names were change. For "KDE App Template" -> "KDevelop App Templates" there is an automatic redirection of the old name ("KDevelop App Templates" makes much more sense IMO, since the majority of templates is not about KDE). For the other one, I will ask about a redirection from the old singular to the new plural form, to fix GHNS also for older KDevelop versions.

BTW the GHNS download might have work for the time after Dan's patch and before the new KDE Store was announced. Parallel to this patch, in T3877 it was coordinated that the missing template categories were imported back to the store.

@kfunk: yes, this patch should fix that bug. However, that particular bug consisted of many unrelated issues and I can not say if everything will finally work on Windows. However, on Linux I successfully tested that for both Project Templates as well as File Templates (at Configure -> Templates) the templates from the store are shown again. Same holds for "Project -> New From Template -> Get More Templates".
@antonanikin: can you check again if that patch is really applied and installed? If you still do not get elements in the GHNS dialogs, please start KDevelop with 'QT_LOGGING_RULES="org.kde.knewstuff=true" kdevelop' and send me the output.

Thanks, tested and works fine for me.
I will take care that the category names are updated in the KDevelop sources.

Maybe that is a better category name since it is not only about templates for KDE applications.

Thanks that worked. Do I assume correctly that all previous URLs should be api.kde-look.org should be changed to store.kde.org?
Another category I just noticed that is missing is "KDE App Template". Do you want another ticket for this?

I see your point that there is a problem with not the correct fonts to be used in the Webview. But is another font config dialog really required to solve it? E.g. the user already selected (or KTextEditor did it by default) fonts for the editor panes; same for sans serif fonts selected for the UI. Can't such fonts be silently applied to the Webview?

Split error regex

Sorry, arc diff apparently completely screwed the diff... Will close it and add another review :/

Add unit tests for QML filters and unify them

You mean a general rule matching every line that contains a file path? Actually, I am not sure about catching too many false-positives by this approach, e.g. when printing a filepath by a debug statement. Other opinions?

Agreed, just added another RR for the kdevelop repository that should fix the root cause of this problem.

Just noticed that the commit is still "lying around"...
Do I assume correctly that you do not have commit access and we shall commit it for you?
Cheers, Andreas

I figured out that this "fix" is wrong, since there is already code handling an empty backend name string by falling back to the preferred backend.
Will investigate why that code is not triggered for me.

Before the kill the unit test was "tf" with child process gdb as running (R). After the kill the unit test went to zombie (Zl).
After gdb finishes all of its outputs after about 30 sec, the unit test itself finally terminates.

• add check for successful cast
• rebuild the full menu on file name change (this happens seldom enough to do that for the sake of a reduced complexity)

Use KParts version header.

• Make KF5 5.24 requirement optional

ping