Differential D2256

Patch: add bitbake support for syntax highlighting engine
ClosedPublic
Actions

Authored by ikoveshnikov on Jul 22 2016, 9:29 AM.

Details

Reviewers
mwolff
Commits
R39:ccf45aff26a4: Patch: add bitbake support for syntax highlighting engine

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ikoveshnikov updated this revision to Diff 5413.Jul 22 2016, 9:29 AM
ikoveshnikov retitled this revision from to Patch: add bitbake support for syntax highlighting engine.
ikoveshnikov updated this object.
ikoveshnikov edited the test plan for this revision. (Show Details)
ikoveshnikov set the repository for this revision to R39 KTextEditor.
Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptJul 22 2016, 9:29 AM
mwolff added a subscriber: mwolff.Jul 22 2016, 3:15 PM

some minor cleanup hints, otherwise looks good already

src/syntax/data/bitbake.xml
17

not a big deal, but want to mention: the indentation is off

132

you could use AnyChar here

142

unused, can be removed

145

same, this is unused

ikoveshnikov updated this revision to Diff 5456.Jul 23 2016, 10:53 AM

fixed ident
replace DetectChar with AnyChar
removed unused definitions

mwolff accepted this revision.Aug 1 2016, 9:52 AM
mwolff added a reviewer: mwolff.

lgtm

This revision is now accepted and ready to land.Aug 1 2016, 9:52 AM
cordlandwehr added a subscriber: cordlandwehr.Aug 21 2016, 8:36 AM

Just noticed that the commit is still "lying around"...
Do I assume correctly that you do not have commit access and we shall commit it for you?
Cheers, Andreas

ikoveshnikov added a comment.Aug 21 2016, 9:33 AM

Andreas, yes, it seems i will need your help to push this commit to repo.

Closed by commit R39:ccf45aff26a4: Patch: add bitbake support for syntax highlighting engine (authored by ikoveshnikov, committed by cordlandwehr). · Explain WhyAug 21 2016, 12:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMsrc/syntax/data/bitbake.xml (185 lines)

Diff 6115

View Options

src/syntax/data/bitbake.xml

Loading...