Process QML runtime errors
ClosedPublic

Authored by cordlandwehr on Sep 10 2016, 11:34 AM.

Details

Summary

Add error parser for typical QML runtime errors that make the error
outputs clickable. The error filter matches every string that starts
with a filepath, has a row and optionally als a column number.
Also provide unit tests for the most common QML runtime errors.

Test Plan

added unit tests

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr retitled this revision from to Process QML runtime errors.
cordlandwehr updated this object.
cordlandwehr edited the test plan for this revision. (Show Details)
cordlandwehr added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 10 2016, 11:34 AM
kfunk requested changes to this revision.Sep 11 2016, 12:39 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Sorry, I'm not sure I agree to Sven's request.

Now with this approach, any line with a file path + line no. is considered an error in the output view and will be marked red. There can be false positives.

I'd manually add the possible QML error substrings as before + maybe catch sth. like path:line: \w+Error:.* (which matches any error, such as TypeError, ReferenceError, etc.)

This revision now requires changes to proceed.Sep 11 2016, 12:39 AM
cordlandwehr edited edge metadata.

Split error regex

kfunk accepted this revision.Sep 13 2016, 10:00 AM
kfunk edited edge metadata.
This revision is now accepted and ready to land.Sep 13 2016, 10:00 AM
This revision was automatically updated to reflect the committed changes.