Differential D2949

Update GHNS category names
AbandonedPublic
Actions

Authored by cordlandwehr on Oct 5 2016, 7:20 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Summary

Adapt GHNS category names for app template and file template
download and upload integration, which were changed in the recent
update of the KDE Store.

This change aims for branch 5.0

Test Plan

manual testing

Diff Detail

Repository
R33 KDevPlatform
Branch
5.0
Lint
No Linters Available
Unit
No Unit Test Coverage
cordlandwehr updated this revision to Diff 7123.Oct 5 2016, 7:20 PM
cordlandwehr retitled this revision from to Update GHNS category names.
cordlandwehr updated this object.
cordlandwehr edited the test plan for this revision. (Show Details)
cordlandwehr added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 5 2016, 7:20 PM
antonanikin added a subscriber: antonanikin.Oct 6 2016, 9:22 AM

New version don't show any templates available to download. This is normal behavior or an error?

kfunk added a subscriber: kfunk.Oct 6 2016, 9:32 AM

Related to Anton's question: Does this fix https://bugs.kde.org/show_bug.cgi?id=359626?

cordlandwehr added a comment.Oct 6 2016, 6:11 PM

@kfunk: yes, this patch should fix that bug. However, that particular bug consisted of many unrelated issues and I can not say if everything will finally work on Windows. However, on Linux I successfully tested that for both Project Templates as well as File Templates (at Configure -> Templates) the templates from the store are shown again. Same holds for "Project -> New From Template -> Get More Templates".
@antonanikin: can you check again if that patch is really applied and installed? If you still do not get elements in the GHNS dialogs, please start KDevelop with 'QT_LOGGING_RULES="org.kde.knewstuff=true" kdevelop' and send me the output.

cordlandwehr added a comment.Oct 6 2016, 6:13 PM

BTW the GHNS download might have work for the time after Dan's patch and before the new KDE Store was announced. Parallel to this patch, in T3877 it was coordinated that the missing template categories were imported back to the store.

apol added a subscriber: apol.Oct 6 2016, 7:26 PM

That's weird, the category names were changed?

cordlandwehr added a comment.Oct 6 2016, 8:02 PM

Yes, category names were change. For "KDE App Template" -> "KDevelop App Templates" there is an automatic redirection of the old name ("KDevelop App Templates" makes much more sense IMO, since the majority of templates is not about KDE). For the other one, I will ask about a redirection from the old singular to the new plural form, to fix GHNS also for older KDevelop versions.

antonanikin added a comment.Oct 7 2016, 3:13 AM

@antonanikin: can you check again if that patch is really applied and installed? If you still do not get elements in the GHNS dialogs, please start KDevelop with 'QT_LOGGING_RULES="org.kde.knewstuff=true" kdevelop' and send me the output.

@cordlandwehr : I apply your patch with arc patch D2949 and run QT_LOGGING_RULES="org.kde.knewstuff=true" kdevelop.

Grepped output 1:

org.kde.knewstuff: Write registry
org.kde.knewstuff: Initializing KNS3::Engine from ' "kdevfiletemplates.knsrc" '
org.kde.knewstuff: Loading KNewStuff3 config:  "kdevfiletemplates.knsrc"
org.kde.knewstuff: Categories:  ("KDevelop File Templates")
org.kde.knewstuff: Using registry file:  "/home/htower/.local/share/knewstuff3/.knsregistry"
org.kde.knewstuff: Loading KNS2 registry of files for the component:  ""
org.kde.knewstuff: Cache read... entries:  0
org.kde.knewstuff: loading providers from  "http://download.kde.org/ocs/providers.xml"
org.kde.knewstuff: XmlLoader::load(): url:  QUrl("http://download.kde.org/ocs/providers.xml")
org.kde.knewstuff: XmlLoader::slotJobData()
org.kde.knewstuff: XmlLoader::slotJobData()
org.kde.knewstuff: --Xml Loader-START--
org.kde.knewstuff: "<providers>\n    <provider>\n        <id>api.kde-look.org</id>\n        <location>https://api.kde-look.org/ocs/v1/</location>\n        <name>api.kde-look.org</name>\n        <icon>\n        https://api.kde-look.org/theme/flatui/img/new/O-standard-logo.png\n        </icon>\n        <termsofuse>https://api.kde-look.org/content/terms</termsofuse>\n        <register>https://api.kde-look.org/register</register>\n        <services>\n            <person ocsversion=\"1.6\"/>\n            <content ocsversion=\"1.6\"/>\n        </services>\n    </provider>\n</providers>\n"
org.kde.knewstuff: --Xml Loader-END--
org.kde.knewstuff: slotProvidersLoaded
org.kde.knewstuff: Provider attributes:  ""
org.kde.knewstuff: setting provider xml ""
org.kde.knewstuff: Added provider:  "api.kde-look.org"
org.kde.knewstuff: base url of attica provider: "https://api.kde-look.org/ocs/v1/"
org.kde.knewstuff: Engine addProvider called with provider with id  "https://api.kde-look.org/ocs/v1/"
org.kde.knewstuff: loading categories:  ("KDevelop File Templates")
org.kde.knewstuff: Could not find category "KDevelop File Templates"

Grepped output 2:

org.kde.knewstuff: Loading KNewStuff3 config:  "kdevappwizard.knsrc"
org.kde.knewstuff: Categories:  ("KDevelop App Templates")
org.kde.knewstuff: Using registry file:  "/home/htower/.local/share/knewstuff3/.knsregistry"
org.kde.knewstuff: Loading KNS2 registry of files for the component:  ""
org.kde.knewstuff: Cache read... entries:  0
org.kde.knewstuff: loading providers from  "http://download.kde.org/ocs/providers.xml"
org.kde.knewstuff: XmlLoader::load(): url:  QUrl("http://download.kde.org/ocs/providers.xml")
org.kde.knewstuff: XmlLoader::slotJobData()
org.kde.knewstuff: XmlLoader::slotJobData()
org.kde.knewstuff: --Xml Loader-START--
org.kde.knewstuff: "<providers>\n    <provider>\n        <id>api.kde-look.org</id>\n        <location>https://api.kde-look.org/ocs/v1/</location>\n        <name>api.kde-look.org</name>\n        <icon>\n        https://api.kde-look.org/theme/flatui/img/new/O-standard-logo.png\n        </icon>\n        <termsofuse>https://api.kde-look.org/content/terms</termsofuse>\n        <register>https://api.kde-look.org/register</register>\n        <services>\n            <person ocsversion=\"1.6\"/>\n            <content ocsversion=\"1.6\"/>\n        </services>\n    </provider>\n</providers>\n"
org.kde.knewstuff: --Xml Loader-END--
org.kde.knewstuff: slotProvidersLoaded
org.kde.knewstuff: Provider attributes:  ""
org.kde.knewstuff: setting provider xml ""
org.kde.knewstuff: Added provider:  "api.kde-look.org"
org.kde.knewstuff: base url of attica provider: "https://api.kde-look.org/ocs/v1/"
org.kde.knewstuff: Engine addProvider called with provider with id  "https://api.kde-look.org/ocs/v1/"
org.kde.knewstuff: loading categories:  ("KDevelop App Templates")
org.kde.knewstuff: Could not find category "KDevelop App Templates"

Key place here: org.kde.knewstuff: Could not find category "..." - it seems that server doesn't returns new categories at current time. Old code produces normal lists of templates.

cordlandwehr added a comment.Oct 11 2016, 7:21 PM

OK, that is really weird. I am getting the same problems, too, though it worked some days ago.
I will discuss with the store people which category IDs should eventually be used.
Until I get the answers let's stall this RR.

kfunk requested changes to this revision.Oct 11 2016, 8:22 PM
kfunk added a reviewer: kfunk.

Thanks a ton for looking into this, Andreas!

This revision now requires changes to proceed.Oct 11 2016, 8:22 PM
cordlandwehr abandoned this revision.Oct 16 2016, 7:06 PM

The store people will stick to the old urls and category names for compatibility reasons. The KNSRC files shall do the same.

Revision Contents
Changeset List

Diff 7123

View Options

plugins/appwizard/kdevappwizard.knsrc

Loading...
View Options

plugins/filetemplates/kdevfiletemplates.knsrc

Loading...