cordlandwehr (Andreas Cord-Landwehr)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 6 2015, 3:06 PM (214 w, 3 d)
Availability
Available

Recent Activity

Yesterday

cordlandwehr committed R72:bbbcb51bb88b: Adapt tests to changed signals (authored by cordlandwehr).
Adapt tests to changed signals
Sat, Jun 15, 9:58 AM
cordlandwehr committed R72:54d4418fa3c8: Cleanup remaining raw pointers in ICourse interface (authored by cordlandwehr).
Cleanup remaining raw pointers in ICourse interface
Sat, Jun 15, 9:52 AM
cordlandwehr committed R72:02e6f3013757: Fix pointer initializations (authored by cordlandwehr).
Fix pointer initializations
Sat, Jun 15, 8:51 AM
cordlandwehr committed R72:d899b6a6ad00: Fix memory leaks (authored by cordlandwehr).
Fix memory leaks
Sat, Jun 15, 8:51 AM
cordlandwehr committed R72:aec4a8856c95: Fix language object handling in stub (authored by cordlandwehr).
Fix language object handling in stub
Sat, Jun 15, 8:42 AM

Fri, Jun 14

cordlandwehr committed R72:0fadcbc62419: Re-implement parsing of Phonemes (authored by cordlandwehr).
Re-implement parsing of Phonemes
Fri, Jun 14, 8:03 PM
cordlandwehr committed R72:bebdbd89f8be: Add initial phoneme parsing support (authored by cordlandwehr).
Add initial phoneme parsing support
Fri, Jun 14, 8:03 PM
cordlandwehr committed R72:ae7229a60cb4: Port course resources to XML stream parser (authored by cordlandwehr).
Port course resources to XML stream parser
Fri, Jun 14, 8:03 PM
cordlandwehr committed R72:eccd9e1f32d3: Fix double delete in unit test (authored by cordlandwehr).
Fix double delete in unit test
Fri, Jun 14, 8:03 PM
cordlandwehr committed R72:85c3dbc0388f: Switch to smart pointers (authored by cordlandwehr).
Switch to smart pointers
Fri, Jun 14, 8:03 PM

Sun, Jun 9

cordlandwehr committed R72:504e65f92d70: Add missing override (authored by cordlandwehr).
Add missing override
Sun, Jun 9, 1:48 PM
cordlandwehr committed R72:4d1e02825625: Fix memory handling in unit test (authored by cordlandwehr).
Fix memory handling in unit test
Sun, Jun 9, 1:47 PM
cordlandwehr committed R72:a5e45b15fdfa: Port skeleton test to recourses (authored by cordlandwehr).
Port skeleton test to recourses
Sun, Jun 9, 1:47 PM
cordlandwehr committed R72:c1c671130d79: Port scheme tests to resources (authored by cordlandwehr).
Port scheme tests to resources
Sun, Jun 9, 1:37 PM
cordlandwehr committed R72:989d031aac4a: Merge branch 'master' into feature/kirigami-ui (authored by cordlandwehr).
Merge branch 'master' into feature/kirigami-ui
Sun, Jun 9, 1:07 PM
cordlandwehr committed R72:1f8ddf5da7dd: Active skeleton-sync functionality again (authored by cordlandwehr).
Active skeleton-sync functionality again
Sun, Jun 9, 1:07 PM
cordlandwehr committed R72:c1f9027c58c0: Reenable course switching by languages (authored by cordlandwehr).
Reenable course switching by languages
Sun, Jun 9, 1:07 PM
cordlandwehr committed R72:aa81208b5ee6: Fix memory leaks (authored by cordlandwehr).
Fix memory leaks
Sun, Jun 9, 1:07 PM
cordlandwehr committed R72:fdcc05bf9d7f: Explicitly set CppOwnership (authored by cordlandwehr).
Explicitly set CppOwnership
Sun, Jun 9, 1:07 PM
cordlandwehr committed R72:e86af01989d7: Simplify updating of unit in editor session (authored by cordlandwehr).
Simplify updating of unit in editor session
Sun, Jun 9, 8:06 AM
cordlandwehr committed R72:2195eb65e5d2: Use editable course interface for model (authored by cordlandwehr).
Use editable course interface for model
Sun, Jun 9, 8:06 AM
cordlandwehr committed R72:9f5c564401d0: Add sanitizer support (authored by cordlandwehr).
Add sanitizer support
Sun, Jun 9, 8:06 AM
cordlandwehr committed R72:a905b65ed871: Revisit basic switching behavior for skeletons in editor (authored by cordlandwehr).
Revisit basic switching behavior for skeletons in editor
Sun, Jun 9, 8:06 AM

Sat, Jun 8

cordlandwehr committed R72:51b49bf70472: Implement unit tests for editor session (authored by cordlandwehr).
Implement unit tests for editor session
Sat, Jun 8, 10:17 PM
cordlandwehr committed R72:ca0885f7f77b: Introduce editibale course and editable repository interfaces (authored by cordlandwehr).
Introduce editibale course and editable repository interfaces
Sat, Jun 8, 10:17 PM
cordlandwehr committed R72:ff5655d1f78c: Minor cleanup (authored by cordlandwehr).
Minor cleanup
Sat, Jun 8, 10:17 PM
cordlandwehr committed R72:0ecb083b1d4b: Adapt LanguageModel for usage with Repository (authored by cordlandwehr).
Adapt LanguageModel for usage with Repository
Sat, Jun 8, 10:17 PM
cordlandwehr committed R72:dc70ab8addab: Register skeleton resource (authored by cordlandwehr).
Register skeleton resource
Sat, Jun 8, 10:17 PM
cordlandwehr committed R72:b8bb50fe6881: Adapt my mail address (authored by cordlandwehr).
Adapt my mail address
Sat, Jun 8, 1:53 PM
cordlandwehr committed R72:913b94172b3f: Reimplement skeleton serialization (authored by cordlandwehr).
Reimplement skeleton serialization
Sat, Jun 8, 1:53 PM
cordlandwehr committed R72:4384576e4f31: Rename global QML repository object (authored by cordlandwehr).
Rename global QML repository object
Sat, Jun 8, 1:53 PM
cordlandwehr committed R72:b125ba7fd686: Add unit tests for skeleton resource (authored by cordlandwehr).
Add unit tests for skeleton resource
Sat, Jun 8, 1:53 PM
cordlandwehr committed R72:4bcf0648521e: Cleanup includes (authored by cordlandwehr).
Cleanup includes
Sat, Jun 8, 1:53 PM

Sat, May 18

cordlandwehr committed R72:81147434d132: Make ContributorRepository with IRepository API contract (authored by cordlandwehr).
Make ContributorRepository with IRepository API contract
Sat, May 18, 9:12 AM
cordlandwehr committed R72:7f5931530e66: Replace ResourceManager with ContributorRepository (authored by cordlandwehr).
Replace ResourceManager with ContributorRepository
Sat, May 18, 9:12 AM

May 5 2019

cordlandwehr committed R72:7e53c68aedba: Add test data as resource (authored by cordlandwehr).
Add test data as resource
May 5 2019, 11:26 AM
cordlandwehr committed R72:a6e779c198c9: Add missing read calls to property (authored by cordlandwehr).
Add missing read calls to property
May 5 2019, 11:07 AM
cordlandwehr committed R72:21e2f3322233: Unit test for editable course resource (authored by cordlandwehr).
Unit test for editable course resource
May 5 2019, 11:01 AM
cordlandwehr committed R72:498279440c55: Remove deprecated Course class (authored by cordlandwehr).
Remove deprecated Course class
May 5 2019, 11:01 AM

May 4 2019

cordlandwehr committed R72:f7698d7577a1: Introduce EditableCourseResource decorator (authored by cordlandwehr).
Introduce EditableCourseResource decorator
May 4 2019, 12:37 PM
cordlandwehr committed R72:b5c4c692234f: Unit tests for CourseResource (authored by cordlandwehr).
Unit tests for CourseResource
May 4 2019, 12:37 PM

May 3 2019

cordlandwehr committed R72:e0bab5b15a5e: Minor cleanups (authored by cordlandwehr).
Minor cleanups
May 3 2019, 8:11 AM
cordlandwehr committed R72:4e5b50fb8244: Introduce Interface for Repository (authored by cordlandwehr).
Introduce Interface for Repository
May 3 2019, 8:11 AM

Mar 17 2019

cordlandwehr committed R72:c0a63efef13a: Add unit test for training sesssion (authored by cordlandwehr).
Add unit test for training sesssion
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:f95a1176f171: Add empty test container for repository test (authored by cordlandwehr).
Add empty test container for repository test
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:26946fe4e166: Remove outdated resources (authored by cordlandwehr).
Remove outdated resources
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:2657910f9365: Introduce ICourse interface (authored by cordlandwehr).
Introduce ICourse interface
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:fc7420f70c11: Initical QQC2 port for editor (authored by cordlandwehr).
Initical QQC2 port for editor
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:7014ca2f0fc5: Use white background for main pages (authored by cordlandwehr).
Use white background for main pages
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:1099352f1e78: Use default buttons (authored by cordlandwehr).
Use default buttons
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:4c055a67bfb9: Once all the refactoring is donce, this will become version 1.0 :) (authored by cordlandwehr).
Once all the refactoring is donce, this will become version 1.0 :)
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:3eca679e0d5b: Fix usage of audio/x-vorbis encoder (authored by cordlandwehr).
Fix usage of audio/x-vorbis encoder
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:c314b984d5b2: Bump Qt and KF5 dependencies (authored by cordlandwehr).
Bump Qt and KF5 dependencies
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:e8fc8f81bc34: Show default main menu entry (authored by cordlandwehr).
Show default main menu entry
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:f4a64b547017: Do not warn for valid use cases of empty files (authored by cordlandwehr).
Do not warn for valid use cases of empty files
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:046d532d6a4a: Switch from Q_DECL_OVERRIDE to override keyword (authored by cordlandwehr).
Switch from Q_DECL_OVERRIDE to override keyword
Mar 17 2019, 2:45 PM
cordlandwehr committed R72:a812bc062ad7: Modernize connections (authored by cordlandwehr).
Modernize connections
Mar 17 2019, 2:45 PM

Mar 15 2019

cordlandwehr committed R72:011fb2e362b1: Fix static analyzer issues (authored by cordlandwehr).
Fix static analyzer issues
Mar 15 2019, 10:02 AM
cordlandwehr committed R72:4189fe6d0a5e: Clazy fixes (authored by cordlandwehr).
Clazy fixes
Mar 15 2019, 10:02 AM

Mar 14 2019

cordlandwehr committed R72:dee3a9f716c3: Implement interaction between menu highlight and current phrase (authored by cordlandwehr).
Implement interaction between menu highlight and current phrase
Mar 14 2019, 2:20 PM
cordlandwehr committed R72:28481d57ac26: Generate training actions from session (authored by cordlandwehr).
Generate training actions from session
Mar 14 2019, 2:20 PM
cordlandwehr committed R72:5c11d545d709: Fix player status information (authored by cordlandwehr).
Fix player status information
Mar 14 2019, 2:20 PM

Mar 11 2019

cordlandwehr committed R169:d06e7280045d: Add lazy instantiation for submenus (authored by cordlandwehr).
Add lazy instantiation for submenus
Mar 11 2019, 6:29 PM
cordlandwehr closed D19654: Add lazy instantiation for submenus.
Mar 11 2019, 6:29 PM · Kirigami

Mar 10 2019

cordlandwehr committed R72:7dc3527579e0: Revisit training page (authored by cordlandwehr).
Revisit training page
Mar 10 2019, 3:02 PM
cordlandwehr committed R72:b372d703905d: Reactivate lazy loading of course entity (authored by cordlandwehr).
Reactivate lazy loading of course entity
Mar 10 2019, 3:02 PM
cordlandwehr committed R72:4068974cfc32: Merge branch 'master' into feature/kirigami-ui (authored by cordlandwehr).
Merge branch 'master' into feature/kirigami-ui
Mar 10 2019, 3:02 PM
cordlandwehr committed R72:eac69baab4ef: Refactor welcome page and download integration (authored by cordlandwehr).
Refactor welcome page and download integration
Mar 10 2019, 1:24 PM
cordlandwehr added reviewers for D19654: Add lazy instantiation for submenus: apol, mart.
Mar 10 2019, 12:20 PM · Kirigami
cordlandwehr requested review of D19654: Add lazy instantiation for submenus.
Mar 10 2019, 12:18 PM · Kirigami

Feb 9 2019

cordlandwehr committed R72:9cf9339ae487: Remove widget based KNS download (authored by cordlandwehr).
Remove widget based KNS download
Feb 9 2019, 5:13 PM
cordlandwehr committed R72:63921a41a2c1: Wrap all UI strings with i18n (authored by cordlandwehr).
Wrap all UI strings with i18n
Feb 9 2019, 5:13 PM
cordlandwehr committed R72:b74b71ec4936: Modernize QML and add Downloads Page (authored by cordlandwehr).
Modernize QML and add Downloads Page
Feb 9 2019, 5:13 PM
cordlandwehr committed R72:da3c95e4a905: Adapt to internal layout of action icons (authored by cordlandwehr).
Adapt to internal layout of action icons
Feb 9 2019, 5:13 PM

Dec 22 2018

cordlandwehr accepted D12864: Upgrade to ubuntu bionic and Qt 5.12.
Dec 22 2018, 8:03 PM · Android
cordlandwehr added a comment to D12864: Upgrade to ubuntu bionic and Qt 5.12.

@dfaure it's absolutely fine for me to dump this repository and reference kdeorg/android-sdk. The ci-tooling repository looks much more mature and we should not have two competing solutions for an infrastructure task (especially, since the ci-tooling one is actively used and maintained)

Dec 22 2018, 7:31 PM · Android

Nov 25 2018

cordlandwehr closed D17139: Add highlighting file for Wayland Debug Traces.
Nov 25 2018, 2:43 PM · Frameworks, Kate
cordlandwehr committed R216:abb86831466b: Add highlighting file for Wayland Debug Traces (authored by cordlandwehr).
Add highlighting file for Wayland Debug Traces
Nov 25 2018, 2:43 PM

Nov 24 2018

cordlandwehr updated the diff for D17139: Add highlighting file for Wayland Debug Traces.
  • Fix detection of interface names with numbers
  • Fix reference for nomal text itemData
  • Add test data for Wayland trace highlighting
Nov 24 2018, 6:09 PM · Frameworks, Kate
cordlandwehr requested review of D17139: Add highlighting file for Wayland Debug Traces.
Nov 24 2018, 4:10 PM · Frameworks, Kate

Oct 12 2018

cordlandwehr added inline comments to D16156: Keeping the given code document filename consistent..
Oct 12 2018, 5:28 PM · KDE Edu

Oct 7 2018

cordlandwehr committed R73:647461e83841: Add fallback when project could not be loaded (authored by cordlandwehr).
Add fallback when project could not be loaded
Oct 7 2018, 8:37 AM
cordlandwehr added a comment to D15990: Makes the Code Editor Widget tabs closable..

Closing the source file directly leads to deleting the whole code document. IMO that is a too big operation to connect to the small [X] icon, which one could accidentally press, even when switching documents.
Either there should be a confirmation dialog that the source code really shall be deleted. Or there should be a code file deletion option that is only provided in a menu to avoid accidental code deletion.

Oct 7 2018, 8:13 AM · KDE Edu

Oct 3 2018

cordlandwehr accepted D15914: Fix compilation on Windows.
Oct 3 2018, 5:24 PM · Windows, KDE Edu
cordlandwehr added a comment to D15914: Fix compilation on Windows.

Yes, Pino is right, the export headers for the plugins are artifacts from a refactoring, which is not needed anymore.
It would be great if you could remove the export headers for both of the plugins.

Oct 3 2018, 12:02 PM · Windows, KDE Edu

Jul 12 2018

cordlandwehr added a reviewer for D13970: Handle empty preview lists: dhaumann.

Somehow removed all reviewers with my last message (sorry!)
Trying to fix this now.

Jul 12 2018, 4:45 PM · Frameworks
cordlandwehr committed R304:c4275aaf79fc: Handle empty preview lists (authored by cordlandwehr).
Handle empty preview lists
Jul 12 2018, 4:43 PM
cordlandwehr closed D13970: Handle empty preview lists.
Jul 12 2018, 4:43 PM · Frameworks

Jul 8 2018

D13970: Handle empty preview lists now requires review to proceed.

I had a crash at the respective locations while porting Artikulate to the QtQuick based API, since those KNS resource files do not provide previews.
However, IMO this patch fixes an unsafe access to a list element without checking that it exists.

Jul 8 2018, 8:32 PM · Frameworks
cordlandwehr requested review of D13970: Handle empty preview lists.
Jul 8 2018, 4:29 PM · Frameworks

Jun 25 2018

cordlandwehr committed R169:27fb2591c54b: Handle enabled property of simple models (authored by cordlandwehr).
Handle enabled property of simple models
Jun 25 2018, 6:26 PM
cordlandwehr committed R72:57328cea4c53: Remove language goal selector page (authored by cordlandwehr).
Remove language goal selector page
Jun 25 2018, 6:13 PM
cordlandwehr committed R72:4f542b137c01: Initial port to use Kirigam menu for training actions (authored by cordlandwehr).
Initial port to use Kirigam menu for training actions
Jun 25 2018, 6:13 PM
cordlandwehr committed R72:c0cef4f1a0c7: Split main menu actions into training and config part (authored by cordlandwehr).
Split main menu actions into training and config part
Jun 25 2018, 6:13 PM
cordlandwehr committed R72:ef248c5a5307: Enforce drawer to be open (authored by cordlandwehr).
Enforce drawer to be open
Jun 25 2018, 6:13 PM
cordlandwehr committed R72:eddbb1b9c31d: Rename sections (authored by cordlandwehr).
Rename sections
Jun 25 2018, 6:13 PM
cordlandwehr committed R72:b28791466406: Remove unused header (authored by cordlandwehr).
Remove unused header
Jun 25 2018, 6:13 PM
cordlandwehr closed D13696: Handle enabled property of simple models.
Jun 25 2018, 6:09 PM · Kirigami

Jun 24 2018

cordlandwehr updated the diff for D13696: Handle enabled property of simple models.

Fixed logical error

Jun 24 2018, 6:36 AM · Kirigami

Jun 23 2018

cordlandwehr requested review of D13696: Handle enabled property of simple models.
Jun 23 2018, 11:06 AM · Kirigami