cordlandwehr (Andreas Cord-Landwehr)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 6 2015, 3:06 PM (251 w, 2 d)
Availability
Available

Recent Activity

Wed, Feb 26

cordlandwehr updated the test plan for D27683: Initial version for SPDX header detection.
Wed, Feb 26, 6:18 PM
cordlandwehr requested review of D27683: Initial version for SPDX header detection.
Wed, Feb 26, 6:17 PM
cordlandwehr committed R169:cd124d4251f6: Move checked menu item always into range (authored by cordlandwehr).
Move checked menu item always into range
Wed, Feb 26, 6:08 PM
cordlandwehr closed D27435: Move checked menu item always into range.
Wed, Feb 26, 6:08 PM · Kirigami
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Wed, Feb 26, 5:46 PM · KF6
cordlandwehr committed R169:8d09d66f5fd3: Kirigami: Convert license headers to SPDX markers (authored by cordlandwehr).
Kirigami: Convert license headers to SPDX markers
Wed, Feb 26, 5:46 PM
cordlandwehr closed D27364: Kirigami: Convert license headers to SPDX markers.
Wed, Feb 26, 5:46 PM · Kirigami
cordlandwehr added a comment to D27364: Kirigami: Convert license headers to SPDX markers.

@mart the main argument chain here is: we need machine readable license identifiers to enable tooling -> SPDX markers are the way to go -> having both license statements and SPDX markers in the same file will ultimately lead to ambiguous licenses, since people will forget updating always both -> thus only use the SPDX markers
for making those markers easier to understand, there probably will be (in the near future) a generic licensing readme file (possibly as a replacement for the COPYING & COPYING.LIB files) that explains to the license users the meaning of the SPDX markers and where they can find the full license texts inside the repository; though, such a explanatory file is not yet in draft and thus have to be added in a later commit.

Wed, Feb 26, 5:43 PM · Kirigami
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Wed, Feb 26, 5:36 PM · KF6
cordlandwehr committed R175:1bc908a8cfea: KHolidays: Convert license statements to SPDX expressions (authored by cordlandwehr).
KHolidays: Convert license statements to SPDX expressions
Wed, Feb 26, 5:36 PM
cordlandwehr closed D27363: KHolidays: Convert license statements to SPDX expressions.
Wed, Feb 26, 5:36 PM · Frameworks
cordlandwehr moved T12598: Introduce Commit Tooling to Check for SPDX Headers from Backlog to In Progress on the KF6 board.
Wed, Feb 26, 5:35 PM · KF6
cordlandwehr claimed T12598: Introduce Commit Tooling to Check for SPDX Headers.

Commit hooks are located here: https://cgit.kde.org/repo-management.git/tree/hooks/hooklib.py#n908

Wed, Feb 26, 5:34 PM · KF6

Tue, Feb 25

cordlandwehr updated the diff for D27601: KConfig: Convert to SPDX license statements.

Better handling of explenatory texts

Tue, Feb 25, 6:01 PM · Frameworks
cordlandwehr added inline comments to D27601: KConfig: Convert to SPDX license statements.
Tue, Feb 25, 6:00 PM · Frameworks
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Tue, Feb 25, 5:51 PM · KF6
cordlandwehr committed R271:a222808f86cd: KDbusAddons: Convert license statement to SPDX (authored by cordlandwehr).
KDbusAddons: Convert license statement to SPDX
Tue, Feb 25, 5:51 PM
cordlandwehr closed D27602: KDbusAddons: Convert license statement to SPDX.
Tue, Feb 25, 5:51 PM · Frameworks
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Tue, Feb 25, 5:50 PM · KF6
cordlandwehr committed R272:563fc1416d90: KDNSSD: Convert license headers to SPDX statements (authored by cordlandwehr).
KDNSSD: Convert license headers to SPDX statements
Tue, Feb 25, 5:49 PM
cordlandwehr closed D27603: KDNSSD: Convert license headers to SPDX statements.
Tue, Feb 25, 5:49 PM · Frameworks
cordlandwehr accepted D27586: templates: Convert license statements to SPDX headers.
Tue, Feb 25, 5:49 PM · Frameworks

Sun, Feb 23

cordlandwehr updated the task description for T11550: Add SPDX License markers.
Sun, Feb 23, 3:44 PM · KF6
cordlandwehr added a task to D27603: KDNSSD: Convert license headers to SPDX statements: T11550: Add SPDX License markers.
Sun, Feb 23, 3:44 PM · Frameworks
cordlandwehr added a revision to T11550: Add SPDX License markers: D27603: KDNSSD: Convert license headers to SPDX statements.
Sun, Feb 23, 3:44 PM · KF6
cordlandwehr requested review of D27603: KDNSSD: Convert license headers to SPDX statements.
Sun, Feb 23, 3:44 PM · Frameworks
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Sun, Feb 23, 3:25 PM · KF6
cordlandwehr added a revision to T11550: Add SPDX License markers: D27602: KDbusAddons: Convert license statement to SPDX.
Sun, Feb 23, 3:25 PM · KF6
cordlandwehr added a task to D27602: KDbusAddons: Convert license statement to SPDX: T11550: Add SPDX License markers.
Sun, Feb 23, 3:25 PM · Frameworks
cordlandwehr requested review of D27602: KDbusAddons: Convert license statement to SPDX.
Sun, Feb 23, 3:24 PM · Frameworks
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Sun, Feb 23, 3:04 PM · KF6
cordlandwehr added a task to D27601: KConfig: Convert to SPDX license statements: T11550: Add SPDX License markers.
Sun, Feb 23, 3:03 PM · Frameworks
cordlandwehr added a revision to T11550: Add SPDX License markers: D27601: KConfig: Convert to SPDX license statements.
Sun, Feb 23, 3:03 PM · KF6
cordlandwehr requested review of D27601: KConfig: Convert to SPDX license statements.
Sun, Feb 23, 3:03 PM · Frameworks
cordlandwehr requested changes to D27586: templates: Convert license statements to SPDX headers.
Sun, Feb 23, 1:40 PM · Frameworks
cordlandwehr accepted D27587: templates: Convert license statements to SPDX headers.

LGTM

Sun, Feb 23, 1:36 PM · Frameworks, Kate
cordlandwehr retitled D27571: KDAV: Convert license headers to SPDX identifiers from Convert license headers to SPDX identifiers to KDAV: Convert license headers to SPDX identifiers.
Sun, Feb 23, 9:30 AM · KDE PIM
cordlandwehr accepted D27588: templates: Convert license statements to SPDX headers.
Sun, Feb 23, 9:27 AM · Frameworks
cordlandwehr accepted D27585: Support code in project templates with KAppTemplate variables for copyright.

Thanks!

Sun, Feb 23, 7:35 AM

Sat, Feb 22

cordlandwehr added a revision to T11550: Add SPDX License markers: D27571: KDAV: Convert license headers to SPDX identifiers.
Sat, Feb 22, 12:36 PM · KF6
cordlandwehr added a task to D27571: KDAV: Convert license headers to SPDX identifiers: T11550: Add SPDX License markers.
Sat, Feb 22, 12:36 PM · KDE PIM
cordlandwehr requested review of D27571: KDAV: Convert license headers to SPDX identifiers.
Sat, Feb 22, 12:35 PM · KDE PIM
cordlandwehr added a comment to D27363: KHolidays: Convert license statements to SPDX expressions.

Did additional code digging in the Plan repository and I think that all stated copyright claims are valid.

Sat, Feb 22, 11:13 AM · Frameworks
cordlandwehr updated the diff for D27363: KHolidays: Convert license statements to SPDX expressions.

Add missing SPDX identifier

Sat, Feb 22, 10:09 AM · Frameworks
cordlandwehr added a comment to D27243: KQuickCharts: Convert license headers to SPDX statements.

Since the review is open for 2 weeks, this is a gentle poke if somebody could review it.

Sat, Feb 22, 10:06 AM
cordlandwehr accepted D27553: templates: Convert license statements to SPDX headers.

Thanks for working on this! Looks all good to me.
Regarding the conversion of placeholders, that can easily be done in licensedigger, it's just a simple regular expression there.

Sat, Feb 22, 9:39 AM
cordlandwehr added a subtask for T12528: SPDX Licenses: T12730: Rework COPYING and COPYING.LIB files.
Sat, Feb 22, 9:33 AM · KF6
cordlandwehr added a parent task for T12730: Rework COPYING and COPYING.LIB files: T12528: SPDX Licenses.
Sat, Feb 22, 9:33 AM · KF6
cordlandwehr created T12730: Rework COPYING and COPYING.LIB files.
Sat, Feb 22, 9:33 AM · KF6
cordlandwehr added a comment to D27245: Ki18n: Convert license headers to SPDX statements.

What about the COPYING.LIB file (containing LGLP 2.1 text) in the root directory? Could that not be removed given the new copy LICENSES/LGPL-2.1-only.txt?
Or are both copies required? If so, why? Similar question also for any other repo.

Sat, Feb 22, 9:31 AM · Frameworks

Sun, Feb 16

cordlandwehr committed R72:f88d44e16b3e: Close unit when it is finished (authored by cordlandwehr).
Close unit when it is finished
Sun, Feb 16, 5:08 PM
cordlandwehr committed R72:87131b41a379: Adapt to 2020 (authored by cordlandwehr).
Adapt to 2020
Sun, Feb 16, 5:08 PM
cordlandwehr committed R72:e00e26a664a1: Use non-depreacted background color properties (authored by cordlandwehr).
Use non-depreacted background color properties
Sun, Feb 16, 4:23 PM
cordlandwehr committed R72:903cb193caed: Cleanup Includes (authored by cordlandwehr).
Cleanup Includes
Sun, Feb 16, 4:23 PM
cordlandwehr committed R72:74b55243de2d: Create on stack and avoid leak (authored by cordlandwehr).
Create on stack and avoid leak
Sun, Feb 16, 4:23 PM
cordlandwehr committed R72:d6f2f86c3d4a: Fix binding loop (authored by cordlandwehr).
Fix binding loop
Sun, Feb 16, 4:23 PM
cordlandwehr committed R72:3927d343e8de: Cleanup artifacts from QWidget integration (authored by cordlandwehr).
Cleanup artifacts from QWidget integration
Sun, Feb 16, 4:23 PM
cordlandwehr committed R72:05d780b63737: Add missing parent property (authored by cordlandwehr).
Add missing parent property
Sun, Feb 16, 4:23 PM
cordlandwehr committed R72:83e102a84d9f: Add tooltips for shortcuts (authored by cordlandwehr).
Add tooltips for shortcuts
Sun, Feb 16, 4:23 PM
cordlandwehr requested review of D27435: Move checked menu item always into range.
Sun, Feb 16, 4:13 PM · Kirigami
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Sun, Feb 16, 8:25 AM · KF6
cordlandwehr added a revision to T11550: Add SPDX License markers: D27429: ThreadWeaver: Convert license headers to SPDX expressions.
Sun, Feb 16, 8:24 AM · KF6
cordlandwehr added a task to D27429: ThreadWeaver: Convert license headers to SPDX expressions: T11550: Add SPDX License markers.
Sun, Feb 16, 8:24 AM · Frameworks
cordlandwehr requested review of D27429: ThreadWeaver: Convert license headers to SPDX expressions.
Sun, Feb 16, 8:24 AM · Frameworks
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Sun, Feb 16, 7:22 AM · KF6
cordlandwehr added a revision to T11550: Add SPDX License markers: D27428: KItemViews: Convert license statements to SPDX expressions.
Sun, Feb 16, 7:22 AM · KF6
cordlandwehr added a task to D27428: KItemViews: Convert license statements to SPDX expressions: T11550: Add SPDX License markers.
Sun, Feb 16, 7:22 AM · Frameworks
cordlandwehr requested review of D27428: KItemViews: Convert license statements to SPDX expressions.
Sun, Feb 16, 7:21 AM · Frameworks

Sat, Feb 15

cordlandwehr updated the diff for D27363: KHolidays: Convert license statements to SPDX expressions.

Make snippet copyright statement more verbose

Sat, Feb 15, 9:55 AM · Frameworks
cordlandwehr added a comment to D27363: KHolidays: Convert license statements to SPDX expressions.

Updated several statements, but still need clarification if named people are copyright holders or contributors without copyright claim.

Sat, Feb 15, 9:54 AM · Frameworks
cordlandwehr updated the diff for D27363: KHolidays: Convert license statements to SPDX expressions.

Clarified several statements

Sat, Feb 15, 9:49 AM · Frameworks
cordlandwehr committed R172:484762a5151b: KCalendarCore: Convert license statements to SPDX markers (authored by cordlandwehr).
KCalendarCore: Convert license statements to SPDX markers
Sat, Feb 15, 9:12 AM
cordlandwehr closed D27361: KCalendarCore: Convert license statements to SPDX markers.
Sat, Feb 15, 9:12 AM · KDE PIM
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Sat, Feb 15, 8:47 AM · KF6

Thu, Feb 13

cordlandwehr updated the diff for D27361: KCalendarCore: Convert license statements to SPDX markers.

Fix typo

Thu, Feb 13, 4:56 PM · KDE PIM
cordlandwehr added a comment to D27245: Ki18n: Convert license headers to SPDX statements.

Link to issue on reuse-tool tracker regarding empty lines in LGPL-3.0-only license text: https://github.com/fsfe/reuse-tool/issues/178

Thu, Feb 13, 12:14 PM · Frameworks
cordlandwehr added inline comments to D27245: Ki18n: Convert license headers to SPDX statements.
Thu, Feb 13, 12:09 PM · Frameworks
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Thu, Feb 13, 12:03 PM · KF6
cordlandwehr added a revision to T11550: Add SPDX License markers: D27364: Kirigami: Convert license headers to SPDX markers.
Thu, Feb 13, 12:02 PM · KF6
cordlandwehr added a task to D27364: Kirigami: Convert license headers to SPDX markers: T11550: Add SPDX License markers.
Thu, Feb 13, 12:02 PM · Kirigami
cordlandwehr requested review of D27364: Kirigami: Convert license headers to SPDX markers.
Thu, Feb 13, 12:02 PM · Kirigami
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Thu, Feb 13, 11:32 AM · KF6
cordlandwehr added a task to D27363: KHolidays: Convert license statements to SPDX expressions: T11550: Add SPDX License markers.
Thu, Feb 13, 11:32 AM · Frameworks
cordlandwehr added a revision to T11550: Add SPDX License markers: D27363: KHolidays: Convert license statements to SPDX expressions.
Thu, Feb 13, 11:32 AM · KF6
cordlandwehr requested review of D27363: KHolidays: Convert license statements to SPDX expressions.
Thu, Feb 13, 11:32 AM · Frameworks
cordlandwehr updated the diff for D27245: Ki18n: Convert license headers to SPDX statements.

Remove unneeded whitespace

Thu, Feb 13, 11:08 AM · Frameworks
cordlandwehr updated the diff for D27245: Ki18n: Convert license headers to SPDX statements.

Unify license comment header style

Thu, Feb 13, 11:07 AM · Frameworks
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Thu, Feb 13, 11:03 AM · KF6
cordlandwehr added a revision to T11550: Add SPDX License markers: D27361: KCalendarCore: Convert license statements to SPDX markers.
Thu, Feb 13, 11:03 AM · KF6
cordlandwehr added a task to D27361: KCalendarCore: Convert license statements to SPDX markers: T11550: Add SPDX License markers.
Thu, Feb 13, 11:03 AM · KDE PIM
cordlandwehr requested review of D27361: KCalendarCore: Convert license statements to SPDX markers.
Thu, Feb 13, 11:03 AM · KDE PIM
cordlandwehr added inline comments to D27245: Ki18n: Convert license headers to SPDX statements.
Thu, Feb 13, 11:01 AM · Frameworks
cordlandwehr updated the task description for T11550: Add SPDX License markers.
Thu, Feb 13, 10:35 AM · KF6
cordlandwehr committed R275:be32ab6c49f9: KItemModels: Convert license headers to SPDX markers (authored by cordlandwehr).
KItemModels: Convert license headers to SPDX markers
Thu, Feb 13, 10:35 AM
cordlandwehr closed D27103: KItemModels: Convert license headers to SPDX markers.
Thu, Feb 13, 10:35 AM · Frameworks
cordlandwehr updated the diff for D27103: KItemModels: Convert license headers to SPDX markers.

Remove unneeded whitespace

Thu, Feb 13, 10:35 AM · Frameworks
cordlandwehr committed R235:4db348a7bb1c: Attica: Convert license statements to SPDX markers (authored by cordlandwehr).
Attica: Convert license statements to SPDX markers
Thu, Feb 13, 10:31 AM
cordlandwehr closed D27106: Attica: Convert license statements to SPDX markers.
Thu, Feb 13, 10:31 AM · Frameworks
cordlandwehr updated the diff for D27103: KItemModels: Convert license headers to SPDX markers.

Incorporate review findings

Thu, Feb 13, 8:43 AM · Frameworks
cordlandwehr updated the diff for D27106: Attica: Convert license statements to SPDX markers.

Solve review findings

Thu, Feb 13, 8:10 AM · Frameworks