Use folder prefix is filename is not unique

Authored by cordlandwehr on Jun 18 2016, 12:08 PM.



If several files have the same filename in the open document menu,
prefix such with their containing folder name. This changes e.g.

  • CMakeLists.txt
  • CMakeLists.txt


  • foo/CMakeLists.txt
  • baa/CMakeLists.txt
Test Plan

Manual testing

Diff Detail

R33 KDevPlatform
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr retitled this revision from to Use folder prefix is filename is not unique.
cordlandwehr updated this object.
cordlandwehr edited the test plan for this revision. (Show Details)
cordlandwehr added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 18 2016, 12:08 PM
brauch added a subscriber: brauch.Jul 3 2016, 3:21 PM

rest looks good to me, thanks :)


add a null check here


But what it if it really changed, e.g. "save as", does that work?

kfunk requested changes to this revision.Jul 13 2016, 9:55 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

See Sven's comments

This revision now requires changes to proceed.Jul 13 2016, 9:55 AM
cordlandwehr edited edge metadata.
cordlandwehr removed R33 KDevPlatform as the repository for this revision.
  • add check for successful cast
  • rebuild the full menu on file name change (this happens seldom enough to do that for the sake of a reduced complexity)
apol accepted this revision.Aug 24 2016, 2:07 AM
apol added a reviewer: apol.
apol added a subscriber: apol.

Let's get this in master, change looks good and useful.

This revision was automatically updated to reflect the committed changes.