Feed Advanced Search

Oct 27 2018

mkoller accepted D16371: Port KolourPaint away from deprecated KIntNumInput and KDoubleNumInput.

Yes, this is a good approach.

Oct 27 2018, 3:00 PM

Oct 20 2018

mkoller added a comment to D15316: Port KolourPaint away from deprecated KDoubleNumInput.

I suggest you create ONE new widget which contains a slider and a spinbox, and you pass the range it shall use.
Now it's very confusing.

Oct 20 2018, 4:09 PM · KDE Applications
mkoller requested changes to D15316: Port KolourPaint away from deprecated KDoubleNumInput.

other than ma comments, I'm ok with it.

Oct 20 2018, 2:59 PM · KDE Applications

Oct 19 2018

mkoller committed R887:60d6203d1a75: fix build with older Qt version (authored by mkoller).
fix build with older Qt version
Oct 19 2018, 9:11 PM
mkoller committed R887:e92e0aec6f54: bump version (authored by mkoller).
bump version
Oct 19 2018, 7:05 PM

Oct 16 2018

mkoller committed R887:01ebd2dd0fd7: Allow to disable icons on the pager buttons via config file (authored by mkoller).
Allow to disable icons on the pager buttons via config file
Oct 16 2018, 5:27 PM
mkoller committed R887:72251c070130: Fix key name for config (authored by mkoller).
Fix key name for config
Oct 16 2018, 5:27 PM
mkoller committed R887:bea1639c101a: Allow SoftwareUpdates to be disabled with the config file (authored by mkoller).
Allow SoftwareUpdates to be disabled with the config file
Oct 16 2018, 5:13 PM
mkoller committed R887:af7d6032be42: Add "Run Command" to desktop context menu (authored by mkoller).
Add "Run Command" to desktop context menu
Oct 16 2018, 5:13 PM
mkoller committed R887:384f0e111cbd: if the system does not have NM running, hide the network icon (authored by mkoller).
if the system does not have NM running, hide the network icon
Oct 16 2018, 4:39 PM
mkoller committed R887:31aac54124e9: desaturate icons on pager buttons to better see button text (authored by mkoller).
desaturate icons on pager buttons to better see button text
Oct 16 2018, 4:39 PM

Oct 13 2018

mkoller committed R887:8d50e81a020f: bump version (authored by mkoller).
bump version
Oct 13 2018, 8:45 PM
mkoller committed R887:131a3f880cdb: fix taskbar calculation of max columns (e.g. 7 windows with 3 rows -> 3 cols) (authored by mkoller).
fix taskbar calculation of max columns (e.g. 7 windows with 3 rows -> 3 cols)
Oct 13 2018, 8:45 PM

Oct 8 2018

mkoller added a comment to D15859: allow non-local file:// redirect to a M$-WebDav URL.

I was talking about the code I changed, which uses QUrl, which can not parse the @SSL syntax.
I tried.

Oct 8 2018, 6:41 AM · Frameworks

Oct 7 2018

mkoller committed R241:1c7b47cb677b: allow non-local file:// redirect to a Windows WebDav URL (authored by mkoller).
allow non-local file:// redirect to a Windows WebDav URL
Oct 7 2018, 6:23 PM
mkoller closed D15859: allow non-local file:// redirect to a M$-WebDav URL.
Oct 7 2018, 6:23 PM · Frameworks
mkoller added a comment to D15859: allow non-local file:// redirect to a M$-WebDav URL.

file://some.server:80/DavWWWRoot/pwa/some/path/to/a/document clearly works since it's standard URL syntax.
file://some.server@80/DavWWWRoot/pwa/some/path/to/a/document does not, since it's not a valid URL syntax.

Oct 7 2018, 6:20 PM · Frameworks

Oct 6 2018

mkoller added a comment to D15859: allow non-local file:// redirect to a M$-WebDav URL.

ping

Oct 6 2018, 10:17 AM · Frameworks

Oct 1 2018

mkoller committed R887:8f0754baed2f: make PackageKit integration optional (authored by mkoller).
make PackageKit integration optional
Oct 1 2018, 7:28 PM
mkoller committed R887:2db62b2e6051: Show pending mount/unmount operation with blinking mount button (authored by mkoller).
Show pending mount/unmount operation with blinking mount button
Oct 1 2018, 7:28 PM

Sep 30 2018

mkoller updated the diff for D15859: allow non-local file:// redirect to a M$-WebDav URL.

About SSL: I have no idea how an SSL url from a sharepoint server would look like, since it seems the setup we use does not use ssl.
The mentioned webdavsystem.com link just describes how it would look like as a win-UNC path, but since I receive urls in mail which are not in the unc syntax, I'm not sure if they will contain this @ssl token or not

Sep 30 2018, 8:56 PM · Frameworks
mkoller requested review of D15859: allow non-local file:// redirect to a M$-WebDav URL.
Sep 30 2018, 3:21 PM · Frameworks

Sep 24 2018

mkoller committed R887:5f2de546985e: ensure clock updates each second when seconds shall be shown (authored by mkoller).
ensure clock updates each second when seconds shall be shown
Sep 24 2018, 4:19 AM

Sep 9 2018

mkoller committed R887:a1063a17cb16: add mem-buffers as cached mem to not show it as used application mem (authored by mkoller).
add mem-buffers as cached mem to not show it as used application mem
Sep 9 2018, 8:47 PM
mkoller committed R34:d0c59d84a433: ensure "make install" on windows also installs development header files (authored by mkoller).
ensure "make install" on windows also installs development header files
Sep 9 2018, 3:27 PM
mkoller closed D15182: ensure "make install" on windows also installs development header files.
Sep 9 2018, 3:27 PM · KDE Edu, Marble

Sep 8 2018

mkoller committed R887:4be5d976f090: check network connections on yet another signal - vpn did not change (authored by mkoller).
check network connections on yet another signal - vpn did not change
Sep 8 2018, 4:17 PM
mkoller committed R887:b1a4615725e6: allow the close button to reach to the right screen border - easier to click (authored by mkoller).
allow the close button to reach to the right screen border - easier to click
Sep 8 2018, 4:17 PM

Aug 31 2018

mkoller added a comment to D15182: ensure "make install" on windows also installs development header files.

Have you tested creating a new deployable Windows package?

Aug 31 2018, 3:47 PM · KDE Edu, Marble
mkoller requested review of D15182: ensure "make install" on windows also installs development header files.
Aug 31 2018, 10:56 AM · KDE Edu, Marble

Aug 29 2018

mkoller committed R34:06b978062fff: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop (authored by mkoller).
Avoid "QObject::disconnect: Unexpected null parameter" error on application stop
Aug 29 2018, 8:09 AM
mkoller closed D14098: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop.
Aug 29 2018, 8:09 AM · KDE Edu, Marble
mkoller added a comment to D14098: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop.

ping

Aug 29 2018, 6:42 AM · KDE Edu, Marble

Aug 24 2018

mkoller committed R320:ec52131e5b0f: tabs -> blanks (authored by mkoller).
tabs -> blanks
Aug 24 2018, 4:25 PM
mkoller committed R320:ed61332527de: conditionally use KF5 5.48 UDSEntry::fastInsert() (authored by mkoller).
conditionally use KF5 5.48 UDSEntry::fastInsert()
Aug 24 2018, 4:15 PM
mkoller committed R320:ee10c11bb4f5: Fwd port: Small macro fixes and code cleanup (authored by mkoller).
Fwd port: Small macro fixes and code cleanup
Aug 24 2018, 4:15 PM
mkoller committed R320:0d4afc563233: Fwd port: Do not insert a break before the very first Nm in section SYNOPSIS (authored by mkoller).
Fwd port: Do not insert a break before the very first Nm in section SYNOPSIS
Aug 24 2018, 4:14 PM
mkoller committed R320:2452d5b5ddce: Fwd port: Fix closing bracket output position and linebreak in SYNOPSIS section (authored by mkoller).
Fwd port: Fix closing bracket output position and linebreak in SYNOPSIS section
Aug 24 2018, 4:14 PM
mkoller committed R320:30fffd61ae86: Fwd port: Adding .St macro from groff_mdoc package (Standards Names) (authored by mkoller).
Fwd port: Adding .St macro from groff_mdoc package (Standards Names)
Aug 24 2018, 4:14 PM
mkoller committed R320:1c45ddbe94c3: Fwd port: Do not use KEncodingProber - it gives false results (authored by mkoller).
Fwd port: Do not use KEncodingProber - it gives false results
Aug 24 2018, 4:14 PM
mkoller committed R320:87d8ab437114: Fwd port: Do not output arguments from expression while evaluating them (authored by mkoller).
Fwd port: Do not output arguments from expression while evaluating them
Aug 24 2018, 4:14 PM

Aug 10 2018

mkoller committed R887:911f50123d18: bump (authored by mkoller).
bump
Aug 10 2018, 7:42 PM
mkoller committed R887:bed29c23d54f: New desktop applet: PictureFrame (authored by mkoller).
New desktop applet: PictureFrame
Aug 10 2018, 7:35 PM

Aug 7 2018

mkoller committed R887:f4ec5312ceac: add missing include (authored by mkoller).
add missing include
Aug 7 2018, 2:10 PM
mkoller committed R887:c4ebc1934c99: make 1.1 release for OBS (authored by mkoller).
make 1.1 release for OBS
Aug 7 2018, 2:03 PM
mkoller added a comment to D14585: avoid crash in MonitorPrivate::emitItemsNotification accessing empty list.

This is what I get (without my patch) when hitting "check for mails" in kmail:

Aug 7 2018, 1:45 PM · KDE PIM

Aug 6 2018

mkoller committed R887:0be9afa4da26: add license header (authored by mkoller).
add license header
Aug 6 2018, 4:28 PM
mkoller committed R887:88a9fcca9692: IconButton class to ensure positioning of icon and text is independent of the… (authored by mkoller).
IconButton class to ensure positioning of icon and text is independent of the…
Aug 6 2018, 3:34 PM
mkoller committed R887:adeed668b100: Create multiple columns in AppMenu popup when desktop height is reached (authored by mkoller).
Create multiple columns in AppMenu popup when desktop height is reached
Aug 6 2018, 2:19 PM
mkoller committed R887:14571c871fbb: fix desktop filename (authored by mkoller).
fix desktop filename
Aug 6 2018, 12:36 PM

Aug 3 2018

mkoller added a comment to D14585: avoid crash in MonitorPrivate::emitItemsNotification accessing empty list.

I also reported this problem before at https://bugs.kde.org/show_bug.cgi?id=397131

Aug 3 2018, 6:20 PM · KDE PIM
mkoller requested review of D14585: avoid crash in MonitorPrivate::emitItemsNotification accessing empty list.
Aug 3 2018, 6:19 PM · KDE PIM

Jul 29 2018

mkoller committed R887:4e4f9132a2f7: avoid focus stealing (authored by mkoller).
avoid focus stealing
Jul 29 2018, 7:54 PM
mkoller committed R887:5bd0ca1e15bf: Avoid "needs charge" info when it's already charging (authored by mkoller).
Avoid "needs charge" info when it's already charging
Jul 29 2018, 7:54 PM
mkoller committed R887:53bd3e21551f: reduce device list popup timeout (authored by mkoller).
reduce device list popup timeout
Jul 29 2018, 7:54 PM
mkoller committed R978:c9739506bbb3: Add info about xz compression (authored by mkoller).
Add info about xz compression
Jul 29 2018, 7:51 PM
mkoller committed R978:5f9ff2a24dfa: Compress with xz instead of bzip2 when available (authored by mkoller).
Compress with xz instead of bzip2 when available
Jul 29 2018, 7:51 PM

Jul 25 2018

mkoller committed R94:1331813fe658: avoid crash by initializing pointer (authored by mkoller).
avoid crash by initializing pointer
Jul 25 2018, 7:17 AM
mkoller closed D14348: avoid crash by initializing pointer.
Jul 25 2018, 7:17 AM · KDE PIM
mkoller requested review of D14348: avoid crash by initializing pointer.
Jul 25 2018, 6:17 AM · KDE PIM

Jul 23 2018

mkoller added reviewers for D14098: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop: sanjibanb, rahn.
Jul 23 2018, 8:02 PM · KDE Edu, Marble

Jul 13 2018

mkoller requested review of D14098: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop.
Jul 13 2018, 12:48 PM · KDE Edu, Marble

Jul 12 2018

mkoller committed R34:c4850695c31d: avoid runtime error about unknown signal when compiled without WebKit (authored by mkoller).
avoid runtime error about unknown signal when compiled without WebKit
Jul 12 2018, 6:36 AM
mkoller committed R34:59b95f5544bd: No version number for the libs on Android (authored by mkoller).
No version number for the libs on Android
Jul 12 2018, 6:36 AM
mkoller closed D14053: avoid runtime error about unknown signal when compiled without WebKit.
Jul 12 2018, 6:36 AM · KDE Edu, Marble
mkoller closed D14054: No version number for the libs on Android.
Jul 12 2018, 6:36 AM · KDE Edu, Marble

Jul 11 2018

mkoller requested review of D14054: No version number for the libs on Android.
Jul 11 2018, 5:24 PM · KDE Edu, Marble
mkoller requested review of D14053: avoid runtime error about unknown signal when compiled without WebKit.
Jul 11 2018, 5:16 PM · KDE Edu, Marble

Jun 21 2018

mkoller committed R34:f4ac4643827c: stop InertialEarthRotation when a new coordinate is set or keyboard interaction (authored by mkoller).
stop InertialEarthRotation when a new coordinate is set or keyboard interaction
Jun 21 2018, 4:36 PM
mkoller closed D13640: stop InertialEarthRotation when a new coordinate is set or keyboard interaction.
Jun 21 2018, 4:36 PM · KDE Edu, Marble

Jun 20 2018

mkoller requested review of D13640: stop InertialEarthRotation when a new coordinate is set or keyboard interaction.
Jun 20 2018, 9:14 PM · KDE Edu, Marble

Jun 17 2018

mkoller committed R722:c14dc76bc632: port away from deprecated wbxml function (authored by mkoller).
port away from deprecated wbxml function
Jun 17 2018, 4:19 PM

May 31 2018

mkoller committed R887:93865ea4ced0: In DeviceList mark items, which have been added, for a short time (authored by mkoller).
In DeviceList mark items, which have been added, for a short time
May 31 2018, 7:25 AM

May 27 2018

mkoller committed R887:35abf0850b2c: make top/bottom margins in SysTray zero (authored by mkoller).
make top/bottom margins in SysTray zero
May 27 2018, 9:48 AM
mkoller closed D12601: Set systray outer layout content margins to zero.
May 27 2018, 9:48 AM
mkoller committed R887:d6541b42e8bb: Avoid a dbus call which once led to a crash (authored by mkoller).
Avoid a dbus call which once led to a crash
May 27 2018, 9:47 AM
mkoller requested changes to D12601: Set systray outer layout content margins to zero.

I now committed the patch adapted to your latest suggestion just setting top/bottom margins of hbox to zero.
I don't want to change the separator though.
I think you need to close this issue now manually.

May 27 2018, 8:58 AM

May 17 2018

mkoller accepted D12940: [KolourPaint] Fix color palette cell size.

I don't have 5.11 RC right now to test, but the fix seems reasonable.

May 17 2018, 5:05 AM

May 2 2018

mkoller accepted D12604: Use actual rows count and height to better estimate ICON_SIZE.
May 2 2018, 6:15 AM

May 1 2018

mkoller requested changes to D12604: Use actual rows count and height to better estimate ICON_SIZE.
May 1 2018, 3:25 PM
mkoller accepted D12603: Fix taskbar's MAX_COLUMNS calculation.
May 1 2018, 3:20 PM
mkoller accepted D12602: Set bottom margin same as top margin for taskbar button's icons.
May 1 2018, 3:12 PM
mkoller added a comment to D12601: Set systray outer layout content margins to zero.

Can you explain a bit more in detail why you think this change is useful ?
What stylesheet are you using ? What is your exact setup ?
maybe show a screenshot of the problem you see with the old margins.

May 1 2018, 3:08 PM

Apr 14 2018

mkoller committed R170:86625a0ebcd5: always show an incidence if we are the organizer (authored by mkoller).
always show an incidence if we are the organizer
Apr 14 2018, 11:57 AM

Apr 12 2018

mkoller committed R44:ba213f330650: make sure to create unique filename in maildir resource (authored by mkoller).
make sure to create unique filename in maildir resource
Apr 12 2018, 7:27 PM

Apr 11 2018

mkoller committed R44:e681e74f6a4e: make sure to create unique filename in maildir resource (authored by mkoller).
make sure to create unique filename in maildir resource
Apr 11 2018, 2:50 PM
mkoller closed D12019: make sure to create unique filename in maildir resource.
Apr 11 2018, 2:50 PM · KDE PIM

Apr 10 2018

mkoller added a comment to D12019: make sure to create unique filename in maildir resource.

But the whole createUniqueFileName is not supposed to generate unique names anyways, as it is used in a do loop in Maildir::addEntry. I think be better approach to add to mutex, to garantee
QFile::exists(key) || QFile::exists(finalKey) || QFile::exists(curKey) is valid. Maybe we should touch the file in tmp dir immediately. And than it is irrelevant if we use a not so good createUniqueFileName.

Apr 10 2018, 7:32 PM · KDE PIM

Apr 9 2018

mkoller committed R170:268284b419a5: always show an incidence if we are the organizer (authored by mkoller).
always show an incidence if we are the organizer
Apr 9 2018, 5:28 PM
mkoller updated the diff for D12019: make sure to create unique filename in maildir resource.

changed to milliSeconds.
Altough I'm not really sure if this is a good solution, since how can we know how fast computers will be in some years ?
And QUuid is there for exactly this reason - to generate a unique name.
Yes, the filenames are twice as long - altough: who cares ? Do you think it hurts somewhere ?

Apr 9 2018, 5:18 PM · KDE PIM

Apr 7 2018

mkoller requested review of D12019: make sure to create unique filename in maildir resource.
Apr 7 2018, 12:16 PM · KDE PIM

Apr 5 2018

mkoller added a comment to T8357: Announcement text for the Applications 18.04 release.

In the spectacle section, this part has a typo (buton) and is not really understandable:
"... and how displays a buton to open the Settings window..."

Apr 5 2018, 6:00 AM · KDE Applications, KDE Promo

Apr 2 2018

mkoller committed R722:f68f69ad9b1c: Don't call finish() when task was already aborted (avoiding assert) (authored by mkoller).
Don't call finish() when task was already aborted (avoiding assert)
Apr 2 2018, 6:48 PM

Mar 31 2018

mkoller added a comment to T8357: Announcement text for the Applications 18.04 release.

Don't know if that is automatically included somehow: There is a new application in kde utils: kbackup

Mar 31 2018, 3:26 PM · KDE Applications, KDE Promo

Mar 23 2018

mkoller accepted D11620: Proofread kolourpaint docbook for 18.04.
Mar 23 2018, 9:13 PM

Mar 17 2018

mkoller accepted D11420: Fix build with Qt 5.11 (missing QHeaderView).
Mar 17 2018, 9:10 PM

Mar 5 2018

mkoller accepted D11040: Add KBackup to https://www.kde.org/applications/utilities.
Mar 5 2018, 6:41 AM

Mar 3 2018

mkoller committed R887:0145ba3f43b3: gradually decrease max network throughput scale (authored by mkoller).
gradually decrease max network throughput scale
Mar 3 2018, 4:23 PM
mkoller committed R887:9515d423eceb: avoid duplicate device description in DeviceList (authored by mkoller).
avoid duplicate device description in DeviceList
Mar 3 2018, 4:23 PM
mkoller committed R887:4562720a4949: Fix panel placement in multi-monitor setup (authored by mkoller).
Fix panel placement in multi-monitor setup
Mar 3 2018, 4:23 PM