Port KolourPaint away from deprecated KIntNumInput and KDoubleNumInput
ClosedPublic

Authored by yurchor on Oct 22 2018, 12:26 PM.

Details

Summary

As it was found that the only non-confusing way to port is to "create ONE new widget which contains a slider and a spinbox, and you pass the range it shall use", and the revision for KIntNumInput seems not be appropriate as well, this is a concept of a new solution.

https://phabricator.kde.org/D15223
https://phabricator.kde.org/D15316

Now it is just literally copy-paste of the current classes from kdelibs4support with all their glory (localization support and many unused features). Further work would be modernization and radical trimming down features to the level which is actually used by KolourPaint.

Is this an appropriate approach?

Test Plan

Compiles, installs. No differences should be observed when compared to the current state.

Diff Detail

Repository
R374 KolourPaint
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor requested review of this revision.Oct 22 2018, 12:26 PM
yurchor created this revision.
mkoller accepted this revision.Oct 27 2018, 3:00 PM

Yes, this is a good approach.

This revision is now accepted and ready to land.Oct 27 2018, 3:00 PM
yurchor updated this revision to Diff 44490.Oct 30 2018, 1:51 PM
yurchor retitled this revision from [WIP] Port KolourPaint away from deprecated KIntNumInput and KDoubleNumInput to Port KolourPaint away from deprecated KIntNumInput and KDoubleNumInput.

Tidy up new classes to the state when they can be used without any restrictions in KolourPaint, use new syntax for connections.

This revision was automatically updated to reflect the committed changes.