• Improve comment/doc

• Move the flag to DropJob header, rename

• use the flag approach and add DropJob::menuPopup()

In D26484#591782, @dfaure wrote:

Sorry I have no idea about the calling side in plasma. It sounds buggy indeed, if those are all calls on the same DropJob instance.

I have some questions.
1, Should DropJob::setApplicationActions() be called only one time?
2, I see this when I drop multiple file types at once to the desktop (e.g. 2 jpg and 1 zip), the DropJob::setApplicationActions() is called 3 times as follow:

@mart
Are you ok with this now ?

• Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog

• Simplify the approach

• Improve code

• Improve code

• Improve code

• Remove the new signal and show a "Fetching data" menu while delaying

• Sync with the dependency

• Sync with the dependency

• Move delayPopup to JobFlag

• Add a new function instead of changing the old exported one

• Use signal instead of timer

In D26484#589327, @dfaure wrote:

I don't understand the reasoning, what is this waiting for?

Sometimes 100ms is not enough, maybe there is a better way...

This patch seems to cause this bug: https://bugs.kde.org/show_bug.cgi?id=415917

In T12490#216522, @mvourlakos wrote:

@trmdi what is your opinion for that feature? I can not decide if it is that important in order to add it.

In T12437#215934, @mvourlakos wrote:

@trmdi I tried to animate a bit the screenEdgeMargin for Views that do not behave as plasma panels, meaning that they dont draw their panel shadows externally... You can activate Behavior->Floating->Always use screen gap for user interaction | in order for behaveAsPlasmaPanel to not be activated for floating windows.

https://commits.kde.org/latte-dock/07a10653200613b2dbeeadd67e3c1ebb3a6de914

It seems that the black region is caused by calling QQuickWindow::resize()
Do you have any suggestion?

Because you're a KWin master, and I've just seen you commented on the Latte page on KDE Store, I guess you use Latte, so may I ask you to give some insight on the bug @mvourlakos mentioned above as well as the bug I descibed in the video above? (in order to fix/workaround it)

In D26298#584838, @ngraham wrote:

If you wrote this whole file yourself, you only need to add your own copyright. :)

When watching the video more carefully, I notice this, for example, when you maximize a window, the dock will jump to the bottom of the screen first (1), then it jumps back, and the animation start. I think (1) is redundant and that could be some code in Latte.

Thank you so much @davidedmundson!

• Drop the test method

• Use const reference for some parameters

When changing the window's maximized state, there is a glitch with the black region, see the video:

(the video has the animation, but it also happens without it)

Can we detect when the maximum effect finnishes? We could try removing the gap after that time?

Ping!

In D26266#584135, @mvourlakos wrote:

What is ConfigOverlay for plasma panels is using at its tooltip?

Much cleverer. :)
But is it possible to make it move smoother? Apply some animation for example. Similar to the AutoHide's effect.

In T12437#215585, @mvourlakos wrote:

how about?

But I've just found that Plasma panels use QIcon::fromTheme which load the icon from the icon theme, while PlasmaComponent.ToolButton loads icon from Plasma theme, that is not consistent in some cases. What do you think?

In T12437#215503, @mvourlakos wrote:

Sorry I don't agree visually grouping any more. I was thinking to group Dodge modes but in that way we end up to break visual balance of the settings. The visibility modes are used too often are too important to narrow their visibility foot print.

Another thing, could we combine "Auto Hide", "Dodge *" together? Because I think they have a common behavior (auto hide in some conditions).

In T12437#215450, @trmdi wrote:

Could we add a new option right below the Screen slider?

              Dynamic Visibility
[x] Disable the gap when having maximized windows

Add VDG in case someone wants to give their idea.

In T12437#215445, @mvourlakos wrote:

I don't think we can easily make assumptions for user preferences. Unfortunately we probably need a new option in order to enable/disable dynamically the screen edge margin. But you also know how difficult it is to accept additions in the configuration pages of they don't look right 🙂

When the view's visibility is "Always visible" and there is a maximized window, the view should remove its margin with the screen edge. Because in that case, the user is wanting to focus on the maximized window, the gap now becomes a wasted space and doesn't look nice.
Screenshot:

In D26238#583556, @mvourlakos wrote:

In D26238#583555, @trmdi wrote:

In D26238#583551, @mvourlakos wrote:

@trmdi I used Cuttlefish app, it points to "edit"

Maybe it's document-edit.
(See this: https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.html#l00127)

Correct

• Change icon of the configure action

In D26238#583551, @mvourlakos wrote:

@trmdi I used Cuttlefish app, it points to "edit"

In D26238#583386, @ndavis wrote:

This seems inconsistent with the Plasma panel context menu:

In D26238#583520, @mvourlakos wrote:

look ok! Can you please provide also the three screenshots mentioned earlier for reference?

• Typo

• Call toggleCurrentPage() only when using the shortcut

• Address comments

4. I want to separate between View's items (Add widget, Edit View) and Latte's items (Layouts, Configure Latte) because they are two different groups (one is the global setting, one is the view setting)

(See the After screenshot)

1. It still works for other cases.

• Add a new separator and change addWidget's icon
• Rename Latte Global Settings to Configure Latte Global Settings (Verb+Noun)