Differential D26266

Change remove action's icon to "edit-delete"
AbandonedPublic
Actions

Authored by trmdi on Dec 29 2019, 5:53 AM.

Details

Reviewers
mvourlakos
Group Reviewers
Latte Dock
VDG
Summary

Follow Plasma codes
https://github.com/KDE/plasma-framework/blob/ccceb83b107213ba5d2077fc346d4ab8a027d049/src/plasma/private/applet_p.cpp#L386

Diff Detail

Repository
R878 Latte Dock
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20356
Build 20374: arc lint + arc unit
trmdi created this revision.Dec 29 2019, 5:53 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 29 2019, 5:53 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Dec 29 2019, 5:53 AM
mvourlakos accepted this revision.Dec 29 2019, 7:55 AM
mvourlakos added a reviewer: mvourlakos.
This revision is now accepted and ready to land.Dec 29 2019, 7:55 AM
trmdi added a comment.Dec 29 2019, 8:05 AM

But I've just found that Plasma panels use QIcon::fromTheme which load the icon from the icon theme, while PlasmaComponent.ToolButton loads icon from Plasma theme, that is not consistent in some cases. What do you think?

mvourlakos requested changes to this revision.Dec 29 2019, 8:10 AM
This revision now requires changes to proceed.Dec 29 2019, 8:10 AM
mvourlakos added a comment.Dec 29 2019, 8:11 AM

What is ConfigOverlay for plasma panels is using at its tooltip?

trmdi abandoned this revision.Dec 29 2019, 2:18 PM
In D26266#584135, @mvourlakos wrote:

What is ConfigOverlay for plasma panels is using at its tooltip?

Ah, I was wrong. "delete" should be the right one. Sorry.
https://github.com/KDE/plasma-desktop/blob/def96d60241ad7c835532ee09bf95afb7f56fed7/containments/panel/contents/ui/ConfigOverlay.qml#L408

Revision Contents
Changeset List

Diff 72314

View Options

containment/package/contents/ui/editmode/ConfigOverlay.qml

Loading...
View Options

shell/package/contents/configuration/LatteDockConfiguration.qml

Loading...