Feed Advanced Search

Mar 5 2018

alvinhochun committed R37:1eb8b965f9ea: Don't allow mouse events if pen is pressed (authored by alvinhochun).
Don't allow mouse events if pen is pressed
Mar 5 2018, 3:12 PM

Mar 4 2018

alvinhochun closed D10484: Fix KoJsonTrader scanning incorrect directories.
Mar 4 2018, 11:19 PM · Krita
alvinhochun requested review of D10484: Fix KoJsonTrader scanning incorrect directories.
Mar 4 2018, 11:19 PM · Krita

Mar 3 2018

alvinhochun committed R37:f2a828b2c8f4: Teach New Window to load the saved window state (authored by alvinhochun).
Teach New Window to load the saved window state
Mar 3 2018, 7:04 PM
alvinhochun committed R37:40835b7300a9: Set autocrlf for patches to make them CRLF on Windows (authored by alvinhochun).
Set autocrlf for patches to make them CRLF on Windows
Mar 3 2018, 7:04 PM
alvinhochun committed R37:4f2610accf38: Revert "Windows: Use --binary for all patch steps" (authored by alvinhochun).
Revert "Windows: Use --binary for all patch steps"
Mar 3 2018, 7:04 PM
alvinhochun added a reverting change for R37:3d51ecc539ef: Windows: Use --binary for all patch steps: R37:4f2610accf38: Revert "Windows: Use --binary for all patch steps".
Mar 3 2018, 7:04 PM
alvinhochun committed R37:87829051d2d1: Teach New Window to load the saved window state (authored by alvinhochun).
Teach New Window to load the saved window state
Mar 3 2018, 7:00 PM
alvinhochun committed R37:d649bc6b62af: Set autocrlf for patches to make them CRLF on Windows (authored by alvinhochun).
Set autocrlf for patches to make them CRLF on Windows
Mar 3 2018, 12:56 PM
alvinhochun committed R37:4b24d9e00835: Revert "Windows: Use --binary for all patch steps" (authored by alvinhochun).
Revert "Windows: Use --binary for all patch steps"
Mar 3 2018, 12:56 PM
alvinhochun added a reverting change for R37:d78ea6551dae: Windows: Use --binary for all patch steps: R37:4b24d9e00835: Revert "Windows: Use --binary for all patch steps".
Mar 3 2018, 12:56 PM
alvinhochun added a comment to D10988: Windows: Update ext_qt to Qt 5.9.4 again with extra patch.

I'm fine with the version we have now... I guess we can wait for the next 5.9 release and then check again and update?

Mar 3 2018, 12:26 PM · Krita
alvinhochun requested review of D10988: Windows: Update ext_qt to Qt 5.9.4 again with extra patch.
Mar 3 2018, 11:19 AM · Krita
alvinhochun added a reverting change for R37:9b17ecf027fb: Revert "Windows: Update ext_qt to Qt 5.9.4": D10988: Windows: Update ext_qt to Qt 5.9.4 again with extra patch.
Mar 3 2018, 11:19 AM
alvinhochun committed R37:d78ea6551dae: Windows: Use --binary for all patch steps (authored by alvinhochun).
Windows: Use --binary for all patch steps
Mar 3 2018, 8:15 AM

Mar 2 2018

alvinhochun committed R37:0ea9f706f842: Windows: Remove Python interpreter EXE from package (authored by alvinhochun).
Windows: Remove Python interpreter EXE from package
Mar 2 2018, 2:06 PM
alvinhochun committed R37:060d613af6bc: Windows: Remove Python interpreter EXE from package (authored by alvinhochun).
Windows: Remove Python interpreter EXE from package
Mar 2 2018, 2:01 PM

Mar 1 2018

alvinhochun committed R37:70091fbb6cec: Possibly fix WinTab cursor offset on some tablets (authored by alvinhochun).
Possibly fix WinTab cursor offset on some tablets
Mar 1 2018, 6:38 PM
alvinhochun committed R37:139e1da82837: Possibly fix WinTab cursor offset on some tablets (authored by alvinhochun).
Possibly fix WinTab cursor offset on some tablets
Mar 1 2018, 6:37 PM
alvinhochun closed D10685: Fix WinTab coordinates offset on some tablets.
Mar 1 2018, 6:37 PM · Krita: Stable bug fixes
alvinhochun committed R37:6eb59967e401: Windows: Update krita-nsis to v1.2.4b (authored by alvinhochun).
Windows: Update krita-nsis to v1.2.4b
Mar 1 2018, 3:37 PM
alvinhochun committed R37:7daf854294ea: Fix KoJsonTrader scanning incorrect directories (authored by alvinhochun).
Fix KoJsonTrader scanning incorrect directories
Mar 1 2018, 12:34 PM

Feb 28 2018

alvinhochun planned changes to D10447: Add CMake flag to force -O3 for RelWithDebInfo.
Feb 28 2018, 1:31 PM · Krita

Feb 27 2018

alvinhochun created T8106: Manual Testing for a Release.
Feb 27 2018, 6:26 PM · Krita: Manual
alvinhochun committed R37:9b17ecf027fb: Revert "Windows: Update ext_qt to Qt 5.9.4" (authored by alvinhochun).
Revert "Windows: Update ext_qt to Qt 5.9.4"
Feb 27 2018, 4:02 PM
alvinhochun added a reverting change for R37:282fbca21ebf: Windows: Update ext_qt to Qt 5.9.4: R37:9b17ecf027fb: Revert "Windows: Update ext_qt to Qt 5.9.4".
Feb 27 2018, 4:02 PM

Feb 26 2018

alvinhochun committed R37:2804a5702926: SvgTextEditor: Set parent to settingsDialog (authored by alvinhochun).
SvgTextEditor: Set parent to settingsDialog
Feb 26 2018, 4:01 PM
alvinhochun updated the title for P171 Get more detailed stack dump from kritacrash.log generated by Dr. MinGW from Get more detailed stack dump from kritacrash.log generated by DrMingw to Get more detailed stack dump from kritacrash.log generated by Dr. MinGW.
Feb 26 2018, 2:42 PM · Krita
alvinhochun created P171 Get more detailed stack dump from kritacrash.log generated by Dr. MinGW.
Feb 26 2018, 2:37 PM · Krita
alvinhochun committed R37:19f63fadf2ec: SvgTextEditor: Fix default mode inconsistency (authored by alvinhochun).
SvgTextEditor: Fix default mode inconsistency
Feb 26 2018, 12:41 PM

Feb 24 2018

alvinhochun committed R37:67fba1f5de77: Activate texttool editor when it's shown (authored by alvinhochun).
Activate texttool editor when it's shown
Feb 24 2018, 3:16 PM
alvinhochun committed R37:58456a69b962: Fix handling of texttool drag rect (authored by alvinhochun).
Fix handling of texttool drag rect
Feb 24 2018, 2:29 PM

Feb 23 2018

alvinhochun committed R37:f789bb61b3e0: Use a specific version of g'mic (authored by alvinhochun).
Use a specific version of g'mic
Feb 23 2018, 5:15 PM
alvinhochun committed R37:8e1ce45a670f: Fix some errors in 3rdparty/README.md (authored by alvinhochun).
Fix some errors in 3rdparty/README.md
Feb 23 2018, 4:21 PM
alvinhochun committed R37:29b4916c14cd: Add ext_giflib to build instructions (authored by alvinhochun).
Add ext_giflib to build instructions
Feb 23 2018, 4:20 PM
alvinhochun updated the diff for D10685: Fix WinTab coordinates offset on some tablets.
Feb 23 2018, 3:14 PM · Krita: Stable bug fixes
alvinhochun committed R37:fe40027f8b25: Windows: Remove the need for Qt private headers (authored by alvinhochun).
Windows: Remove the need for Qt private headers
Feb 23 2018, 1:48 PM
alvinhochun committed R37:f9697403bcf4: Fix build (authored by alvinhochun).
Fix build
Feb 23 2018, 12:57 PM

Feb 22 2018

alvinhochun triaged T8050: WinTab support code enhancement as Low priority.
Feb 22 2018, 5:23 PM · Krita: Abyss
alvinhochun committed R37:65dd6518ea7b: Windows: Replace some ANGLE checks with OpenGL ES checks (authored by alvinhochun).
Windows: Replace some ANGLE checks with OpenGL ES checks
Feb 22 2018, 5:20 PM

Feb 21 2018

alvinhochun committed R37:d09d434c2550: Windows: Fix crash when run with Qt cmdline args (authored by alvinhochun).
Windows: Fix crash when run with Qt cmdline args
Feb 21 2018, 3:28 AM

Feb 20 2018

alvinhochun requested review of D10685: Fix WinTab coordinates offset on some tablets.
Feb 20 2018, 3:46 PM · Krita: Stable bug fixes
alvinhochun added a comment to D10447: Add CMake flag to force -O3 for RelWithDebInfo.

Hi, @alvinhochun!

15% difference seem to be nice though. It might be a good idea to make this option disabled by default and activate for release builds. What do you think?

Feb 20 2018, 1:20 PM · Krita

Feb 19 2018

alvinhochun abandoned D8459: Allow AMD GPUs OpenGL on OS X with warning.
Feb 19 2018, 5:55 PM
alvinhochun commandeered D8459: Allow AMD GPUs OpenGL on OS X with warning.
Feb 19 2018, 5:55 PM
alvinhochun added a comment to D10157: Fix Crashing when Changing Smoothing Option in a Stroke (Bug 386726).

I think one problem is that we can't prevent people from changing it using e.g. a shortcut during the stroke.

Feb 19 2018, 12:33 PM · Krita
alvinhochun added a comment to D10157: Fix Crashing when Changing Smoothing Option in a Stroke (Bug 386726).

I would ask: Why do we even want to allow the smoothing options to be changed mid-stroke? Surely the smoothing option is supposed to be applied on the whole stroke. Are there any real use cases that need a stroke with different segments using different smoothing options?

Feb 19 2018, 12:28 PM · Krita
alvinhochun committed R37:1984e9d7dcc2: Windows: Strip only debug info from package (authored by alvinhochun).
Windows: Strip only debug info from package
Feb 19 2018, 9:54 AM

Feb 18 2018

alvinhochun committed R37:f9c9bb6c1131: Windows: Reset screen rotation after probing QPA OpenGL (authored by alvinhochun).
Windows: Reset screen rotation after probing QPA OpenGL
Feb 18 2018, 7:21 PM
alvinhochun committed R37:69d5f6209fcf: ext_qt: Work around Qt 5.9.4 build issue (authored by alvinhochun).
ext_qt: Work around Qt 5.9.4 build issue
Feb 18 2018, 3:04 PM
alvinhochun committed R37:0f2a3bdd19e5: Disable Qt OpenGL shader disk cache (authored by alvinhochun).
Disable Qt OpenGL shader disk cache
Feb 18 2018, 8:12 AM

Feb 17 2018

alvinhochun committed R37:ec87be79d603: Append default XDG_DATA_DIRS instead of quitting (authored by alvinhochun).
Append default XDG_DATA_DIRS instead of quitting
Feb 17 2018, 6:15 PM
alvinhochun committed R37:1521ea858cb2: Fix ruler performance problem (authored by mzhou).
Fix ruler performance problem
Feb 17 2018, 5:43 PM
alvinhochun closed D10572: Fix Ruler Performance Problem under High Zoom Level (Bug 390041).
Feb 17 2018, 5:43 PM · Krita
alvinhochun accepted D10572: Fix Ruler Performance Problem under High Zoom Level (Bug 390041).

LGTM! I'll push this for you.

Feb 17 2018, 5:28 PM · Krita

Feb 16 2018

alvinhochun committed R37:2a6b587a2e6e: ext_drmingw: Prevent finding a wrong WinDbg version (authored by alvinhochun).
ext_drmingw: Prevent finding a wrong WinDbg version
Feb 16 2018, 4:51 PM
alvinhochun committed R37:282fbca21ebf: Windows: Update ext_qt to Qt 5.9.4 (authored by alvinhochun).
Windows: Update ext_qt to Qt 5.9.4
Feb 16 2018, 11:08 AM
alvinhochun committed R37:fd034305d30e: ext_drmingw: Build from custom updated sources (authored by alvinhochun).
ext_drmingw: Build from custom updated sources
Feb 16 2018, 11:08 AM
alvinhochun committed R37:7f0b19df5703: pykrita: Wrap Linux-specific code in #ifdef (authored by alvinhochun).
pykrita: Wrap Linux-specific code in #ifdef
Feb 16 2018, 10:41 AM
alvinhochun committed R37:3443805bd99c: ext_gmic: Prevent build error from missing png (authored by alvinhochun).
ext_gmic: Prevent build error from missing png
Feb 16 2018, 10:21 AM

Feb 15 2018

alvinhochun committed R37:4840e16bfed8: Windows: Copy vcruntime140.dll for Python (authored by alvinhochun).
Windows: Copy vcruntime140.dll for Python
Feb 15 2018, 7:05 PM
alvinhochun committed R37:6f92079d8cf4: Add GLOBAL_PROFILE to ext_ocio CMake flags (authored by alvinhochun).
Add GLOBAL_PROFILE to ext_ocio CMake flags
Feb 15 2018, 6:29 PM

Feb 14 2018

alvinhochun added a comment to D10447: Add CMake flag to force -O3 for RelWithDebInfo.

Hi, @alvinhochun!

You can try to run krita-ui-FreehandStrokeBenchmark with the option enabled or not and see the difference. This benchmark checks the most busy part of Krita code: painting with a brush.

Feb 14 2018, 1:39 PM · Krita

Feb 11 2018

alvinhochun requested review of D10447: Add CMake flag to force -O3 for RelWithDebInfo.
Feb 11 2018, 6:23 PM · Krita

Feb 6 2018

alvinhochun committed R37:4d26f23d0697: Merge branch 'alvin/toolbox-layout' (authored by alvinhochun).
Merge branch 'alvin/toolbox-layout'
Feb 6 2018, 1:05 PM
alvinhochun committed R37:676ab40dce15: Fix overshoot offset when scrolling toolbox (authored by alvinhochun).
Fix overshoot offset when scrolling toolbox
Feb 6 2018, 1:05 PM
alvinhochun closed D10290: Improve toolbox layout.
Feb 6 2018, 1:05 PM · Krita
alvinhochun committed R37:b2fe44748e2a: Enable drag scrolling on toolbox (authored by alvinhochun).
Enable drag scrolling on toolbox
Feb 6 2018, 1:05 PM
alvinhochun committed R37:5a376b0d792d: Set toolbar orientation from widget geometry (authored by alvinhochun).
Set toolbar orientation from widget geometry
Feb 6 2018, 1:05 PM
alvinhochun committed R37:81c39388d0ef: Wrap KoToolBox inside a scroll widget (authored by alvinhochun).
Wrap KoToolBox inside a scroll widget
Feb 6 2018, 1:05 PM
alvinhochun committed R37:65d9309695c5: Add scroll buttons to toolbox (authored by alvinhochun).
Add scroll buttons to toolbox
Feb 6 2018, 1:05 PM
alvinhochun committed R37:d444af7d20cd: Change sizeHint of toolbox (authored by alvinhochun).
Change sizeHint of toolbox
Feb 6 2018, 1:05 PM
alvinhochun committed R37:c627ead6e5d3: Add param `notDryRun` to KoToolboxLayout::doLayout (authored by alvinhochun).
Add param `notDryRun` to KoToolboxLayout::doLayout
Feb 6 2018, 1:05 PM
alvinhochun committed R37:56ae67775cd7: Remove broken KoToolBox size adjustment code (authored by alvinhochun).
Remove broken KoToolBox size adjustment code
Feb 6 2018, 1:05 PM
alvinhochun committed R37:817b79253ba6: Don't put toolbox section on last row of prev section (authored by alvinhochun).
Don't put toolbox section on last row of prev section
Feb 6 2018, 1:05 PM
alvinhochun committed R37:84b810dcb3d9: Fix potential crash with KoToolboxLayout (authored by alvinhochun).
Fix potential crash with KoToolboxLayout
Feb 6 2018, 1:05 PM
alvinhochun committed R37:505c1be8ba0c: KoToolBoxLayout::doLayout minor cleanup (authored by alvinhochun).
KoToolBoxLayout::doLayout minor cleanup
Feb 6 2018, 1:05 PM
alvinhochun committed R37:e516b3d4e91e: Extract doLayout from KoToolBoxLayout::setGeometry (authored by alvinhochun).
Extract doLayout from KoToolBoxLayout::setGeometry
Feb 6 2018, 1:05 PM
alvinhochun updated the task description for T7882: Tentative git workflow suggestions.
Feb 6 2018, 12:12 PM · Krita: Manual

Feb 5 2018

alvinhochun updated the task description for T7882: Tentative git workflow suggestions.
Feb 5 2018, 3:19 PM · Krita: Manual

Feb 4 2018

alvinhochun updated the task description for T7882: Tentative git workflow suggestions.
Feb 4 2018, 3:54 PM · Krita: Manual
woltherav awarded T7882: Tentative git workflow suggestions a Love token.
Feb 4 2018, 3:53 PM · Krita: Manual
alvinhochun added a parent task for T7882: Tentative git workflow suggestions: T7666: Contributor's Guide head task.
Feb 4 2018, 3:25 PM · Krita: Manual
alvinhochun added a subtask for T7666: Contributor's Guide head task: T7882: Tentative git workflow suggestions.
Feb 4 2018, 3:25 PM · Krita: Manual
alvinhochun updated the task description for T7882: Tentative git workflow suggestions.
Feb 4 2018, 3:24 PM · Krita: Manual
alvinhochun created T7882: Tentative git workflow suggestions.
Feb 4 2018, 3:22 PM · Krita: Manual

Jan 24 2018

alvinhochun added a comment to D9529: Updates to uiscripter/actions/runaction - enable scripter to run on Python 3.4 systems .

The commit message should also be hard-wrapped to 72 characters (except URLs). Some editors (e.g. vim) can do this for you.

Jan 24 2018, 12:49 PM · Krita

Jan 23 2018

alvinhochun added a comment to D9999: Change ruler subdivision based on zoom level (Bug 388247).

I do have some very minor nitpicks. Check my inline comments.

Jan 23 2018, 8:15 AM · Krita

Jan 21 2018

alvinhochun added a comment to D9999: Change ruler subdivision based on zoom level (Bug 388247).

Please refrain from stating only the bug number in the title, because it makes the title unmeaningful to anybody.

Jan 21 2018, 6:30 AM · Krita
alvinhochun retitled D9999: Change ruler subdivision based on zoom level (Bug 388247) from Fix for Bug 388247 to Change ruler subdivision based on zoom level (Bug 388247).
Jan 21 2018, 6:28 AM · Krita

Jan 16 2018

alvinhochun committed R37:9e427d840ee5: Revert "Make toolbox docker keep its size instead of stretching" (authored by alvinhochun).
Revert "Make toolbox docker keep its size instead of stretching"
Jan 16 2018, 3:24 PM
alvinhochun added a reverting change for R37:c13d82cb0a53: Make toolbox docker keep its size instead of stretching: R37:9e427d840ee5: Revert "Make toolbox docker keep its size instead of stretching".
Jan 16 2018, 3:24 PM
alvinhochun committed R37:c13d82cb0a53: Make toolbox docker keep its size instead of stretching (authored by alvinhochun).
Make toolbox docker keep its size instead of stretching
Jan 16 2018, 3:14 PM

Jan 15 2018

alvinhochun added a comment to T7111: Add workspace presets for portrait mode.

We probably should check if there is a way to make the toolbox prefer keeping its size instead of scaling proportionally when the dock areas are being resized.

Jan 15 2018, 2:56 PM · Krita: Abyss

Jan 14 2018

alvinhochun committed R37:2ab0991e2558: Disable input method on the canvas (authored by alvinhochun).
Disable input method on the canvas
Jan 14 2018, 3:30 PM
alvinhochun committed R37:995f713592e8: Prevent crash when deactivating text tool (authored by alvinhochun).
Prevent crash when deactivating text tool
Jan 14 2018, 1:58 PM
alvinhochun committed R37:94e1e47641c9: Win packaging: Also copy Python libs from deps install dir (authored by alvinhochun).
Win packaging: Also copy Python libs from deps install dir
Jan 14 2018, 8:14 AM

Jan 7 2018

alvinhochun committed R37:1e126635be0d: Generate CMake script for building NSIS installer (authored by alvinhochun).
Generate CMake script for building NSIS installer
Jan 7 2018, 2:26 PM
alvinhochun closed D9687: Generate a CMake script for building the NSIS installer.
Jan 7 2018, 2:26 PM · Krita
alvinhochun updated the diff for D9687: Generate a CMake script for building the NSIS installer.
  • Add NSIS download
  • Add git hash to version string (shouldn't be used in releases, only for testing purpose).
Jan 7 2018, 7:46 AM · Krita