Allow AMD GPUs OpenGL on OS X with warning
AbandonedPublic
Actions

Authored by alvinhochun on Oct 25 2017, 4:00 AM.

Details

Reviewers

Group Reviewers

Summary

Currently, OpenGL support is completely disabled on AMD/Radeon GPUs on OS X. I understand that there are some serious problems?

What this means though is that a lot of current iMacs, esp. the iMac 5K, don't get OpenGL (https://support.apple.com/de-de/HT202823), and QPainterCanvas is _really_ slow on an iMac 5K (I'm testing on an iMac 5K here). On the other hand, OpenGL seems to work.

Now, I just wonder if we can enable AMD GPUs with some kind of warning, so to not generate complaints when it's not working but give people the ability to try it. This is what this patch does:

Diff Detail

Repository

R37 Krita

Lint

Lint Skipped

Unit

Unit Tests Skipped

poke1024 created this revision.Oct 25 2017, 4:00 AM

Yes: https://bugs.kde.org/show_bug.cgi?id=369014

Though it actually shouldn't be present on master. No idea why the commit 4ee5048486b9e24e79ffc4e4e9f784ea001568a9 was pushed, that might have been a mistake.

@rempt Would it be fine to revert the commit on master?

Basically, in 3.x, when Krita is running on an AMD cpu you cannot save to any non-layered file format, such as jpg or png because the GPU keeps the projection locked for some reason. In 4.x, that's not the case, so there opengl isn't disabled on OSX/AMD.

@rempt Would it be fine to revert the commit on master?

Yes, that shouldn't be in master.

Can this still be useful for other OpenGL warnings?

Yes, I think so.

Do we need any action for this patch? As far as I can tell, @rempt has fixed the real bug? What should we do next?

I am considering employing something similar for Windows, but I won't be able use this patch directly. I might also consider some refactoring on kis_opengl.cpp... I think I've stuffed too much Windows-specific code into that file.

I would suggest abandoning this patch.

alvinhochun mentioned this in D9435: Add OpenGL/ANGLE warnings to show in Display settings and make ANGLE default for Intel.Dec 20 2017, 4:38 PM

alvinhochun commandeered this revision.Feb 19 2018, 5:55 PM

alvinhochun abandoned this revision.

alvinhochun added a reviewer: poke1024.

Revision Contents
Changeset List

			Path	Packages
M			libs/ui/dialogs/kis_dlg_preferences.h (3 lines)
M			libs/ui/dialogs/kis_dlg_preferences.cc (24 lines)
M			libs/ui/forms/wdgdisplaysettings.ui (22 lines)
M			libs/ui/opengl/kis_opengl.h (2 lines)
M			libs/ui/opengl/kis_opengl.cpp (20 lines)