The Python palette docker are now able to show palettes, but they cannot edit them yet.

I modified the Python palette docker that it is can now show the palettes correctly. I am thinking disabling it from editting color palettes for now might be a good idea, as all the editting can be done using the C++ docker and it will be easier to bring all the functionalities of the Python docker back when the interfaces to the backend of palettes are more stable.

In D18993#416676, @rempt wrote:

Have you also checked what needs to be done to bring the Python API in line with these changes?

In D14815#337627, @woltherav wrote:

Naw, this is the only option.

Merged Dmitry's fix

In D14815#311954, @dkazakov wrote:

UPD: I've found out that I can push the fix directly into the branch. So now it is pushed

Here is the fix for that memory access problem: the two iterators are created from two different temporary objects returned from the 'keys()' method.

P253 Masterwork From Distant Lands

1	diff --git a/libs/widgets/KisPaletteModel.cpp b/libs/widgets/KisPaletteModel.cpp
2	index 16d8da9..76d2a60 100644
3	--- a/libs/widgets/KisPaletteModel.cpp
4	+++ b/libs/widgets/KisPaletteModel.cpp
5	@@ -131,7 +131,9 @@ int KisPaletteModel::rowNumberInGroup(int rowInModel) const
6	if (m_groupNameRows.contains(rowInModel)) {
7	return -1;
8	}
9	- for (auto it = m_groupNameRows.keys().rbegin(); it != m_groupNameRows.keys().rend(); it++) {
10	+
11	+ auto keys = m_groupNameRows.keys();
12	+ for (auto it = keys.rbegin(); it != keys.rend(); it++) {
13	if (*it < rowInModel) {
14	return rowInModel - *it - 1;
15	}

Changed TestKisSwatchGroup so that all QCOMPARE have values with the same type

In D14815#310469, @scottpetrovic wrote:

Is this the same code that is in your branch? I am getting a build error when trying to build the branch...

/src/libs/pigment/tests/TestKisSwatchGroup.cpp:27: undefined reference to `bool QTest::qCompare<QString, char [6]>(QString const&, char const (&) [6], char const*, char const*, char const*, int)'
/home/scott/krita/src/libs/pigment/tests/TestKisSwatchGroup.cpp:33: undefined reference to `bool QTest::qCompare<QString, char [7]>(QString const&, char const (&) [7], char const*, char const*, char const*, int)'
CMakeFiles/TestKisSwatchGroup.dir/TestKisSwatchGroup.cpp.o: In function `TestKisSwatchGroup::testReplaceEntries()':
/home/scott/krita/src/libs/pigment/tests/TestKisSwatchGroup.cpp:45: undefined reference to `bool QTest::qCompare<QString, char [7]>(QString const&, char const (&) [7], char const*, char const*, char const*, int)'
collect2: error: ld returned 1 exit status

I wiped out my build directory to do a clean build and it still gave that error

Selection won't be made when empty slot is selected

Fixed a bug with the lazy brush options widget