Generate a CMake script for building the NSIS installer
ClosedPublic

Authored by alvinhochun on Jan 5 2018, 7:44 PM.

Details

Summary

To be executed after running the packaging script.

  1. CMake configure Krita + build
  2. Run packaging script
  3. In an empty directory, do the following:
cmake -DREMOVE_DEBUG=ON -DOUTPUT_FILEPATH="%cd%\krita-setup-test.exe"-DKRITA_PACKAGE_ROOT="absolute_path_to_krita_package_output_directory" -P path_to_install_directory\MakeinstallerNsis.cmake

Set REMOVE_DEBUG to ON deletes the debug symbols so they won't be included in the installer.
The script downloads its copy of NSIS.

On the binary factory it probably means adding this after running the packaging script:

mkdir installer
pushd installer
cmake -DREMOVE_DEBUG=ON -DOUTPUT_FILEPATH="%cd%\krita-%version_string%-x64-setup.exe"-DKRITA_PACKAGE_ROOT="%cd%\..\krita-%version_string%-x64" -P C:\Packaging\KritaWS\krita-install\MakeinstallerNsis.cmake
if errorlevel 1 exit /b 1
signtool sign %SIGNTOOL_SIGN_FLAGS% krita-%version_string%-x64-setup.exe
if errorlevel 1 exit /b 1
popd

assuming the package name is "krita-%version_string%-x64" where "%version_string%" is replaced with the release version number and "x64" is replaced to "x86" the 32-bit build.

(You can test it with the nightly build, but if you do please add "DO-NOT-USE" to the output installer filename and rename the file extension to something that is not ".exe", e.g. ".dat")

Test Plan

If this looks fine, I'll commit it and let @bcooksley test on the binary factory later.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alvinhochun created this revision.Jan 5 2018, 7:44 PM
Restricted Application added a subscriber: woltherav. · View Herald TranscriptJan 5 2018, 7:44 PM
alvinhochun requested review of this revision.Jan 5 2018, 7:44 PM
alvinhochun updated this revision to Diff 24866.Jan 7 2018, 7:46 AM
alvinhochun edited the summary of this revision. (Show Details)
alvinhochun edited the test plan for this revision. (Show Details)
alvinhochun added a reviewer: bcooksley.
alvinhochun added a subscriber: bcooksley.
  • Add NSIS download
  • Add git hash to version string (shouldn't be used in releases, only for testing purpose).
This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2018, 2:26 PM
This revision was automatically updated to reflect the committed changes.