In D27181#666927, @papoteur wrote:No, I don't have commit credentials. Go for myself.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
May 10 2020
May 10 2020
May 9 2020
May 9 2020
Great. Nice work :) Do you have commit access or should I commit it for you?
May 6 2020
May 6 2020
May 5 2020
May 5 2020
rthomsen set the repository for D27181: Rename dialog displays also source file information to R36 Ark.
Some nitpicks. I tested the patch and it works as intended :)
May 4 2020
May 4 2020
rthomsen committed R36:b47c534607e2: libarchive: Improve error-handling when loading archive (authored by rthomsen).
libarchive: Improve error-handling when loading archive
May 3 2020
May 3 2020
Almost ready :)
Apr 26 2020
Apr 26 2020
rthomsen set the repository for D27181: Rename dialog displays also source file information to R36 Ark.
I think it makes sense to always require specifying ctime, mtime and size, so please add the three values as arguments to the constructor of OverwriteQuery so we can get rid of setSourceData() and m_from_archive.
rthomsen committed R36:c576a3eb5427: clirar: Remove unnecessary QRegularExpression in readExtractLine() (authored by rthomsen).
clirar: Remove unnecessary QRegularExpression in readExtractLine()
Apr 12 2020
Apr 12 2020
Great. This reduces the loading time to almost half for a large zip archive.
Please change this to use QString::StartsWith() as per dakon's comment so we can get this committed.
Merge branch 'release/20.04'
rthomsen committed R36:eeee61d2471f: Forward errors from archive interface when batch-extracting (authored by rthomsen).
Forward errors from archive interface when batch-extracting
rthomsen committed R36:ec320540e6e3: libzip: Enable progress when batch-extracting (authored by rthomsen).
libzip: Enable progress when batch-extracting
Apr 10 2020
Apr 10 2020
rthomsen updated the summary of D28721: Forward errors from archive interface when batch-extracting.
Jun 9 2019
Jun 9 2019
See task T11049.
Looks good. I tested that the progress info works for both library- and CLI-based plugins.
Jun 2 2019
Jun 2 2019
In D21403#470265, @elvisangelaccio wrote:I also tried to add
connect(archiveInterface(), &ReadOnlyArchiveInterface::progress, this, &CreateJob::onProgress);at the beginning of CreateJob::doWork(), without direct connection, but this only fixes the progress for libzip :/
Jun 1 2019
Jun 1 2019
rthomsen committed R36:42c8e2d8379e: clirar: Use switch-case instead of if-else (authored by rthomsen).
clirar: Use switch-case instead of if-else
May 25 2019
May 25 2019
May 12 2019
May 12 2019
rthomsen committed R36:3ad7526bf9ce: Get columns to show from first file entry (authored by rthomsen).
Get columns to show from first file entry
May 11 2019
May 11 2019
Implement Elvis' suggestions.
Apr 19 2019
Apr 19 2019
Apr 11 2019
Apr 11 2019
Thanks for submitting the patch.
Apr 7 2019
Apr 7 2019
Handle locked RAR archives
Apr 6 2019
Apr 6 2019
Make ReadOnlyArchiveInterface::isLocked() public.
Apr 4 2019
Apr 4 2019
rthomsen committed R36:45fc55b914b8: clirar: Remove double backslashes in isPasswordPrompt() (authored by rthomsen).
clirar: Remove double backslashes in isPasswordPrompt()
Ping? :)
Mar 31 2019
Mar 31 2019
In D20122#440898, @elvisangelaccio wrote:I cannot open the test file...
Mimetype for filename extension ( "application/vnd.rar" ) did not match mimetype for content ( "application/x-zerosize" ). Using content-based mimetype.
Test file:
locked_archive.rar381 BDownload
Remove unrelated change.
Add unittest.
Mar 30 2019
Mar 30 2019
Mar 27 2019
Mar 27 2019
Merge branch 'Applications/19.04'
Fix progress info for CreateJob
Mar 26 2019
Mar 26 2019
Use QOverload::of() so we dont require C++14.
Mar 25 2019
Mar 25 2019
I managed to avoid adding another signal by using qOverload on the connect statement. This requires C++14 support.
Mar 24 2019
Mar 24 2019
In D19953#437295, @elvisangelaccio wrote:If it is possible to somehow force Qt to connect to the signal, then the PercentFromNestedJob is not necessary.
Have you tried with the old-style connect?
This
connect(m_addJob, SIGNAL(percent(KJob*,ulong)), this, SIGNAL(percent(KJob*,ulong)));compiles for me, but I haven't tested it.
Mar 21 2019
Mar 21 2019
Mar 20 2019
Mar 20 2019
Improve performance of cliplugins
Mar 19 2019
Mar 19 2019
Mar 18 2019
Mar 18 2019
Implement Elvis' suggestions.
Mar 15 2019
Mar 15 2019
rthomsen committed R36:00d6582462fd: cli7z: Performance improvements and cleanup (authored by rthomsen).
cli7z: Performance improvements and cleanup
Mar 14 2019
Mar 14 2019
Mar 12 2019
Mar 12 2019
clirar: Performance improvements
Nov 6 2018
Nov 6 2018
clizip: Insert break statement
Fix zstd autotest on Jenkins
Add a missing end parenthesis
Update copyright year
rthomsen committed R36:d876ba3d9ebc: Add support for Zstd-compressed Tar-archives (authored by rthomsen).
Add support for Zstd-compressed Tar-archives
Nov 5 2018
Nov 5 2018
Check for zstd executable.
Nov 3 2018
Nov 3 2018
Implement suggestions.
Only enable Zstandard support if libarchive >= 3.3.3.
In D15369#326826, @elvisangelaccio wrote:Looks good except the version bump.
Add loadtest.
Sep 9 2018
Sep 9 2018
Oct 28 2017
Oct 28 2017
Oct 22 2017
Oct 22 2017
rthomsen committed R36:ee5d045b058a: libzip: Add support for compression methods and levels (authored by rthomsen).
libzip: Add support for compression methods and levels
Follow Elvis' suggestion.
Oct 21 2017
Oct 21 2017
rthomsen committed R36:16313b967cb0: libzip: Support file permissions when creating/opening archives (authored by rthomsen).
libzip: Support file permissions when creating/opening archives
rthomsen committed R36:a9147d82b3d1: libzip: Improve test integrity function (authored by rthomsen).
libzip: Improve test integrity function
Implement ELvis' suggestions.
rthomsen committed R36:48393a65b730: Detect CRC errors when extracting w. cli7z and clizip Detect CRC errors when… (authored by rthomsen).
Detect CRC errors when extracting w. cli7z and clizip Detect CRC errors when…
Provide more useful error message.