In D27181#666927, @papoteur wrote:

No, I don't have commit credentials. Go for myself.

Great. Nice work :) Do you have commit access or should I commit it for you?

Some nitpicks. I tested the patch and it works as intended :)

Almost ready :)

I think it makes sense to always require specifying ctime, mtime and size, so please add the three values as arguments to the constructor of OverwriteQuery so we can get rid of setSourceData() and m_from_archive.

Great. This reduces the loading time to almost half for a large zip archive.

Please change this to use QString::StartsWith() as per dakon's comment so we can get this committed.

See task T11049.

Looks good. I tested that the progress info works for both library- and CLI-based plugins.

In D21403#470265, @elvisangelaccio wrote:

I also tried to add

connect(archiveInterface(), &ReadOnlyArchiveInterface::progress, this, &CreateJob::onProgress);

at the beginning of CreateJob::doWork(), without direct connection, but this only fixes the progress for libzip :/

Implement Elvis' suggestions.

Thanks for submitting the patch.

Make ReadOnlyArchiveInterface::isLocked() public.

Ping? :)

In D20122#440898, @elvisangelaccio wrote:

I cannot open the test file...

Mimetype for filename extension ( "application/vnd.rar" ) did not match mimetype for content ( "application/x-zerosize" ). Using content-based mimetype.

Test file:

Remove unrelated change.

Add unittest.

Use QOverload::of() so we dont require C++14.

I managed to avoid adding another signal by using qOverload on the connect statement. This requires C++14 support.

In D19953#437295, @elvisangelaccio wrote:

If it is possible to somehow force Qt to connect to the signal, then the PercentFromNestedJob is not necessary.

Have you tried with the old-style connect?

This

connect(m_addJob, SIGNAL(percent(KJob*,ulong)), this, SIGNAL(percent(KJob*,ulong)));

compiles for me, but I haven't tested it.

Implement Elvis' suggestions.

Check for zstd executable.

Implement suggestions.

Only enable Zstandard support if libarchive >= 3.3.3.

In D15369#326826, @elvisangelaccio wrote:

Looks good except the version bump.

Add loadtest.

Follow Elvis' suggestion.

Implement ELvis' suggestions.

Provide more useful error message.