| elvisangelaccio |
The old test implementation only opens the archive with some additional checks, but fails to detect archives with CRC errors for entries, e.g. in bug 384622.
We now read each entry and check the CRC checksum against the one given in the file header. We use zlib's crc32() function to compute the checksum.
Open archive attached to bug 384622 and verify that Test Integrity detects the bad checksums.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| plugins/libzipplugin/CMakeLists.txt | ||
|---|---|---|
| 18 | Should be marked as REQUIRED | |
| 22 | "Required for integrity check in libzip plugin" | |
| plugins/libzipplugin/libzipplugin.cpp | ||
| 429 | const | |
| 430 | spaces around = | |
| 440 | leak if we go in either of the return false branches. Use a scoped pointer, so that we can also drop the delete buf below. | |
| 441 | const | |