Differential D21686

CreateJob: connect to progress() signal instead of KJob::percent()
ClosedPublic
Actions

Authored by elvisangelaccio on Jun 9 2019, 9:02 AM.

Details

Reviewers
rthomsen
Commits
R36:97bb6421e287: CreateJob: connect to progress() signal instead of KJob::percent()
Summary

Another attempt at fixing #402824 after ce2f7f6690be.

This should fix progress reporting also for libzip and libarchive plugins.
The problem with those plugin is that CreateJob starts two nested threads.

BUG: 402824
FIXED-IN: 19.04.3

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio created this revision.Jun 9 2019, 9:02 AM
Restricted Application added a project: Ark. · View Herald TranscriptJun 9 2019, 9:02 AM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Jun 9 2019, 9:02 AM
rthomsen accepted this revision.Jun 9 2019, 10:06 AM

Looks good. I tested that the progress info works for both library- and CLI-based plugins.

This revision is now accepted and ready to land.Jun 9 2019, 10:06 AM
Closed by commit R36:97bb6421e287: CreateJob: connect to progress() signal instead of KJob::percent() (authored by elvisangelaccio). · Explain WhyJun 9 2019, 10:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkerfuffle/jobs.cpp (5 lines)

Diff 59444

View Options

kerfuffle/jobs.cpp

Loading...