This adds regexps to cli7z and clizip which catch bad CRC checksums for archive entries when extracting. This fixes bug 384622 that was reported before we added the libzip plugin. Libzipplugin already catches this CRC errors when extracting.
This diff adds a new string, so maybe we should commit it to master?
Open and extract the archive attached to bug 384622 using both cli7z and clizip plugins and verify that an error message appears.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Libzipplugin already catches this CRC errors when extracting.
I don't get the corrupt query when opening the test archive with libzip. Do you?
No, only when extracting. The problem with this archive is that the CRC checksum is wrong for some files, but the archive itself can be opened (i.e. the central directory is ok).
| plugins/cli7zplugin/cliplugin.cpp | ||
|---|---|---|
| 277 | Would it be possible to split the regexes so that we can show a more descriptive warning message (like we do for clizip)? | |