Feed Advanced Search

Aug 29 2018

wojnilowicz committed R261:39dc8092069b: Add ext_kglobalaccel dependency to kxmlgui (authored by wojnilowicz).
Add ext_kglobalaccel dependency to kxmlgui
Aug 29 2018, 2:28 PM

Aug 28 2018

wojnilowicz committed R261:503942b900ab: kdbusaddons doesn't need any patch (authored by wojnilowicz).
kdbusaddons doesn't need any patch
Aug 28 2018, 3:41 PM

Aug 27 2018

wojnilowicz committed R261:64d17ec75212: Lessen required GCC version (authored by wojnilowicz).
Lessen required GCC version
Aug 27 2018, 6:51 PM
wojnilowicz added a comment to D13838: Add fatal warning in case unsupport gcc version has been used.

Could you change required version from 6.0 to 5.4?

Aug 27 2018, 6:03 PM
wojnilowicz committed R261:0503358d0d12: Add Phonon4Qt5 to AppImage dependencies (authored by wojnilowicz).
Add Phonon4Qt5 to AppImage dependencies
Aug 27 2018, 2:30 PM

Aug 26 2018

wojnilowicz committed R261:23a56f006bdd: Build KDE Frameworks for AppImage (authored by wojnilowicz).
Build KDE Frameworks for AppImage
Aug 26 2018, 11:33 AM
wojnilowicz committed R261:3d5b52c1e404: Try to fix SQLCipher test on MSVC (authored by wojnilowicz).
Try to fix SQLCipher test on MSVC
Aug 26 2018, 10:31 AM
wojnilowicz committed R261:162f7542a09d: Don't hardcode custom icons location (authored by wojnilowicz).
Don't hardcode custom icons location
Aug 26 2018, 10:31 AM
wojnilowicz closed D15087: Don't hardcode custom icons location.
Aug 26 2018, 10:31 AM · KMyMoney
wojnilowicz committed R883:1523412: Update translations in kf5-trunk.
Update translations in kf5-trunk
Aug 26 2018, 10:18 AM
wojnilowicz added a comment to D13842: Fix compile error on linux using Gpgmepp caused by incorrect upper/lower case.

I can think of that this reference may be included as a direct library dependency in a 3rdparty dependency, if GPGME was not found

Aug 26 2018, 8:30 AM
wojnilowicz added a comment to D13838: Add fatal warning in case unsupport gcc version has been used.
Aug 26 2018, 8:23 AM
wojnilowicz requested changes to D13838: Add fatal warning in case unsupport gcc version has been used.
Aug 26 2018, 8:08 AM
wojnilowicz added a comment to D13838: Add fatal warning in case unsupport gcc version has been used.

I got this answer:

Ok, so it's a known GCC issue. Fix for the issue was also backported to GCC-5
branch, but probably not fully. Anyway, please update to a newer version of
GCC, GCC-5 branch is out of support.
Aug 26 2018, 8:08 AM
wojnilowicz requested review of D15087: Don't hardcode custom icons location.
Aug 26 2018, 7:54 AM · KMyMoney
wojnilowicz committed R261:567162a3f240: Don't build that many dependencies for AppImage (authored by wojnilowicz).
Don't build that many dependencies for AppImage
Aug 26 2018, 5:21 AM

Aug 25 2018

wojnilowicz committed R261:6c1c447eeffa: Fix some scripts for AppImage (authored by wojnilowicz).
Fix some scripts for AppImage
Aug 25 2018, 5:40 PM
wojnilowicz committed R261:c7422200f73c: Patch libxml to link against iconv (authored by wojnilowicz).
Patch libxml to link against iconv
Aug 25 2018, 5:09 AM

Aug 24 2018

wojnilowicz committed R261:8a7c95bb4928: Don't build libxml2 without environment variable (authored by wojnilowicz).
Don't build libxml2 without environment variable
Aug 24 2018, 3:19 PM

Aug 23 2018

wojnilowicz committed R261:b4aba75c5bde: Try to fix building of libxml2 (authored by wojnilowicz).
Try to fix building of libxml2
Aug 23 2018, 3:43 PM

Aug 22 2018

wojnilowicz committed R261:63b4cb86d552: Try to fix building on MinGW (authored by wojnilowicz).
Try to fix building on MinGW
Aug 22 2018, 3:30 PM
wojnilowicz committed R261:c052378f92f3: Try to fix building on MinGW (authored by wojnilowicz).
Try to fix building on MinGW
Aug 22 2018, 1:47 PM
wojnilowicz committed R261:b6c694e83768: Try to fix building of libxml2 (authored by wojnilowicz).
Try to fix building of libxml2
Aug 22 2018, 1:47 PM

Aug 21 2018

wojnilowicz added a comment to T6308: new CI system-windows build for Skrooge.

This has been confirmed. The only things that can be done in this case are:

  1. Develop/Port a CMake build system for SQLCipher
  2. Introduce CI support for MingW builds.

    Any comments on this @smankowski and @wojnilowicz ?

    Note that introducing MingW support won't be trivial and will require modification of a few parts of the CI Tooling so some assistance with that will be needed.
Aug 21 2018, 3:43 PM · build.kde.org

Aug 19 2018

wojnilowicz committed R261:79769249df53: Try to fix building on MinGW (authored by wojnilowicz).
Try to fix building on MinGW
Aug 19 2018, 1:37 PM
wojnilowicz committed R261:7e0d6cb56644: Add AppImage build scripts (authored by wojnilowicz).
Add AppImage build scripts
Aug 19 2018, 1:37 PM
wojnilowicz closed D14926: Add AppImage build scripts.
Aug 19 2018, 1:37 PM · KMyMoney
wojnilowicz updated the diff for D14926: Add AppImage build scripts.

Changed source links to our own.

Aug 19 2018, 1:10 PM · KMyMoney
wojnilowicz added a comment to D14926: Add AppImage build scripts.

Cool, I started out to read about appimage a few times myself but never got around to really work on it. I have not tried any of that yet, but it looks very promising. Can we have that for the upcoming 5.0.2 release?

Aug 19 2018, 1:09 PM · KMyMoney
wojnilowicz committed R877:941e78a46990: Update blacklist for KMyMoney (authored by wojnilowicz).
Update blacklist for KMyMoney
Aug 19 2018, 8:29 AM
wojnilowicz committed R877:1ce933a310ba: Don't autoreconf gwenhywfar on MacOS too (authored by wojnilowicz).
Don't autoreconf gwenhywfar on MacOS too
Aug 19 2018, 8:29 AM
wojnilowicz requested review of D14926: Add AppImage build scripts.
Aug 19 2018, 7:16 AM · KMyMoney

Aug 18 2018

wojnilowicz added a comment to T6308: new CI system-windows build for Skrooge.

This has now been provisioned.

Unfortunately the code doesn't successfully compile at the moment due to issues with QSQLite and SQLCipher, but those are problems with the codebase you'll need to fix i'm afraid!
https://binary-factory.kde.org/job/Skrooge_Nightly_mingw64/3/console

Please let us know if anything further is required.

Aug 18 2018, 1:11 PM · build.kde.org
wojnilowicz committed R877:4074a931d3e7: Link dynamically to the MSVC runtime library for SQLCipher (authored by wojnilowicz).
Link dynamically to the MSVC runtime library for SQLCipher
Aug 18 2018, 1:03 PM
wojnilowicz committed R877:41f455395e32: Revert "Apply the same patch on MingW as we do on Windows" (authored by wojnilowicz).
Revert "Apply the same patch on MingW as we do on Windows"
Aug 18 2018, 1:03 PM
wojnilowicz committed R877:5e4ffde26944: Don't autoreconf gwenhywfar on MinGW (authored by wojnilowicz).
Don't autoreconf gwenhywfar on MinGW
Aug 18 2018, 1:03 PM
wojnilowicz added a reverting change for R877:636c10fffa1e: Apply the same patch on MingW as we do on Windows: R877:41f455395e32: Revert "Apply the same patch on MingW as we do on Windows".
Aug 18 2018, 1:03 PM

Aug 13 2018

wojnilowicz added inline comments to D14756: Match transactions differently.
Aug 13 2018, 4:41 PM · KMyMoney
wojnilowicz updated the diff for D14756: Match transactions differently.

Incorporated changes according to the review.

Aug 13 2018, 4:37 PM · KMyMoney
wojnilowicz added a comment to D14756: Match transactions differently.

In general, the idea to change the storage of matching transactions is OK. It was more of a quick hack back then. But I think, we need to iron out a few things before we can add it to master. Maybe even postpone it after the next release, because it changes the file structure and is not backward compatible.

Aug 13 2018, 2:57 PM · KMyMoney

Aug 12 2018

wojnilowicz requested review of D14756: Match transactions differently.
Aug 12 2018, 6:46 AM · KMyMoney

Aug 5 2018

wojnilowicz committed R261:72918e96f6fc: Depluginize SQL storage helpers (authored by wojnilowicz).
Depluginize SQL storage helpers
Aug 5 2018, 7:07 PM
wojnilowicz closed D14564: Depluginize SQL storage helpers.
Aug 5 2018, 7:07 PM · KMyMoney

Aug 4 2018

wojnilowicz updated the diff for D14564: Depluginize SQL storage helpers.
Aug 4 2018, 5:47 AM · KMyMoney
wojnilowicz committed R261:7ec79d01a3c3: Fix bug with unknown QSqlQuery field name (authored by wojnilowicz).
Fix bug with unknown QSqlQuery field name
Aug 4 2018, 5:14 AM
wojnilowicz committed R261:f8aa2d392b70: Move payee identifier widgets to kmm_widgets (authored by wojnilowicz).
Move payee identifier widgets to kmm_widgets
Aug 4 2018, 5:14 AM
wojnilowicz closed D14540: Move payee identifier widgets to kmm_widgets.
Aug 4 2018, 5:14 AM · KMyMoney

Aug 3 2018

wojnilowicz updated the diff for D14540: Move payee identifier widgets to kmm_widgets.
Aug 3 2018, 2:11 PM · KMyMoney
wojnilowicz added a comment to D14522: Integrate Alkimia.

Christian David mentioned at https://mail.kde.org/pipermail/kmymoney-devel/2018-May/020846.html to wait until 23rd of October 2018 before merging alkimia in case no feature has been added.

Who's going to add new features?
That is Christian's point of view. I'm not going to sit and wait longer for a miracle to happen. Nobody develops alkimia and it's unhandy to fix compiler warnings with it being in a separate library.

It is also my POV. Alkimia is stable and does its job. At this point, I don't care for compiler warnings. We certainly have more severe problems than compiler warnings which might have been introduced recently and exist more or less on Windows environments only. I don't want to jeopardize the current stability by changing one of the core elements of KMyMoney. That said, I am against this change to be applied to the current master or 5.0 branch at least until the next KMyMoney release.

Aug 3 2018, 1:23 PM · KMyMoney

Aug 2 2018

wojnilowicz committed R877:984bd0a6b193: Fix SQLCipher on MinGW (authored by wojnilowicz).
Fix SQLCipher on MinGW
Aug 2 2018, 8:00 PM
wojnilowicz requested review of D14564: Depluginize SQL storage helpers.
Aug 2 2018, 5:27 PM · KMyMoney
wojnilowicz added a comment to D14522: Integrate Alkimia.

Christian David mentioned at https://mail.kde.org/pipermail/kmymoney-devel/2018-May/020846.html to wait until 23rd of October 2018 before merging alkimia in case no feature has been added.

Aug 2 2018, 12:49 PM · KMyMoney

Aug 1 2018

wojnilowicz requested review of D14540: Move payee identifier widgets to kmm_widgets.
Aug 1 2018, 5:27 PM · KMyMoney

Jul 31 2018

wojnilowicz requested review of D14522: Integrate Alkimia.
Jul 31 2018, 6:10 PM · KMyMoney
wojnilowicz added inline comments to R877:58ec5cbe2331: Update blacklist for KMyMoney.
Jul 31 2018, 3:39 PM

Jul 30 2018

wojnilowicz committed R877:58ec5cbe2331: Update blacklist for KMyMoney (authored by wojnilowicz).
Update blacklist for KMyMoney
Jul 30 2018, 7:13 PM
wojnilowicz requested review of D14494: Move online task reading and writing to XML storage.
Jul 30 2018, 5:42 PM · KMyMoney

Jul 29 2018

wojnilowicz committed R261:6d444fcdb2cd: Move payee identifier reading and writing to XML storage (authored by wojnilowicz).
Move payee identifier reading and writing to XML storage
Jul 29 2018, 5:14 PM
wojnilowicz closed D14462: Move payee identifier reading and writing to XML storage.
Jul 29 2018, 5:14 PM · KMyMoney
wojnilowicz accepted D14459: Improve CSV importer.

It's as good as before.

Jul 29 2018, 4:16 PM
wojnilowicz requested review of D14462: Move payee identifier reading and writing to XML storage.
Jul 29 2018, 3:42 PM · KMyMoney
wojnilowicz accepted D14459: Improve CSV importer.
Jul 29 2018, 3:36 PM
wojnilowicz committed R261:174d75d09644: Fix build of tests on MSVC (authored by wojnilowicz).
Fix build of tests on MSVC
Jul 29 2018, 9:04 AM
wojnilowicz committed R883:1521192: Update translations in kf5-stable.
Update translations in kf5-stable
Jul 29 2018, 9:02 AM
wojnilowicz committed R883:1521191: Update translations in kf5-trunk.
Update translations in kf5-trunk
Jul 29 2018, 9:02 AM
wojnilowicz committed R261:efe1f5d74ff7: Try to fix MyMoneyException on MS Windows (authored by wojnilowicz).
Try to fix MyMoneyException on MS Windows
Jul 29 2018, 7:52 AM
wojnilowicz committed R261:96568162bd58: Try to fix MyMoneyException on MS Windows (authored by wojnilowicz).
Try to fix MyMoneyException on MS Windows
Jul 29 2018, 7:26 AM
wojnilowicz committed R261:be1295489426: Try to fix SQLCipher on macOS (authored by wojnilowicz).
Try to fix SQLCipher on macOS
Jul 29 2018, 5:49 AM
wojnilowicz committed R261:07795254df17: Try to fix exception handling on FreeBSD (authored by wojnilowicz).
Try to fix exception handling on FreeBSD
Jul 29 2018, 5:49 AM
wojnilowicz committed R261:e4bed7433493: Fix copying of TestMyMoneyObject (authored by wojnilowicz).
Fix copying of TestMyMoneyObject
Jul 29 2018, 5:49 AM
wojnilowicz committed R261:d9e1b377fa82: Break scheduled transactions properly on MS Windows (authored by wojnilowicz).
Break scheduled transactions properly on MS Windows
Jul 29 2018, 5:49 AM
wojnilowicz committed R261:b22945af085f: Disable warnings for SQLite external files (authored by wojnilowicz).
Disable warnings for SQLite external files
Jul 29 2018, 5:49 AM
wojnilowicz added a comment to D13842: Fix compile error on linux using Gpgmepp caused by incorrect upper/lower case.

In general, the issue occurs, if the cmake package Gpgmepp was not found, but the term 'Gpgmepp' has been added to a call to target_link_libraries, which translates the term into -lGpgmepp, searching for a real shared library with this name.

Jul 29 2018, 4:38 AM
wojnilowicz accepted D14439: Only show a single summary of statement import.

Besides my single comment, it looks OK.

Jul 29 2018, 4:37 AM

Jul 28 2018

wojnilowicz accepted D14441: Remove the usage of lastStatementDate in account KVP.

Good move.

Jul 28 2018, 6:02 PM
wojnilowicz added inline comments to D14439: Only show a single summary of statement import.
Jul 28 2018, 6:01 PM
wojnilowicz committed R877:df2c0e4879dd: Fix installation of SQLCipher on MinGW (authored by wojnilowicz).
Fix installation of SQLCipher on MinGW
Jul 28 2018, 12:20 PM
wojnilowicz committed R877:cd9ea54e7e46: Fix SQLite discovery on MacOS (authored by wojnilowicz).
Fix SQLite discovery on MacOS
Jul 28 2018, 9:55 AM

Jul 27 2018

wojnilowicz committed R261:0938c60483b9: Try to fix QSQLCipher on MinGW (authored by wojnilowicz).
Try to fix QSQLCipher on MinGW
Jul 27 2018, 5:56 PM
wojnilowicz committed R877:ab29636c6421: Properly export SQLCipher library (authored by wojnilowicz).
Properly export SQLCipher library
Jul 27 2018, 5:26 PM

Jul 25 2018

wojnilowicz committed R261:149cb049aadf: Try to fix tests on FreeBSD (authored by wojnilowicz).
Try to fix tests on FreeBSD
Jul 25 2018, 3:08 PM
wojnilowicz committed R261:d58f1dd85a03: Revert "Fix QSQLCipher on MinGW" (authored by wojnilowicz).
Revert "Fix QSQLCipher on MinGW"
Jul 25 2018, 3:08 PM
wojnilowicz added a reverting change for R261:754db8aab87b: Fix QSQLCipher on MinGW: R261:d58f1dd85a03: Revert "Fix QSQLCipher on MinGW".
Jul 25 2018, 3:08 PM

Jul 24 2018

wojnilowicz committed R877:6969085ef167: Fix SQLITE_ENABLE_UNLOCK_NOTIFY on macOS (authored by wojnilowicz).
Fix SQLITE_ENABLE_UNLOCK_NOTIFY on macOS
Jul 24 2018, 6:59 PM
wojnilowicz committed R261:8bbc7c66f028: Fix test failure on MSVC (authored by wojnilowicz).
Fix test failure on MSVC
Jul 24 2018, 6:59 PM
wojnilowicz committed R261:3ef14c87fe24: Try to fix QSQLCipher on MinGW (authored by wojnilowicz).
Try to fix QSQLCipher on MinGW
Jul 24 2018, 6:59 PM

Jul 23 2018

wojnilowicz committed R261:754db8aab87b: Fix QSQLCipher on MinGW (authored by wojnilowicz).
Fix QSQLCipher on MinGW
Jul 23 2018, 5:00 PM

Jul 22 2018

wojnilowicz committed R877:05cf803636d6: Fix sqlcipher.pc on MinGW (authored by wojnilowicz).
Fix sqlcipher.pc on MinGW
Jul 22 2018, 6:46 PM
wojnilowicz committed R261:9da135d4bc90: Create XML storage helper (authored by wojnilowicz).
Create XML storage helper
Jul 22 2018, 4:05 PM
wojnilowicz closed D14271: Create XML storage helper.
Jul 22 2018, 4:05 PM · KMyMoney
wojnilowicz requested review of D14271: Create XML storage helper.
Jul 22 2018, 11:31 AM · KMyMoney

Jul 21 2018

wojnilowicz committed R261:3b71d45a4ad2: Try to fix SQLCipher on FreeBSD (authored by wojnilowicz).
Try to fix SQLCipher on FreeBSD
Jul 21 2018, 7:25 PM
wojnilowicz committed R261:1a2bc9020042: Try to fix SQLCipher on FreeBSD (authored by wojnilowicz).
Try to fix SQLCipher on FreeBSD
Jul 21 2018, 7:01 PM
wojnilowicz committed R261:f81002ece35b: Move more writing methods to XML storage (authored by wojnilowicz).
Move more writing methods to XML storage
Jul 21 2018, 7:01 PM
wojnilowicz closed D14261: Move more writing mehods to XML storage.
Jul 21 2018, 7:01 PM · KMyMoney
wojnilowicz committed R877:6483bbf94ae8: Fix SQLCipher on MinGW (authored by wojnilowicz).
Fix SQLCipher on MinGW
Jul 21 2018, 5:19 PM
wojnilowicz added a comment to D14257: Move MyMoneySchedule writing to XML storage.

Tested with my real file which contains 66 schedules. Produces the exact same output as master.

Jul 21 2018, 11:11 AM · KMyMoney
wojnilowicz requested review of D14261: Move more writing mehods to XML storage.
Jul 21 2018, 11:09 AM · KMyMoney
wojnilowicz committed R261:d9776f3497f5: Move MyMoneySchedule writing to XML storage (authored by wojnilowicz).
Move MyMoneySchedule writing to XML storage
Jul 21 2018, 9:31 AM
wojnilowicz closed D14257: Move MyMoneySchedule writing to XML storage.
Jul 21 2018, 9:31 AM · KMyMoney