As before, redundant methods, not present in this patch, will be removed, after the patch will be accepted.
Details
Details
- Reviewers
tbaumgart - Group Reviewers
KMyMoney - Commits
- R261:f81002ece35b: Move more writing methods to XML storage
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks OK and if I apply the following patch it also compiles for me (the first hunk seems to be caused by trailing blanks) :
diff --git a/kmymoney/plugins/xml/mymoneystoragexml.cpp b/kmymoney/plugins/xml/mymoneystoragexml.cpp index 02e623a2..e38790f0 100644 --- a/kmymoney/plugins/xml/mymoneystoragexml.cpp +++ b/kmymoney/plugins/xml/mymoneystoragexml.cpp @@ -564,7 +564,7 @@ MyMoneyTransaction MyMoneyXmlContentHandler::readTransaction(const QDomElement & } } else if (c.tagName() == nodeName(Node::KeyValuePairs)) { - addToKeyValueContainer(transaction, c.toElement()); + addToKeyValueContainer(transaction, c.toElement()); } child = child.nextSibling(); @@ -1361,7 +1361,7 @@ void MyMoneyXmlContentHandler::writeBudget(const MyMoneyBudget &budget, QDomDocu QMap<QString, MyMoneyBudget::AccountGroup>::const_iterator it; auto accounts = budget.accountsMap(); - for (it = accounts.begin(); it != accounts.end(); ++it) { + for (it = accounts.cbegin(); it != accounts.cend(); ++it) { // only add the account if there is a budget entered // or it covers some sub accounts if (!(*it).balance().isZero() || (*it).budgetSubaccounts()) {