Differential D14271

Create XML storage helper
ClosedPublic
Actions

Authored by wojnilowicz on Jul 22 2018, 11:31 AM.

Details

Reviewers

tbaumgart

Group Reviewers

KMyMoney

Commits

R261:9da135d4bc90: Create XML storage helper

Summary

Parts of MyMoneyReport and MyMoneyBudget are stored as XML in SQL storage hence the need of separate xmlstoragehelper library. SQL storage plugin will either remain with XML dependency or an another solution (preferably without XML) will be found.

Diff Detail

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz requested review of this revision.Jul 22 2018, 11:31 AM

wojnilowicz created this revision.

Looks OK to me. I have checked that my datafile can be loaded and produced identical results as master after writing and reading back. This is the case and the tests work.

This revision is now accepted and ready to land.Jul 22 2018, 3:02 PM

Closed by commit R261:9da135d4bc90: Create XML storage helper (authored by wojnilowicz). · Explain WhyJul 22 2018, 4:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		kmymoney/mymoney/CMakeLists.txt (1 line)
M		kmymoney/mymoney/mymoneyaccount.h (3 lines)
M		kmymoney/mymoney/mymoneyaccount.cpp (14 lines)
M		kmymoney/mymoney/mymoneybudget.h (41 lines)
M		kmymoney/mymoney/mymoneybudget.cpp (111 lines)
M		kmymoney/mymoney/mymoneybudget_p.h (67 lines)
M		kmymoney/mymoney/mymoneycostcenter.cpp (3 lines)
M		kmymoney/mymoney/mymoneyenums.h (10 lines)
M		kmymoney/mymoney/mymoneyfile.cpp (12 lines)
M		kmymoney/mymoney/mymoneyinstitution.cpp (2 lines)
M		kmymoney/mymoney/mymoneykeyvaluecontainer.h (12 lines)
M		kmymoney/mymoney/mymoneykeyvaluecontainer.cpp (42 lines)
M		kmymoney/mymoney/mymoneykeyvaluecontainer_p.h (35 lines)
M		kmymoney/mymoney/mymoneyobject.h (21 lines)
M		kmymoney/mymoney/mymoneyobject.cpp (16 lines)
P		kmymoney/mymoney/mymoneyobject_p.h (10 lines) Copied to kmymoney/plugins/xmlhelper/xmlstoragehelper.h
M		kmymoney/mymoney/mymoneypayee.cpp (3 lines)
M		kmymoney/mymoney/mymoneyreport.h (36 lines)
M		kmymoney/mymoney/mymoneyreport.cpp (520 lines)
M		kmymoney/mymoney/mymoneyreport_p.h (412 lines)
M		kmymoney/mymoney/mymoneyschedule.cpp (2 lines)
M		kmymoney/mymoney/mymoneysecurity.cpp (2 lines)
M		kmymoney/mymoney/mymoneytag.cpp (3 lines)
M		kmymoney/mymoney/mymoneytransaction.cpp (3 lines)
M		kmymoney/mymoney/onlinejob.cpp (3 lines)
M		kmymoney/mymoney/storage/mymoneystoragemgr.h (10 lines)
M		kmymoney/mymoney/storage/mymoneystoragemgr.cpp (20 lines)
M		kmymoney/mymoney/storage/mymoneystoragemgr_p.h (22 lines)
D	M	kmymoney/mymoney/storage/mymoneystoragenames.h (73 lines)
D	M	kmymoney/mymoney/storage/mymoneystoragenames.cpp (100 lines)
M		kmymoney/mymoney/storage/tests/mymoneystoragemgr-test.cpp (24 lines)
M		kmymoney/mymoney/tests/mymoneyfile-test.cpp (13 lines)
M		kmymoney/mymoney/tests/mymoneykeyvaluecontainer-test.h (4 lines)
M		kmymoney/mymoney/tests/mymoneykeyvaluecontainer-test.cpp (112 lines)
M		kmymoney/mymoney/tests/mymoneyobject-test.h (1 line)
M		kmymoney/mymoney/tests/mymoneyobject-test.cpp (109 lines)
M		kmymoney/plugins/CMakeLists.txt (4 lines)
M		kmymoney/plugins/sql/CMakeLists.txt (1 line)
M		kmymoney/plugins/sql/mymoneystoragesql.cpp (8 lines)
M		kmymoney/plugins/sql/mymoneystoragesql_p.h (17 lines)
M		kmymoney/plugins/sql/tests/CMakeLists.txt (2 lines)
M		kmymoney/plugins/sql/tests/mymoneydatabasemgr-test.cpp (20 lines)
M		kmymoney/plugins/xml/CMakeLists.txt (1 line)
M		kmymoney/plugins/xml/mymoneystoragenames.h (163 lines)
M		kmymoney/plugins/xml/mymoneystoragenames.cpp (482 lines)
M		kmymoney/plugins/xml/mymoneystoragexml.cpp (338 lines)
M		kmymoney/plugins/xml/tests/CMakeLists.txt (2 lines)
M		kmymoney/plugins/xml/tests/mymoneystoragenames-test.cpp (10 lines)
M		kmymoney/plugins/xml/tests/mymoneyxmlcontenthandler-test.h (1 line)
M		kmymoney/plugins/xml/tests/mymoneyxmlcontenthandler-test.cpp (120 lines)
A	M	kmymoney/plugins/xmlhelper/CMakeLists.txt (11 lines)
P		kmymoney/plugins/xmlhelper/xmlstoragehelper.h (55 lines) Copied from kmymoney/mymoney/mymoneyobject_p.h
A	M	kmymoney/plugins/xmlhelper/xmlstoragehelper.cpp (1204 lines)
M		kmymoney/tests/CMakeLists.txt (1 line)
M		kmymoney/tests/testutilities.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38195			Jul 22 2018, 11:30 AM	★	★
Diff 2	38210	c7e192b	R261:9da135d4bc90e36507c49113fd07089eece7090b	Jul 22 2018, 4:05 PM	★	★

Create XML storage helperClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 38210

kmymoney/mymoney/CMakeLists.txt

kmymoney/mymoney/mymoneyaccount.h

kmymoney/mymoney/mymoneyaccount.cpp

kmymoney/mymoney/mymoneybudget.h

kmymoney/mymoney/mymoneybudget.cpp

kmymoney/mymoney/mymoneybudget_p.h

kmymoney/mymoney/mymoneycostcenter.cpp

kmymoney/mymoney/mymoneyenums.h

kmymoney/mymoney/mymoneyfile.cpp

kmymoney/mymoney/mymoneyinstitution.cpp

kmymoney/mymoney/mymoneykeyvaluecontainer.h

kmymoney/mymoney/mymoneykeyvaluecontainer.cpp

kmymoney/mymoney/mymoneykeyvaluecontainer_p.h

kmymoney/mymoney/mymoneyobject.h

kmymoney/mymoney/mymoneyobject.cpp

kmymoney/mymoney/mymoneyobject_p.h

kmymoney/mymoney/mymoneypayee.cpp

kmymoney/mymoney/mymoneyreport.h

kmymoney/mymoney/mymoneyreport.cpp

kmymoney/mymoney/mymoneyreport_p.h

kmymoney/mymoney/mymoneyschedule.cpp

kmymoney/mymoney/mymoneysecurity.cpp

kmymoney/mymoney/mymoneytag.cpp

kmymoney/mymoney/mymoneytransaction.cpp

kmymoney/mymoney/onlinejob.cpp

kmymoney/mymoney/storage/mymoneystoragemgr.h

kmymoney/mymoney/storage/mymoneystoragemgr.cpp

kmymoney/mymoney/storage/mymoneystoragemgr_p.h

kmymoney/mymoney/storage/mymoneystoragenames.h

kmymoney/mymoney/storage/mymoneystoragenames.cpp

kmymoney/mymoney/storage/tests/mymoneystoragemgr-test.cpp

kmymoney/mymoney/tests/mymoneyfile-test.cpp

kmymoney/mymoney/tests/mymoneykeyvaluecontainer-test.h

kmymoney/mymoney/tests/mymoneykeyvaluecontainer-test.cpp

kmymoney/mymoney/tests/mymoneyobject-test.h

kmymoney/mymoney/tests/mymoneyobject-test.cpp

kmymoney/plugins/CMakeLists.txt

kmymoney/plugins/sql/CMakeLists.txt

kmymoney/plugins/sql/mymoneystoragesql.cpp

kmymoney/plugins/sql/mymoneystoragesql_p.h

kmymoney/plugins/sql/tests/CMakeLists.txt

kmymoney/plugins/sql/tests/mymoneydatabasemgr-test.cpp

kmymoney/plugins/xml/CMakeLists.txt

kmymoney/plugins/xml/mymoneystoragenames.h

kmymoney/plugins/xml/mymoneystoragenames.cpp

kmymoney/plugins/xml/mymoneystoragexml.cpp

kmymoney/plugins/xml/tests/CMakeLists.txt

kmymoney/plugins/xml/tests/mymoneystoragenames-test.cpp

kmymoney/plugins/xml/tests/mymoneyxmlcontenthandler-test.h

kmymoney/plugins/xml/tests/mymoneyxmlcontenthandler-test.cpp

kmymoney/plugins/xmlhelper/CMakeLists.txt

kmymoney/plugins/xmlhelper/xmlstoragehelper.h

kmymoney/plugins/xmlhelper/xmlstoragehelper.cpp

kmymoney/tests/CMakeLists.txt

kmymoney/tests/testutilities.cpp

Create XML storage helper
ClosedPublic
Actions

Revision Contents
Changeset List