Differential D14462

Move payee identifier reading and writing to XML storage
ClosedPublic
Actions

Authored by wojnilowicz on Jul 29 2018, 3:42 PM.

Details

Reviewers

tbaumgart

Group Reviewers

KMyMoney

Commits

R261:6d444fcdb2cd: Move payee identifier reading and writing to XML storage

Summary

Redundant methods will be removed from code after this patch gets accepted.

Along the way payee identifier somehow lost its ability to generate IDs for new objects, so this patch returns these IDs by assigning new IDs at loading time, just like it's with transactions. I hope that wasn't and isn't important for other parts of KMM.

Diff Detail

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz requested review of this revision.Jul 29 2018, 3:42 PM

wojnilowicz created this revision.

Looks OK to me, though I cannot really test it other than looking at the written data.

This revision is now accepted and ready to land.Jul 29 2018, 4:34 PM

Closed by commit R261:6d444fcdb2cd: Move payee identifier reading and writing to XML storage (authored by wojnilowicz). · Explain WhyJul 29 2018, 5:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/plugins/xml/mymoneystoragenames.h (10 lines)
M			kmymoney/plugins/xml/mymoneystoragenames.cpp (13 lines)
M			kmymoney/plugins/xml/mymoneystoragexml.cpp (104 lines)
M			kmymoney/plugins/xml/tests/mymoneystoragenames-test.cpp (2 lines)