Differential D14257

Move MyMoneySchedule writing to XML storage
ClosedPublic
Actions

Authored by wojnilowicz on Jul 21 2018, 5:11 AM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R261:d9776f3497f5: Move MyMoneySchedule writing to XML storage

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz requested review of this revision.Jul 21 2018, 5:11 AM

wojnilowicz created this revision.

I am missing the removal of the old version in MyMoneySchedule::writeXML().

In D14257#295447, @tbaumgart wrote:

I am missing the removal of the old version in MyMoneySchedule::writeXML().

Yes, it will be removed with all the redundant (unused) code. I think it would just obfuscate the significant part of this patch.

Tested with my real file which contains 66 schedules. Produces the exact same output as master.

This revision is now accepted and ready to land.Jul 21 2018, 8:17 AM

Closed by commit R261:d9776f3497f5: Move MyMoneySchedule writing to XML storage (authored by wojnilowicz). · Explain WhyJul 21 2018, 9:31 AM

This revision was automatically updated to reflect the committed changes.

In D14257#295467, @tbaumgart wrote:

Tested with my real file which contains 66 schedules. Produces the exact same output as master.

Thank you for your throughout testing.

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/mymoney/mymoneyobject.h (2 lines)
M			kmymoney/mymoney/mymoneyobject.cpp (5 lines)
M			kmymoney/mymoney/mymoneyschedule.h (2 lines)
M			kmymoney/mymoney/mymoneyschedule.cpp (39 lines)
M			kmymoney/mymoney/mymoneysplit.h (2 lines)
M			kmymoney/mymoney/mymoneysplit.cpp (39 lines)
M			kmymoney/mymoney/mymoneytransaction.h (2 lines)
M			kmymoney/mymoney/mymoneytransaction.cpp (23 lines)
M			kmymoney/mymoney/tests/mymoneyschedule-test.h (1 line)
M			kmymoney/mymoney/tests/mymoneyschedule-test.cpp (132 lines)
M			kmymoney/mymoney/tests/mymoneytransaction-test.h (1 line)
M			kmymoney/mymoney/tests/mymoneytransaction-test.cpp (82 lines)
M			kmymoney/plugins/xml/mymoneystoragexml.cpp (39 lines)
M			kmymoney/plugins/xml/tests/mymoneyxmlcontenthandler-test.cpp (4 lines)

Diff 38162

kmymoney/mymoney/mymoneyobject.h

Loading...

kmymoney/mymoney/mymoneyobject.cpp

Loading...

kmymoney/mymoney/mymoneyschedule.h

Loading...

kmymoney/mymoney/mymoneyschedule.cpp

Loading...

kmymoney/mymoney/mymoneysplit.h

Loading...

kmymoney/mymoney/mymoneysplit.cpp

Loading...

kmymoney/mymoney/mymoneytransaction.h

Loading...

kmymoney/mymoney/mymoneytransaction.cpp

Loading...

kmymoney/mymoney/tests/mymoneyschedule-test.h

Loading...

kmymoney/mymoney/tests/mymoneyschedule-test.cpp

Loading...

kmymoney/mymoney/tests/mymoneytransaction-test.h

Loading...

kmymoney/mymoney/tests/mymoneytransaction-test.cpp

Loading...

kmymoney/plugins/xml/mymoneystoragexml.cpp

Loading...

kmymoney/plugins/xml/tests/mymoneyxmlcontenthandler-test.cpp

Loading...