| wojnilowicz |
other importers do. This avoids a whole bunch of problems.
on the last page of the wizard.
the last page and does not automatically start importing.
BUG: 396759
Tested single file import and web-connect import
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| kmymoney/plugins/csv/import/csvimporter.cpp | ||
|---|---|---|
| 80–81 | QString::endsWith can use Qt::CaseSensitivity, so no need for QString::toLower. | |
| kmymoney/plugins/csv/import/csvwizard.cpp | ||
| 65 | Where is that deleted afer finished work? I see it's not because your change but maybe it wouldn't be difficult to delete it somewhere. | |
| 310 | Typo. | |
It's as good as before.
| kmymoney/plugins/csv/import/csvimporter.cpp | ||
|---|---|---|
| 80–81 | I would check on "filename" and not "f.fileName()" and would do that outside of this conditional. | |
| kmymoney/plugins/csv/import/csvwizard.cpp | ||
| 72 | Isn't this taking ownership of m_wiz, so there is no need to delete it in this class desctructor? Please read more here. | |
| 361 | Typo as well. I think it should be programmatically. | |
| kmymoney/plugins/csv/import/csvwizard.cpp | ||
|---|---|---|
| 72 | Good catch. I was looking for something like that but did not spot it. | |