Support touchpad "mousewheel" which is pixel perfect based off plasma-pa's code.

Oh I see, "Commandeer revision" is in the "Add action..." dropdown, not the sidebar.

What are wallpaper plugins?

Would making these 2 new categories ("Plasma 5 Clocks" and "Plasma 5 Menus") subcategory to "Plasma 5 Widgets" work? What I mean is, would it list the menus and clocks in Plasma's "Download New Plasma Widgets" installer?

I don't think I can attach a new diff to your differential, so here's a link to it:

So you removed 2 units from the overall cell height, but only 1 unit from the frameloader height. This means you removed 1 unit from the "leftover" padding at the bottom of the frameloader, and are overlapping the cell below by another 1 unit.

Before patch:

Quick note since I just notice you suggested a lowercase i in ?linkid=3, should I change it to lowercase or stick with camelcase?

Good idea. This will future proof us in case we ever want ?linkName=tiledmenu-v18-kde5.9.plasmoid or something as well.

Another note: plasmoidviewer is unaffected by this patch. Meaning

This worked

No prob, thanks for accepting it (including the mockup stuff). It'll make it easier to test if I see anything else. 🙂

https://phabricator.kde.org/D6764

@broulik oh awesome. Uhg, not sure why I didn't see that function.

Neat. I gave it a test.

Oh awesome. Just found out about this. So this would be added in Frameworks 5.37 then?

Jump by 2px. Jump by __ clicks. Make sure thickness is even. Hide thickness in button after 1 second.

Great idea about using a timer in the binding. I can probably keep the onThicknessChanged binding since it does change size when moved from left/right to top/bottom.

+semicolon and specify it's scrollArea.ready

So before my commit, it was only needing to do:

qml: cellHeight iconHeight 108
qml: cellWidth iconWidth 92
qml: cellHeight iconHeight 108

@hein Good catch with the && isRootView. It's just optimization since the extraSpace for the popup is 0 right? Now that I think on it, not sure why I made the variables into properties. Probably for logging onVarChanged when debugging it. Would this be more efficient?

Semicolons... (I should install a linter)

We don't really need to wait for folderViewLayer.ready before setting the bottom/right anchors anymore.
Don't add extra spacing if we're not a containment (the desktop).
Remove comment that's no longer applicable.

What behaviour should the folder widget use:

In D6188#115982, @hein wrote:

You didn't change the comment above the code you modified. Did you test that this is no longer an issue? If not, the comment needs adjusting.

+readonly. +semicolons.
Remove check for if we're already overflowing, using rtl layout, or if it's "arrange in columns/rows", since the ScrollView shouldn't be covered by panels.

Oh now I remember why I used scrollView.viewport. We don't want to count the scrollbars as "extra" space. Notice in this screenshot it would perfectly fit another row, but the scrollbar made the area shorter.

So removing the following two conditionals fixes it. I'm not sure why they are there. Right now it only stops at the panels if we're already overflowing.
in rightMargin: (folderViewLayer.view.overflowing || folderViewLayer.view.flow == GridView.FlowLeftToRight || folderViewLayer.view.layoutDirection == Qt.RightToLeft)
in bottomMargin: (folderViewLayer.view.overflowing || folderViewLayer.view.flow == GridView.FlowTopToBottom)

In D6188#115778, @broulik wrote:

About panels covering the contents, perhaps you want to take into account plasmoid.availableScreenRect but root already has a margin based on this, so maybe just use the ScrollView's size instead of viewport.

Cleaner logic in calcExtraSpacing().

I tried commenting again today and it worked.

Hmm, just of this after reading a comment on reddit. Latte-Dock uses another process, would this cause keyboard shortcuts to not work for it? I'm not sure if it has a different app name.

I should also note that the list of 151 comments isn't related to the product, since the product https://store.kde.org/p/1153173 only has ~5 comments.

Apply to icons-dark too.

Is there a "daytime" setting or is it hardcoded to be 100% blue? Redshift Control for example:

Since people still can't install the moved widgets via GHNS, I'm moving my Tiled Menu widget back to the category "Plasma Widgets". Please don't move it back unless it can be installed with GHNS in the Plasma 5.8 LTS.

Hmmm, this seems better than my solution since mine stays in the boosted state (slide.maxValue=150%) after the volume when back below 100%.

I see you saw the /r/linux thread:
https://www.reddit.com/r/linux/comments/68jy8l/kde_users_how_do_you_switch_between_two_audio/

Doesn't this change make those widget uninstallable with GHNS with the current, and more importantly, older versions of plasma?

Should I go ahead and commit this?

I've seen that, but that is unrelated to this change, so please move it into separate review.

And yes I know KDE Neon is Qt 5.7.1 at the moment, I meant to ask wither it's part of the standard install of Qt.

Oh neat! Hmm experimental Qt 5.8 library is fine, but would it be installed by default on say KDE Neon or would it need a package to be manually installed?

Thought you might want that, but wasn't sure how to expose QStandardPaths to QML. Got an example handy? All I can find is:

Before tackling the implicitWidth/height stuff, I noticed that my microphone's Heading label was getting moved on the first click. Adding height: contextMenuButton.height fixes it but that doesn't feel right.

Create a reusuble SmallToolButton class.
Add smallSpacing around the mute button.
Remove spacing between the two rows to counter the increase in height.

Another thing we could do to keep things small vertically is set spacing: 0 in the ColumnLayout { id: column }.

Ah, ignore the visible: false in that, was testing which variables ToolButton uses (iconSource. iconName).

Yeah, it's probably dpi scaling.

I made D5144 which turns the volume icon/mute button into a ToolButton.

Breeze's 16px small microphone-sensitivity-[low/medium/high] icons do not follow the color scheme. The 16px -muted, which is a softlink to the mic-off.svg icon is okay. This is because the style="color:#4d4d4d;..." which overrides the fill:currentColor. We'll need to remove those from

Looks good.