Differential D8324

Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments
ClosedPublic
Actions

Authored by Zren on Oct 16 2017, 12:59 AM.

Details

Reviewers
ivan
Commits
R845:0ad9e0a1fdc2: Fix ActionItem Label width, minimumWidth=300, DPI scaled minimum size
Summary

First I fixed the ActionItem label width exiting the button boundaries mentioned in BUG: 385794
https://bugs.kde.org/show_bug.cgi?id=385794

Example of the bug:

Since We cutoff the ActionItem text, I then changed the minimum width to 300px since it fits the *english* text naturally.

I could probably change that to preferredWidth=300px (with minimumWidth=200px) if you want a desktop widget to start at 200px width, but a "panel widget" open as 300px. A systemtray widget is always ~400x330px.

I also multiplied the minimum widget size so it scales with the DPI.
You can test with:

QT_DEVICE_PIXEL_RATIO=2 plasmoidviewer -a package

Lastly, I added my commented out mockup of the vaultsModel since plasmoidviewer doesn't expose vault's plasmoid.nativeInterface. If you won't use this then I'll remove it.

Diff Detail

Repository
R845 Plasma Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Zren created this revision.Oct 16 2017, 12:59 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 16 2017, 12:59 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham added a subscriber: ngraham.Oct 16 2017, 3:05 AM

Thanks for the patch! Can you change the bugzilla link to "BUG: 385794"? That special keyword makes the bug get marked as resolved once this goes in.

Zren edited the summary of this revision. (Show Details)Oct 16 2017, 4:18 AM
ngraham added a comment.Oct 18 2017, 4:28 PM

@ivan, does this look good?

ivan accepted this revision.Oct 23 2017, 9:21 PM

Looks ok.

Sorry for the late response, I was at a conference without access to Phab.

This revision is now accepted and ready to land.Oct 23 2017, 9:21 PM
Closed by commit R845:0ad9e0a1fdc2: Fix ActionItem Label width, minimumWidth=300, DPI scaled minimum size (authored by Zren). · Explain WhyOct 23 2017, 10:36 PM
This revision was automatically updated to reflect the committed changes.
Zren added a comment.Oct 23 2017, 10:49 PM

No prob, thanks for accepting it (including the mockup stuff). It'll make it easier to test if I see anything else. 🙂

Revision Contents
Changeset List

Diff 21199

View Options

plasma/package/contents/ui/ActionItem.qml

Loading...
View Options

plasma/package/contents/ui/main.qml

Loading...