In T11194#191210, @rempt wrote:

I do not understand how it is possible to not get any warning anymore when saving fails in the ordinary way, because we now explicitly check whether there is a readable file in the destination location.

Related bug report - a race condition in the saving process leading to missing files: https://bugs.kde.org/show_bug.cgi?id=409395, work in progress fix: https://invent.kde.org/kde/krita/merge_requests/59

@scottpetrovic I think both your approach and mine are compatible. I suggest having two separate sections, for now let’s call them “Help most needed” and “Special interest groups”.

While working on plans for QA and looking into the contributor’s manual I arrived at an idea which relates to this effort, maybe from a bit different angle.

• KisMirrorManager: store decoration() pointer in local variable

In D19776#432812, @dkazakov wrote:

The patch looks fine, please push it!

I understand that my inline comment might be considered as a "matter of taste", so it is not obligatory :)

Instead of a separate docker, I propose to add the brush texture controls to the existing Patterns docker (and maybe also to Patterns popup in the toolbar).

• mirror axis: fix paintop box button highlighting

There is one issue left to be solved: the highlight on the paintop box buttons. When the first document is open, the buttons are checked, but not highlighted. After switching around documents it starts working.

• Do not save mirror axis config if default
• code cleanup
• Mirror axis: apply actions to current view; set action state on load

For me it would certainly work in the tool options. I wonder if it would be a hurdle for users coming from other software, though. I think we discussed it a while back with @scottpetrovic, but I do not recall the details.

I would like to say in advance that I do not oppose the change (though must say I quite like the docker, since I worked on it some time ago; that can easily put me into a conflict of interest :). I just want to add some thoughts about a possible accessibility issue I can see as a dyslexic (also I'm not an expert on the matter, just what I know from myself and my relatives).

The redesign is done and merged in master.

I briefly looked into KDE's Breeze theme, it seems to do something to the QDial while painting the widget (it's not necessarily wrong, but it yields different results to the fusion theme under some circumstances). To work around that, I changed the min/max value of the dial and, subsequently, the conversion between the values of the dial and the spinbox. I tested with both Breeze and Fusion Qt themes, under Gnome, and it seems to work fine now.

• KisLayerStyleAngleSelector: make the dial work in KDE's Breeze theme

Thanks for testing.

I fixed a bug that caused the dial to skip the quadrant (90°,180°). That could have caused the moves to other side of the widget.

• KisLayerStyleAngleSelector: change QDial's min/max values

• add license to new files

In D16902#360199, @rempt wrote:

That looks fine. The only thing I wonder about is whether there isn't a way to bunch all the buttons up at the top of the docker when making it tall -- now there's some spacing appearing between the rows if you stretch the docker. But that's not new.

• spec.color.sel: UI cleanup

• unit suffix for KisIntegerColorInput
• right-align Kis*ColorInput/Kis*ParseSpinbox

• spec.color.sel: add colorspace name as button label

From a discussion with @scottpetrovic on the IRC:

I'm trying something different, to address non-trivial UX issues that arose from having masks both in document and on disk.