Layer Styles UI: fix for angle selection, small UI tweaks
c099ae3e614d
Actions

Authored by amedonosova on Dec 9 2018, 8:19 PM.

Description

Layer Styles UI: fix for angle selection, small UI tweaks

Summary:
1, Fix for Bug 372169 - GUI angular control for Shadow light source shows incorrect angle (spinbox is correct)

Adobe’s angle selection dial widget differs from QDial by 90 degrees. That creates the inconsistency between settings dialogs and layer effects. In this diff, angle selection is moved into dedicated widget, KisLayerStyleAngleSelector, which solves this problem for all layer style settings dialogs. Also lessens code duplication in this area.

2, Label alignment unification with proper use of QFormLayout

BUG: 372169

Reviewers: Krita, rempt

Reviewed By: Krita, rempt

Subscribers: rempt

Tags: Krita

Differential Revision: https://phabricator.kde.org/D17134

Details

Committed

amedonosova

Dec 11 2018, 4:48 PM

Reviewer

Krita

Differential Revision

D17134: Layer Styles UI: fix for angle selection, small UI tweaks

Parents

R37:6dc2f8ad43ef: Add missing include needed to check for audio support

Branches

Unknown

Tags

Unknown

amedonosova committed R37:c099ae3e614d: Layer Styles UI: fix for angle selection, small UI tweaks (authored by amedonosova).Dec 11 2018, 4:48 PM

Changes (11)

				Path	Packages
	M			libs/ui/CMakeLists.txt
	M			libs/ui/dialogs/kis_dlg_layer_style.cpp
	M			libs/ui/dialogs/kis_dlg_layer_style.h
	M			libs/ui/layerstyles/WdgGradientOverlay.ui
	M			libs/ui/layerstyles/WdgSatin.ui
	M			libs/ui/layerstyles/WdgStroke.ui
	M			libs/ui/layerstyles/wdgBevelAndEmboss.ui
	A			libs/ui/layerstyles/wdgKisLayerStyleAngleSelector.ui
	M			libs/ui/layerstyles/wdgdropshadow.ui
	A			libs/ui/widgets/KisLayerStyleAngleSelector.cpp
	A			libs/ui/widgets/KisLayerStyleAngleSelector.h