I think I simply forgot to close this long ago.

Ok, i have removed the arcpatch-D24745 branch from the git repo.

That would have been a mistake, as i'm not completely sure on what i'm doing.

Any reason you commited the arcpatch-D24745 branch to git?

Submitted merge request:
https://invent.kde.org/sysadmin/binary-factory-tooling/merge_requests/26

Remove extra flags

Overall the description could be a bit more verbose (explain what kind of game it is :D )

-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -fno-exceptions are added by default by ecm so it's not that even we need to list them here.

The code is too C++-y to me, but it works :D

• Put utils in namespace.

In D24570#546413, @cullmann wrote:

Do you have some developer account to push that yourself? If not, I would go for applying for one, as you seem to care for this stuff and it will be much easier if you can push on your own.

Do you have some developer account to push that yourself? If not, I would go for applying for one, as you seem to care for this stuff and it will be much easier if you can push on your own.

Looks reasonable for me.

Remove KOLFLIB_EXPORT and make kolfprivate library static.

If we're going to make the kolfprivate library to be static, which kind of makes sense since we don't install the includes anyway

This is wrong, these classes are part of a public library, they need the symbols to be exported

Instead of removing KOLFLIB_EXPORT, set a define when building it so it choses the correct dll linkage.

Looks reasonable for me, and should be C++11 API.

It builds and runs on my linux box. I couldn't work out how to get the previous patch to apply, so remade it.

Copied the diff to test on linux

In D24583#545943, @mlaurent wrote:

Just for info. Did you test it on linux too ?

Just for info. Did you test it on linux too ?

This will probably also break msvc.
I’d suggest reading the doc of cmake generate export macros.
The macros are often used wrong...

Cannot be linked by ld with this patch on Linux.

Created merge request for that

push once everything blueprint is merged

Remove dependency on libkmahjongg.

Change platform from mingw64 to win64.

remove dependency on libmahjongg

remove dependency on libkmahjongg

remove libkmahjongg

Ah sorry, i was using that as my base for copy pasting. It's probably not a dependancy.

Why does everything depend on libkmahjongg? If that correct maybe the lib should be renamed 😅

As @cullmann said, msvc is the main supported compiler, qts support for mingw is limited.
Please try msvc where possible.