Feed Advanced Search

Apr 19 2020

asensi added a comment to D28960: Implement Shift+Del to remove cruft from the history of: some comboBoxes on the search dialog.

Thanks for testing and informing, Yuri!

Apr 19 2020, 6:52 AM · Krusader
asensi updated the diff for D28960: Implement Shift+Del to remove cruft from the history of: some comboBoxes on the search dialog.

Some changes which are applied to the same files have been joined into the same code review, in order to ease the testing and reviewing.

Apr 19 2020, 6:50 AM · Krusader
asensi updated the test plan for D28960: Implement Shift+Del to remove cruft from the history of: some comboBoxes on the search dialog.
Apr 19 2020, 6:44 AM · Krusader
yurchor added a comment to D28963: Implement Shift+Del to remove cruft from the history of: several comboBoxes on the Synchronizer dialog.

+1

Apr 19 2020, 5:29 AM · Krusader
yurchor added a comment to D28960: Implement Shift+Del to remove cruft from the history of: some comboBoxes on the search dialog.

+1

Apr 19 2020, 5:29 AM · Krusader
yurchor added a comment to D28962: Implement Shift+Del to remove cruft from the history of: the "Host" comboBox on the "New Network Connection" dialog.

+1

Apr 19 2020, 5:27 AM · Krusader

Apr 18 2020

asensi requested review of D28963: Implement Shift+Del to remove cruft from the history of: several comboBoxes on the Synchronizer dialog.
Apr 18 2020, 7:50 PM · Krusader
asensi requested review of D28962: Implement Shift+Del to remove cruft from the history of: the "Host" comboBox on the "New Network Connection" dialog.
Apr 18 2020, 7:48 PM · Krusader
asensi requested review of D28961: Add a constructor (similar to a KHistoryComboBox one) to the KrHistoryComboBox class.
Apr 18 2020, 7:46 PM · Krusader
asensi requested review of D28960: Implement Shift+Del to remove cruft from the history of: some comboBoxes on the search dialog.
Apr 18 2020, 7:43 PM · Krusader
asensi requested review of D28959: Use qobject_cast and static_cast in some places.
Apr 18 2020, 7:42 PM · Krusader

Apr 16 2020

asensi requested review of D28899: Replace "KRSearchMod" with "KrSearchMod" in order to follow norms.
Apr 16 2020, 10:03 PM · Krusader
asensi requested review of D28898: Replace "KRQuery" with "KrQuery" in order to follow norms.
Apr 16 2020, 10:02 PM · Krusader
asensi requested review of D28897: Replace "KRSpWidgets" with "KrSpWidgets" in order to follow norms.
Apr 16 2020, 10:00 PM · Krusader
asensi requested review of D28896: Replace "KRpermHandler" with "KrPermHandler" in order to follow norms.
Apr 16 2020, 9:58 PM · Krusader
asensi requested review of D28895: Replace "KRPie" with "KrPie" and "KRPieSlice" with "KrPieSlice" in order to follow norms.
Apr 16 2020, 9:56 PM · Krusader
asensi requested review of D28894: Replace "KRFSDisplay" with "KrFSDisplay" in order to follow norms.
Apr 16 2020, 9:52 PM · Krusader

Apr 15 2020

asensi added a comment to D28301: Add options for hiding some useless entries from Media Menu.

@S-trace, I wondered if there was any particular doubt or any suggestion :-?

Apr 15 2020, 11:27 PM · Krusader
asensi requested review of D28872: Replace "KRPleaseWait" with "KrPleaseWait" in order to follow norms.
Apr 15 2020, 11:08 PM · Krusader
asensi requested review of D28871: Replace "KRMaskChoice" with "KrMaskChoice" and "KRMaskChoiceSub" with "KrMaskChoiceSub" in order to follow norms.
Apr 15 2020, 11:06 PM · Krusader
asensi requested review of D28869: Replace "KRGetDate" with "KrGetDate" in order to follow norms.
Apr 15 2020, 11:03 PM · Krusader
asensi requested review of D28868: Replace "KRslots" with "KrSlots" in order to follow norms.
Apr 15 2020, 11:01 PM · Krusader
asensi requested review of D28867: Archives: Replace "KRarcObserver" with "KrArcObserver" in order to follow norms.
Apr 15 2020, 10:58 PM · Krusader
asensi requested review of D28866: Archives: Replace "KRarcHandler" with "KrArcHandler" in order to follow norms.
Apr 15 2020, 10:54 PM · Krusader
asensi closed T12876: Solve some bugs related to archives, remove some duplicated code as Resolved.

Thanks for testing and informing, Yuri!

Apr 15 2020, 10:47 PM · Krusader
asensi closed D28418: Archives: Last steps to unify searches of 7z and 7za executables.
Apr 15 2020, 10:46 PM · Krusader
asensi closed D28417: Archives: Second steps to unify searches of 7z and 7za executables.
Apr 15 2020, 10:46 PM · Krusader
asensi closed D28415: Archives: Rename three KConfigGroups to make things clearer.
Apr 15 2020, 10:46 PM · Krusader
asensi closed D28416: Archives: First steps to unify searches of 7z and 7za executables.
Apr 15 2020, 10:46 PM · Krusader
asensi closed D28414: Archives: Make three member functions more similar. Avoid some searches.
Apr 15 2020, 10:46 PM · Krusader
asensi closed D28413: Archives: Solve the 'QCoreApplication::applicationDirPath: Please instantiate the QApplication object first' error.
Apr 15 2020, 10:46 PM · Krusader
asensi closed D28412: Archives: Add comments in order to avoid problems with code that is related to archives.
Apr 15 2020, 10:46 PM · Krusader
asensi closed D28411: Archives: Fix a 7z execution, allow password asking, clarify the name of a function.
Apr 15 2020, 10:46 PM · Krusader

Apr 7 2020

yurchor added a comment to D28413: Archives: Solve the 'QCoreApplication::applicationDirPath: Please instantiate the QApplication object first' error.

+1. Works for me.

Apr 7 2020, 1:40 PM · Krusader
yurchor accepted D28412: Archives: Add comments in order to avoid problems with code that is related to archives.

Thanks.

Apr 7 2020, 1:34 PM · Krusader
yurchor added a comment to D28411: Archives: Fix a 7z execution, allow password asking, clarify the name of a function.

Works for me. +1

Apr 7 2020, 1:33 PM · Krusader

Mar 30 2020

asensi updated the summary of D28418: Archives: Last steps to unify searches of 7z and 7za executables.
Mar 30 2020, 8:51 PM · Krusader
asensi updated the summary of D28417: Archives: Second steps to unify searches of 7z and 7za executables.
Mar 30 2020, 8:48 PM · Krusader
asensi updated the summary of D28417: Archives: Second steps to unify searches of 7z and 7za executables.
Mar 30 2020, 8:46 PM · Krusader
asensi updated the summary of D28416: Archives: First steps to unify searches of 7z and 7za executables.
Mar 30 2020, 8:44 PM · Krusader
asensi updated the summary of D28415: Archives: Rename three KConfigGroups to make things clearer.
Mar 30 2020, 8:37 PM · Krusader
asensi updated the summary of D28414: Archives: Make three member functions more similar. Avoid some searches.
Mar 30 2020, 6:16 AM · Krusader
asensi added a task to D28417: Archives: Second steps to unify searches of 7z and 7za executables: T12876: Solve some bugs related to archives, remove some duplicated code.
Mar 30 2020, 5:53 AM · Krusader
asensi added a task to D28414: Archives: Make three member functions more similar. Avoid some searches: T12876: Solve some bugs related to archives, remove some duplicated code.
Mar 30 2020, 5:53 AM · Krusader
asensi added a task to D28418: Archives: Last steps to unify searches of 7z and 7za executables: T12876: Solve some bugs related to archives, remove some duplicated code.
Mar 30 2020, 5:53 AM · Krusader
asensi added revisions to T12876: Solve some bugs related to archives, remove some duplicated code: D28414: Archives: Make three member functions more similar. Avoid some searches, D28415: Archives: Rename three KConfigGroups to make things clearer, D28416: Archives: First steps to unify searches of 7z and 7za executables, D28417: Archives: Second steps to unify searches of 7z and 7za executables, D28418: Archives: Last steps to unify searches of 7z and 7za executables.
Mar 30 2020, 5:53 AM · Krusader
asensi added a task to D28415: Archives: Rename three KConfigGroups to make things clearer: T12876: Solve some bugs related to archives, remove some duplicated code.
Mar 30 2020, 5:53 AM · Krusader
asensi added a task to D28416: Archives: First steps to unify searches of 7z and 7za executables: T12876: Solve some bugs related to archives, remove some duplicated code.
Mar 30 2020, 5:53 AM · Krusader
asensi requested review of D28418: Archives: Last steps to unify searches of 7z and 7za executables.
Mar 30 2020, 5:52 AM · Krusader
asensi requested review of D28417: Archives: Second steps to unify searches of 7z and 7za executables.
Mar 30 2020, 5:50 AM · Krusader
asensi requested review of D28416: Archives: First steps to unify searches of 7z and 7za executables.
Mar 30 2020, 5:48 AM · Krusader
asensi requested review of D28415: Archives: Rename three KConfigGroups to make things clearer.
Mar 30 2020, 5:46 AM · Krusader
asensi requested review of D28414: Archives: Make three member functions more similar. Avoid some searches.
Mar 30 2020, 5:41 AM · Krusader

Mar 29 2020

asensi added a revision to T12876: Solve some bugs related to archives, remove some duplicated code: D28413: Archives: Solve the 'QCoreApplication::applicationDirPath: Please instantiate the QApplication object first' error.
Mar 29 2020, 11:48 PM · Krusader
asensi added a task to D28413: Archives: Solve the 'QCoreApplication::applicationDirPath: Please instantiate the QApplication object first' error: T12876: Solve some bugs related to archives, remove some duplicated code.
Mar 29 2020, 11:48 PM · Krusader
asensi requested review of D28413: Archives: Solve the 'QCoreApplication::applicationDirPath: Please instantiate the QApplication object first' error.
Mar 29 2020, 11:47 PM · Krusader
asensi added a revision to T12876: Solve some bugs related to archives, remove some duplicated code: D28412: Archives: Add comments in order to avoid problems with code that is related to archives.
Mar 29 2020, 11:41 PM · Krusader
asensi added a task to D28412: Archives: Add comments in order to avoid problems with code that is related to archives: T12876: Solve some bugs related to archives, remove some duplicated code.
Mar 29 2020, 11:41 PM · Krusader
asensi requested review of D28412: Archives: Add comments in order to avoid problems with code that is related to archives.
Mar 29 2020, 11:38 PM · Krusader
asensi added a task to D28411: Archives: Fix a 7z execution, allow password asking, clarify the name of a function: T12876: Solve some bugs related to archives, remove some duplicated code.
Mar 29 2020, 11:33 PM · Krusader
asensi added a revision to T12876: Solve some bugs related to archives, remove some duplicated code: D28411: Archives: Fix a 7z execution, allow password asking, clarify the name of a function.
Mar 29 2020, 11:33 PM · Krusader
asensi requested review of D28411: Archives: Fix a 7z execution, allow password asking, clarify the name of a function.
Mar 29 2020, 11:32 PM · Krusader
asensi updated the task description for T12876: Solve some bugs related to archives, remove some duplicated code.
Mar 29 2020, 10:27 PM · Krusader
asensi created T12876: Solve some bugs related to archives, remove some duplicated code.
Mar 29 2020, 10:02 PM · Krusader
asensi added a comment to D26887: Synchronizer: Avoid that, in several cases, the default action is to overwrite a file with an old version of it.

+1 Tested for several months without issues.

Mar 29 2020, 9:24 PM · Krusader
asensi closed D26887: Synchronizer: Avoid that, in several cases, the default action is to overwrite a file with an old version of it.
Mar 29 2020, 9:24 PM · Krusader
asensi added a comment to D28301: Add options for hiding some useless entries from Media Menu.

There is more information in Bug 294162 - Wish: Hide/Show special devices/mounts from devices-dropdown list. There, a possible example (https://phabricator.kde.org/D27019) of how to fix the issue was suggested.

Mar 29 2020, 10:18 AM · Krusader
asensi added inline comments to D28301: Add options for hiding some useless entries from Media Menu.
Mar 29 2020, 10:12 AM · Krusader
asensi added a comment to D28301: Add options for hiding some useless entries from Media Menu.

Thank you very much, S-trace. Your work avoids cases like the one in https://i.stack.imgur.com/QTx1O.jpg (from https://askubuntu.com/questions/1109715/hide-loop-partitions-snaps-in-krusader)

Mar 29 2020, 10:02 AM · Krusader

Mar 28 2020

yurchor added a comment to D26887: Synchronizer: Avoid that, in several cases, the default action is to overwrite a file with an old version of it.

+1 Tested for several months without issues.

Mar 28 2020, 2:16 PM · Krusader

Mar 26 2020

S-trace updated the test plan for D28301: Add options for hiding some useless entries from Media Menu.
Mar 26 2020, 5:02 PM · Krusader
yurchor added inline comments to D28301: Add options for hiding some useless entries from Media Menu.
Mar 26 2020, 11:09 AM · Krusader
S-trace added inline comments to D28301: Add options for hiding some useless entries from Media Menu.
Mar 26 2020, 11:05 AM · Krusader
yurchor added inline comments to D28301: Add options for hiding some useless entries from Media Menu.
Mar 26 2020, 10:41 AM · Krusader
S-trace updated the diff for D28301: Add options for hiding some useless entries from Media Menu.

Merge 2 features into a single diff

Mar 26 2020, 10:35 AM · Krusader
S-trace updated the diff for D28301: Add options for hiding some useless entries from Media Menu.

Add the list of mount points to hide in Media Menu to the "Panel/Media Menu/" page

Mar 26 2020, 10:32 AM · Krusader
S-trace requested review of D28301: Add options for hiding some useless entries from Media Menu.
Mar 26 2020, 10:18 AM · Krusader

Mar 10 2020

asensi closed D27819: Solve what happens when F4 is pressed to try to edit a remote folder.
Mar 10 2020, 9:32 PM · Krusader
asensi added a comment to D27819: Solve what happens when F4 is pressed to try to edit a remote folder.

All right. Thanks, Davide!

Mar 10 2020, 9:30 PM · Krusader
asensi updated the summary of D27819: Solve what happens when F4 is pressed to try to edit a remote folder.
Mar 10 2020, 9:30 PM · Krusader
gengisdave accepted D27819: Solve what happens when F4 is pressed to try to edit a remote folder.

Work fine, tested locally and with ftp:, fish: and smb: with success.

Mar 10 2020, 2:40 PM · Krusader

Mar 3 2020

asensi updated the test plan for D27819: Solve what happens when F4 is pressed to try to edit a remote folder.
Mar 3 2020, 11:18 PM · Krusader
asensi updated the test plan for D27819: Solve what happens when F4 is pressed to try to edit a remote folder.
Mar 3 2020, 11:17 PM · Krusader
asensi updated the test plan for D27819: Solve what happens when F4 is pressed to try to edit a remote folder.
Mar 3 2020, 11:17 PM · Krusader
asensi requested review of D27819: Solve what happens when F4 is pressed to try to edit a remote folder.
Mar 3 2020, 11:14 PM · Krusader
asensi added a comment to D24987: Add Kompare as compare application with KIO support.

In the meantime, the not directly related changes were applied in https://phabricator.kde.org/D27609.

Mar 3 2020, 11:00 PM · Krusader
asensi closed D27609: Several not-interrelated minor changes that were pending.
Mar 3 2020, 10:57 PM · Documentation, Krusader
asensi closed D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file. Use `make -j$(nproc)`.
Mar 3 2020, 10:49 PM · Krusader
asensi added a comment to D27609: Several not-interrelated minor changes that were pending.

Well, thanks Davide and Alex!

Mar 3 2020, 10:35 PM · Documentation, Krusader
gengisdave accepted D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file. Use `make -j$(nproc)`.

Fine to me

Mar 3 2020, 7:16 AM · Krusader
gengisdave accepted D27609: Several not-interrelated minor changes that were pending.

Fine to me

Mar 3 2020, 7:15 AM · Documentation, Krusader
gengisdave closed D27302: Update obsolete KProcess::error.
Mar 3 2020, 7:13 AM · Krusader
gengisdave closed D27290: Update obsolete QWidget::getContentsMargins.
Mar 3 2020, 7:12 AM · Krusader
gengisdave closed D27289: Update obsolete QString::sprintf.
Mar 3 2020, 7:09 AM · Krusader

Feb 23 2020

asensi requested review of D27609: Several not-interrelated minor changes that were pending.
Feb 23 2020, 9:15 PM · Documentation, Krusader
asensi added a comment to D27446: Changes in names of variables, functions, and comments (due to recent changes and old ones).

Thanks for reviewing, Davide!

Feb 23 2020, 8:56 PM · Krusader
asensi closed D27446: Changes in names of variables, functions, and comments (due to recent changes and old ones).
Feb 23 2020, 8:54 PM · Krusader

Feb 22 2020

asensi added a comment to D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file. Use `make -j$(nproc)`.

Hello, what do you think about using make -j$(nproc) instead of just make this way all the available
cores are used for compiling.
This is just a little trick I sometimes forget to change when I follow build instructions.

Feb 22 2020, 7:32 PM · Krusader
asensi updated the summary of D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file. Use `make -j$(nproc)`.
Feb 22 2020, 7:31 PM · Krusader
asensi updated the diff for D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file. Use `make -j$(nproc)`.

As Alex Lohnau proposed, use make -j$(nproc).

Feb 22 2020, 7:30 PM · Krusader