Differential D28413

Archives: Solve the 'QCoreApplication::applicationDirPath: Please instantiate the QApplication object first' error
ClosedPublic
Actions

Authored by asensi on Mar 29 2020, 11:47 PM.

Details

Reviewers

None

Group Reviewers

Krusader

Maniphest Tasks

T12876: Solve some bugs related to archives, remove some duplicated code

Commits

R167:2f168d23c20d: Archives: Solve the 'QCoreApplication::applicationDirPath: Please instantiate…

Summary

Solve the «QCoreApplication::applicationDirPath: Please instantiate the QApplication object first» error, what required moving code.

Besides, after the code of the generateKrarcArchiveMimetypes() function was moved to a constructor, that code is executed only once and the source code ends up being simplified. Make the KrServices class simpler by moving archive-related code to an archive-related class.

FIXED: [ 417107 ] QCoreApplication::applicationDirPath: Please instantiate the QApplication object first
BUG: 417107

Test Plan

The test plan of the task defined in Solve some bugs related to archives, remove some duplicated code.

Diff Detail

Repository

R167 Krusader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

asensi requested review of this revision.Mar 29 2020, 11:47 PM

asensi created this revision.

asensi added a task: T12876: Solve some bugs related to archives, remove some duplicated code.

+1. Works for me.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 15 2020, 10:46 PM

Closed by commit R167:2f168d23c20d: Archives: Solve the 'QCoreApplication::applicationDirPath: Please instantiate… (authored by asensi). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			krArc/krarcbasemanager.cpp (2 lines)
M			krusader/Archive/abstractthreadedjob.cpp (4 lines)
M			krusader/Archive/krarchandler.h (14 lines)
M			krusader/Archive/krarchandler.cpp (72 lines)
M			krusader/Archive/packjob.cpp (2 lines)
M			krusader/Konfigurator/kgprotocols.cpp (3 lines)
M			krusader/Panel/panelfunc.cpp (2 lines)
M			krusader/Search/krsearchmod.cpp (5 lines)
M			krusader/krglobal.h (3 lines)
M			krusader/krglobal.cpp (1 line)
M			krusader/krservices.h (6 lines)
M			krusader/krservices.cpp (87 lines)
M			krusader/krusader.cpp (4 lines)
M			krusader/main.cpp (3 lines)