Differential D28414

Archives: Make three member functions more similar. Avoid some searches
ClosedPublic
Actions

Authored by asensi on Mar 30 2020, 5:41 AM.

Details

Reviewers
None
Group Reviewers
Krusader
Maniphest Tasks
T12876: Solve some bugs related to archives, remove some duplicated code
Commits
R167:f073887ece2e: Archives: Make three member functions more similar. Avoid some searches
Summary

Make three member functions more similar, in order to port future changes more easily from one function to the other.

Also, in some cases when the path to a program is found: remember the path for the next time, avoiding some future searches.

Remove detectFullPathName code that nowadays can be substituted by QStandardPaths::findExecutable(name).

Test Plan

The test plan of the task defined in Solve some bugs related to archives, remove some duplicated code.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asensi requested review of this revision.Mar 30 2020, 5:41 AM
asensi created this revision.
asensi edited the summary of this revision. (Show Details)Mar 30 2020, 6:16 AM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 15 2020, 10:46 PM
Closed by commit R167:f073887ece2e: Archives: Make three member functions more similar. Avoid some searches (authored by asensi). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MkrArc/krarc.h (1 line)
MkrArc/krarc.cpp (32 lines)
Mkrusader/krservices.cpp (22 lines)

Diff 80244

View Options

krArc/krarc.h

Loading...
View Options

krArc/krarc.cpp

Loading...
View Options

krusader/krservices.cpp

Loading...