Feed Advanced Search

Feb 24 2018

winterz added a comment to T7193: KCalCore: dump the versit code.

see D10799

Feb 24 2018, 4:28 PM
winterz requested review of D10799: KCalCore: remove local versit copy and use libical's icalvcal library instead.
Feb 24 2018, 4:26 PM · KDE PIM

Feb 22 2018

winterz committed R978:a9375e3d54ec: .krazy - skip src/MainWidgetBase.ui (authored by winterz).
.krazy - skip src/MainWidgetBase.ui
Feb 22 2018, 3:56 PM

Feb 5 2018

winterz committed R175:ee50bae469b2: I'll take maintainership --Allen (authored by winterz).
I'll take maintainership --Allen
Feb 5 2018, 1:20 PM

Feb 3 2018

winterz added a comment to D10255: Prevent infinite recursion in messagelist.

Dan,
I tried your patch and hit the infinite recursion within seconds in my inbox folder.
Going back to my patch.

Feb 3 2018, 4:07 PM · KDE PIM

Feb 2 2018

winterz added a comment to D7591: Fix use-after-free.

well, Dan already approved it. So sure.

Feb 2 2018, 11:07 PM · KDE PIM

Jan 30 2018

winterz committed R81:638772af958e: korganizer/plugins/CMakeLists.txt - disable lunarphases for now (too ugly) (authored by winterz).
korganizer/plugins/CMakeLists.txt - disable lunarphases for now (too ugly)
Jan 30 2018, 8:03 PM
winterz committed R81:a678c6bafc23: Feature: A calendar plugin for lunar phases as agenda view decorations. not the… (authored by winterz).
Feature: A calendar plugin for lunar phases as agenda view decorations. not the…
Jan 30 2018, 6:37 PM

Jan 25 2018

winterz committed R958:924bf8357531: sanitizer/tools/check-xml-syntax.sh - use checkXML5 (authored by winterz).
sanitizer/tools/check-xml-syntax.sh - use checkXML5
Jan 25 2018, 10:16 PM

Jan 15 2018

winterz committed R175:0afaa45c17c6: various - minor coding style. mostly dealing with long lines (authored by winterz).
various - minor coding style. mostly dealing with long lines
Jan 15 2018, 10:30 PM
winterz committed R175:4b05f76c12ea: holidayscannerplan.cpp - fix write-string warnings (authored by winterz).
holidayscannerplan.cpp - fix write-string warnings
Jan 15 2018, 10:30 PM
winterz committed R175:b83260ea32c5: various - clang-tidy recommendations (authored by winterz).
various - clang-tidy recommendations
Jan 15 2018, 10:30 PM
winterz committed R175:162a623f5883: src/parsers/plan2/FlexLexer.h - fix override warnings (authored by winterz).
src/parsers/plan2/FlexLexer.h - fix override warnings
Jan 15 2018, 10:30 PM
winterz committed R175:526ff31d0036: src/parsers/qcalendarsystem.cpp - fix fallthrough warnings (authored by winterz).
src/parsers/qcalendarsystem.cpp - fix fallthrough warnings
Jan 15 2018, 10:30 PM
winterz committed R175:f0c1be4f603f: holidayregion.cpp,parsers/qcalendarsystem.cpp,zodiac.h - explicit ctors (authored by winterz).
holidayregion.cpp,parsers/qcalendarsystem.cpp,zodiac.h - explicit ctors
Jan 15 2018, 10:30 PM
winterz committed R175:b45888dc5869: src/declarative/holidayregionsmodel.h - fix include guard (authored by winterz).
src/declarative/holidayregionsmodel.h - fix include guard
Jan 15 2018, 10:30 PM
winterz committed R175:23632bc1babb: src/declarative/holidaysmodel.h - remove 0-byte file (authored by winterz).
src/declarative/holidaysmodel.h - remove 0-byte file
Jan 15 2018, 10:30 PM
winterz committed R175:48e6273fab55: parsers/plan2/holidayparserdriverplan.cpp - redundant void in arg list (authored by winterz).
parsers/plan2/holidayparserdriverplan.cpp - redundant void in arg list
Jan 15 2018, 10:30 PM
winterz committed R175:e8f29adee09d: qcalendarsystem.cpp - handle ununsed arg in QCalendarSystemPrivate… (authored by winterz).
qcalendarsystem.cpp - handle ununsed arg in QCalendarSystemPrivate…
Jan 15 2018, 10:29 PM
winterz committed R175:8d031e303ae5: holiday_p.h, holidayregion.cpp - move static functions to the implementation (authored by winterz).
holiday_p.h, holidayregion.cpp - move static functions to the implementation
Jan 15 2018, 4:43 PM

Jan 13 2018

winterz committed R76:3dbdbfc66faf: refactor, add a tooltip for the day/hour cells for each timezone label (authored by winterz).
refactor, add a tooltip for the day/hour cells for each timezone label
Jan 13 2018, 4:28 PM
winterz committed R76:9aada337bdfd: Merge branch 'Applications/17.12' (authored by winterz).
Merge branch 'Applications/17.12'
Jan 13 2018, 2:55 PM
winterz committed R76:73db0afccec6: timelabels.cpp - fix invalid times when using multiple timezones BUG: 369365… (authored by winterz).
timelabels.cpp - fix invalid times when using multiple timezones BUG: 369365…
Jan 13 2018, 2:43 PM

Jan 10 2018

winterz committed R238:4b6816e54882: customization/entities/contributor.entities - fix typo . missing '>' (authored by winterz).
customization/entities/contributor.entities - fix typo . missing '>'
Jan 10 2018, 1:46 PM

Jan 8 2018

winterz committed R175:be0f38c66231: src/parsers/holidayparserdriver.cpp - astro seasons category (authored by winterz).
src/parsers/holidayparserdriver.cpp - astro seasons category
Jan 8 2018, 1:30 PM

Jan 6 2018

winterz committed R210:92543bc8556b: use the new kholidays with the category list method (authored by winterz).
use the new kholidays with the category list method
Jan 6 2018, 4:07 PM
winterz committed R175:f30afcb74a81: astronomical seasons automatically added to all holidays no longer need to add… (authored by winterz).
astronomical seasons automatically added to all holidays no longer need to add…
Jan 6 2018, 4:00 PM
winterz committed R172:de621654718e: Revert "Compat libical<3 reference data" (authored by winterz).
Revert "Compat libical<3 reference data"
Jan 6 2018, 3:08 PM
winterz added a reverting change for R172:0a2e0e0e01b2: Compat libical<3 reference data: R172:de621654718e: Revert "Compat libical<3 reference data".
Jan 6 2018, 3:08 PM
winterz committed R172:0a2e0e0e01b2: Compat libical<3 reference data (authored by winterz).
Compat libical<3 reference data
Jan 6 2018, 3:01 PM
winterz committed R172:f27b928e2bff: autotests/CMakeLists.txt - correct fix for the libical3 Compat test CCMAIL… (authored by winterz).
autotests/CMakeLists.txt - correct fix for the libical3 Compat test CCMAIL…
Jan 6 2018, 2:42 PM
winterz committed R172:48ead3d255b5: Revert "Fix ref data for the Compat-libical3" not the correct fix (authored by winterz).
Revert "Fix ref data for the Compat-libical3" not the correct fix
Jan 6 2018, 2:42 PM
winterz added a reverting change for R172:314b7cccb6ff: Fix ref data for the Compat-libical3 CCMAIL: dvratil@kde.org: R172:48ead3d255b5: Revert "Fix ref data for the Compat-libical3" not the correct fix.
Jan 6 2018, 2:42 PM
winterz committed R172:314b7cccb6ff: Fix ref data for the Compat-libical3 CCMAIL: dvratil@kde.org (authored by winterz).
Fix ref data for the Compat-libical3 CCMAIL: dvratil@kde.org
Jan 6 2018, 2:26 PM

Jan 5 2018

winterz added a comment to D9680: holiday_si_sl: updated Slovenian holidays.

thanks Albert

Jan 5 2018, 9:48 PM · KDE PIM
winterz accepted D9680: holiday_si_sl: updated Slovenian holidays.

do you have a commiter account? If not, I can commit for you. let me know
-Allen

Jan 5 2018, 4:46 PM · KDE PIM

Dec 27 2017

winterz committed R78:c8c1383b414c: src/ui/dialogdesktop.ui - say "Modify" instead of "Configure" sounds better to… (authored by winterz).
src/ui/dialogdesktop.ui - say "Modify" instead of "Configure" sounds better to…
Dec 27 2017, 9:36 PM

Dec 19 2017

winterz added a comment to D7528: Kontact: iconsidepane spacing between icons (for Qt5.9.1).

we can revert easily enough if this causes problems.
No I am not using Wayland.

Dec 19 2017, 8:21 PM · KDE PIM
winterz committed R209:1d9fdc90ffca: src/iconsidepane.cpp - iconsidepane spacing between icons (for Qt5.9.1) (authored by winterz).
src/iconsidepane.cpp - iconsidepane spacing between icons (for Qt5.9.1)
Dec 19 2017, 8:20 PM
winterz closed D7528: Kontact: iconsidepane spacing between icons (for Qt5.9.1).
Dec 19 2017, 8:20 PM · KDE PIM

Dec 18 2017

winterz committed R76:6af14f3b687f: Merge branch 'Applications/17.12' (authored by winterz).
Merge branch 'Applications/17.12'
Dec 18 2017, 9:45 PM
winterz committed R76:04875981a0ef: agendaview.cpp - in loadDecorations(), don't add failed decos to the list if… (authored by winterz).
agendaview.cpp - in loadDecorations(), don't add failed decos to the list if…
Dec 18 2017, 9:43 PM

Dec 16 2017

winterz added a comment to D7528: Kontact: iconsidepane spacing between icons (for Qt5.9.1).

before I commit this...

Dec 16 2017, 3:40 PM · KDE PIM

Dec 13 2017

winterz committed R76:7ee5fe3c31f4: .krazy - add krazy config (authored by winterz).
.krazy - add krazy config
Dec 13 2017, 11:21 PM
winterz committed R76:53f2bbb7b10b: timelabels.cpp - use new tzUTCOffsetStr from kcalutils and some code styling… (authored by winterz).
timelabels.cpp - use new tzUTCOffsetStr from kcalutils and some code styling…
Dec 13 2017, 11:20 PM

Dec 11 2017

winterz committed R173:6705bf168adf: new static method tzUTCOffsetStr for pretty printing UTC offset (authored by winterz).
new static method tzUTCOffsetStr for pretty printing UTC offset
Dec 11 2017, 2:22 PM
winterz closed D9273: KCalUtils: new method tzUTCOffsetStr.
Dec 11 2017, 2:22 PM · KDE PIM

Dec 10 2017

winterz updated the diff for D9273: KCalUtils: new method tzUTCOffsetStr.

improved. more unittests

Dec 10 2017, 1:52 PM · KDE PIM

Dec 9 2017

winterz committed R173:74191f391f05: fix reference data so testincidenceformatter passes (authored by winterz).
fix reference data so testincidenceformatter passes
Dec 9 2017, 9:18 PM
winterz created D9273: KCalUtils: new method tzUTCOffsetStr.
Dec 9 2017, 6:38 PM · KDE PIM
winterz committed R210:9a4e11c38fc9: add background coloring to the appointment happening today or urgent (authored by winterz).
add background coloring to the appointment happening today or urgent
Dec 9 2017, 3:13 PM
winterz committed R210:facc8f55e572: restore tooltips in the apptsummaryplugin (authored by winterz).
restore tooltips in the apptsummaryplugin
Dec 9 2017, 2:00 PM
winterz closed D9231: KOrganizer Summary Plugin: restore tooltips for appointments.
Dec 9 2017, 2:00 PM · KDE PIM
winterz committed R170:6a21943409cd: publishdialog.cpp,h - validate email address string before accepting (authored by winterz).
publishdialog.cpp,h - validate email address string before accepting
Dec 9 2017, 1:54 PM
winterz closed D9263: Akonadi-Calendar: PublishDialog: Validate recipients list.
Dec 9 2017, 1:54 PM · KDE PIM

Dec 8 2017

winterz added reviewers for D9263: Akonadi-Calendar: PublishDialog: Validate recipients list: dvratil, mlaurent.
Dec 8 2017, 6:38 PM · KDE PIM
winterz created D9263: Akonadi-Calendar: PublishDialog: Validate recipients list.
Dec 8 2017, 6:38 PM · KDE PIM
winterz updated the diff for D9231: KOrganizer Summary Plugin: restore tooltips for appointments.

handles Laurent's comments

Dec 8 2017, 3:27 PM · KDE PIM

Dec 6 2017

winterz created D9231: KOrganizer Summary Plugin: restore tooltips for appointments.
Dec 6 2017, 6:13 PM · KDE PIM

Dec 4 2017

winterz updated the diff for D7528: Kontact: iconsidepane spacing between icons (for Qt5.9.1).

update patch so it applies to cleanly to current source.
no functional changes

Dec 4 2017, 6:34 PM · KDE PIM

Dec 3 2017

winterz committed R206:bb3df07a068d: configure plugin fixes for Akonadi instances (authored by winterz).
configure plugin fixes for Akonadi instances
Dec 3 2017, 3:14 PM
winterz closed D6507: KMail: configure plugin fixes for Akonadi instances.
Dec 3 2017, 3:14 PM · KDE PIM

Dec 2 2017

winterz updated the diff for D6507: KMail: configure plugin fixes for Akonadi instances.

updated patch that that

  1. applies cleanly to master
  2. addresses Laurent's concerns
  3. renames the interface variable to agent, as requested by Dan
Dec 2 2017, 6:18 PM · KDE PIM

Dec 1 2017

winterz added a comment to D6507: KMail: configure plugin fixes for Akonadi instances.

patch doesn't apply cleanly anymore. I'll upload a new patch

Dec 1 2017, 3:30 PM · KDE PIM
winterz added a comment to D6507: KMail: configure plugin fixes for Akonadi instances.

Laurent, I lost this local patch and that broke some things.
Can I commit?

Dec 1 2017, 3:17 PM · KDE PIM

Nov 28 2017

winterz added a comment to D8843: Use URLs in multiget requests as returned by the Server.

This commit breaks caldav on kolab servers.
I have reverted locally and my caldav calendars work again.

Nov 28 2017, 1:59 PM · KDE PIM

Nov 27 2017

winterz added a comment to D8996: Make sure the autotest fails if the .ref file is missing..

Yes, please do, once I push the ref file.

Nov 27 2017, 11:17 PM · KDE PIM
winterz committed R172:576610dccfeb: add back the AppleICal test for the libical3-based code (authored by winterz).
add back the AppleICal test for the libical3-based code
Nov 27 2017, 11:16 PM
winterz committed R172:fda588cc25f8: Merge branch 'Applications/17.12' (authored by winterz).
Merge branch 'Applications/17.12'
Nov 27 2017, 10:56 PM
winterz added a comment to D8996: Make sure the autotest fails if the .ref file is missing..

but this also makes me wonder, why was AppleICal_1.5.ics not copied to Compat-libical3?

When I did the libical3 port, I noticed that AppleICal_1.5.ics didn't have a corresponding .ref file. that's why ignored it.

Nov 27 2017, 8:25 PM · KDE PIM
winterz accepted D9020: akonadi: remove superfluous curly brace from KF5_INSTALL_TARGETS_DEFAULT_ARGS.
Nov 27 2017, 3:52 PM · KDE PIM

Nov 16 2017

winterz committed R210:63178a552a0a: views/collectionview/reparentingmodel.cpp - use intptr_t instead of long as… (authored by winterz).
views/collectionview/reparentingmodel.cpp - use intptr_t instead of long as…
Nov 16 2017, 11:36 PM
winterz committed R210:cd9d66f26178: src/kodialogmanager.cpp - pass by const ref to act() (authored by winterz).
src/kodialogmanager.cpp - pass by const ref to act()
Nov 16 2017, 11:36 PM
winterz committed R210:dae0e0f1692b: src/calendarview.h - remove unused class private variable (authored by winterz).
src/calendarview.h - remove unused class private variable
Nov 16 2017, 11:36 PM
winterz committed R210:4282d67df7b8: src/korganizer_part.cpp - dynamic_cast instead of old C-style cast (authored by winterz).
src/korganizer_part.cpp - dynamic_cast instead of old C-style cast
Nov 16 2017, 11:36 PM
winterz committed R210:f64b13e05d86: src/prefs/koprefsdialog - plug 2 memory leaks (authored by winterz).
src/prefs/koprefsdialog - plug 2 memory leaks
Nov 16 2017, 11:36 PM
winterz committed R210:2f50e855d237: akonadicollectionview.cpp - move hasCompatibleMimeTypes() outside of namespace… (authored by winterz).
akonadicollectionview.cpp - move hasCompatibleMimeTypes() outside of namespace…
Nov 16 2017, 11:36 PM
winterz committed R210:f9221a07f0be: various - spelling fixes (authored by winterz).
various - spelling fixes
Nov 16 2017, 11:27 PM
winterz committed R172:6d44015e7e9b: various - remove duplicate includes and some minor coding style fixes (authored by winterz).
various - remove duplicate includes and some minor coding style fixes
Nov 16 2017, 11:14 PM
winterz committed R172:83b5b0ba1f8d: src/icaltimezones_p.h - fix include guard (authored by winterz).
src/icaltimezones_p.h - fix include guard
Nov 16 2017, 11:14 PM
winterz committed R170:42d654e1d2da: itiphandler.cpp - reset Operation when canceling the publish dialog (authored by winterz).
itiphandler.cpp - reset Operation when canceling the publish dialog
Nov 16 2017, 10:15 PM
winterz committed R95:e5b948189d15: src/pimcommonakonadi/acl/aclmodifyjob.cpp - Fix messagebox text REVIEW: 127845 (authored by winterz).
src/pimcommonakonadi/acl/aclmodifyjob.cpp - Fix messagebox text REVIEW: 127845
Nov 16 2017, 9:18 PM

Oct 29 2017

winterz closed T658: [KOrganizer] Trash ical2val stuff (the so-called import ical) as Resolved.

I'm handled this. done in commit 6d3db604214f036cb448aa14f823f626c4715d78

Oct 29 2017, 4:43 PM · KDE PIM
winterz committed R210:6d3db604214f: src/actionmanager.[cpp,h], index.docbook - remove the old UNIX ical import… (authored by winterz).
src/actionmanager.[cpp,h], index.docbook - remove the old UNIX ical import…
Oct 29 2017, 4:42 PM
winterz added a comment to T7193: KCalCore: dump the versit code.

This is done in kcalcore's remove-versit branch.

Oct 29 2017, 1:33 PM
winterz committed R172:79f5d3b0a380: remove the ancient versit stuff and use libical's vcal library instead. (authored by winterz).
remove the ancient versit stuff and use libical's vcal library instead.
Oct 29 2017, 1:31 PM

Oct 27 2017

winterz closed D8509: Added Korean lunar holiday entries until 2037/12/31 .

done.

Oct 27 2017, 3:34 PM · KDE PIM
winterz accepted D8509: Added Korean lunar holiday entries until 2037/12/31 .

seems ok.
I committed this for you in the master and 17.08 branches.

Oct 27 2017, 3:34 PM · KDE PIM
winterz committed R175:c10987596220: Merge branch 'Applications/17.08' (authored by winterz).
Merge branch 'Applications/17.08'
Oct 27 2017, 3:33 PM
winterz committed R175:08c5c6be92b4: holidays/plan2/holiday_kr_ko - Added Korean lunar holiday entries until… (authored by winterz).
holidays/plan2/holiday_kr_ko - Added Korean lunar holiday entries until…
Oct 27 2017, 3:31 PM

Oct 24 2017

winterz closed T7192: KCalCore: make it build and test ok for the upcoming libical3 release as Resolved.

done now.

Oct 24 2017, 12:09 PM

Oct 21 2017

winterz committed R172:978415cd1acb: Merge branch 'master' into libical3 (authored by winterz).
Merge branch 'master' into libical3
Oct 21 2017, 4:54 PM

Oct 18 2017

winterz added a comment to D8255: #include <strings.h> for strcasecmp in versit parser.

do you need me to commit for you?

Oct 18 2017, 5:06 PM · KDE PIM

Oct 14 2017

winterz added a comment to D7591: Fix use-after-free.

was this committed yet?

Oct 14 2017, 6:13 PM · KDE PIM

Oct 12 2017

winterz created T7193: KCalCore: dump the versit code.
Oct 12 2017, 12:37 PM
winterz added a comment to T7192: KCalCore: make it build and test ok for the upcoming libical3 release.

I have this almost done now. look in the libical3 branch.
Should build with all libicals.

Oct 12 2017, 12:21 PM
winterz created T7192: KCalCore: make it build and test ok for the upcoming libical3 release.
Oct 12 2017, 12:20 PM
winterz accepted D8255: #include <strings.h> for strcasecmp in versit parser.

thanks.

Oct 12 2017, 12:12 PM · KDE PIM

Oct 9 2017

winterz committed R172:d70b2cceb24f: autotests/data/Compat - restore the original Compat from master we have the… (authored by winterz).
autotests/data/Compat - restore the original Compat from master we have the…
Oct 9 2017, 1:40 PM
winterz committed R172:e6d8bb9b4b56: Merge branch 'master' into libical3 (authored by winterz).
Merge branch 'master' into libical3
Oct 9 2017, 12:49 PM